From: "Ludovic Courtès" <ludo@gnu.org>
To: Leo Prikler <leo.prikler@student.tugraz.at>
Cc: 47824@debbugs.gnu.org, efraim@flashner.co.il
Subject: [bug#47824] [PATCH 0/3] Happy hacking in the Spring 2021 LGJ
Date: Wed, 05 May 2021 16:16:22 +0200 [thread overview]
Message-ID: <874kfhjmfd.fsf_-_@gnu.org> (raw)
In-Reply-To: <20210419081744.7247-3-leo.prikler@student.tugraz.at> (Leo Prikler's message of "Mon, 19 Apr 2021 10:17:44 +0200")
Hi Leo,
On a cursory look, all three patches LGTM.
One nit:
> + "exec "
> + (assoc-ref inputs "guile-runtime")
> + "/bin/guile " args)))
[...]
> ("guile" ,guile-3.0)
> ("pkg-config" ,pkg-config)
> ("texinfo" ,texinfo)))
> - (propagated-inputs
> - `(("guile-sdl2" ,guile3.0-sdl2)))
> + (inputs
> + `(("guile-sdl2" ,guile3.0-sdl2)
> + ("guile-runtime" ,guile-3.0)))
I think it’s best to not play trick with labels, and to always use the
package name as the label (to facilitate migration on the day where we
get rid of labels, who knows…).
A common pattern for the case above is to provide “guile” both as native
input and input, and to write:
(assoc-ref (or native-inputs inputs) "guile")
Thanks, and congrats to the Lisp Game Jam participants!
Ludo’.
next prev parent reply other threads:[~2021-05-05 14:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 11:05 [bug#47824] [PATCH 0/3] Happy hacking in the Spring 2021 LGJ Leo Prikler
2021-04-16 11:07 ` [bug#47824] [PATCH 1/3] gnu: guile-sdl2: Update to 0.6.0 Leo Prikler
2021-04-16 11:07 ` [bug#47824] [PATCH 2/3] gnu: guile-chickadee: Update to 0.7.0 Leo Prikler
2021-04-16 11:07 ` [bug#47824] [PATCH 3/3] gnu: tsukundere: Update to 0.3.0 Leo Prikler
2021-04-19 7:56 ` Efraim Flashner
2021-04-19 8:24 ` Leo Prikler
2021-04-19 8:17 ` [bug#47824] [PATCH v2 1/3] gnu: guile-sdl2: Update to 0.6.0 Leo Prikler
2021-04-19 8:17 ` [bug#47824] [PATCH v2 2/3] gnu: guile-chickadee: Update to 0.7.0 Leo Prikler
2021-04-19 8:17 ` [bug#47824] [PATCH v2 3/3] gnu: tsukundere: Update to 0.3.0 Leo Prikler
2021-05-05 14:16 ` Ludovic Courtès [this message]
2021-05-05 15:00 ` [bug#47824] [PATCH 0/3] Happy hacking in the Spring 2021 LGJ Leo Prikler
2021-05-06 10:52 ` Ludovic Courtès
2021-05-06 11:03 ` Leo Prikler
2021-05-15 8:35 ` Leo Prikler
2021-05-15 13:45 ` Ludovic Courtès
2021-05-15 14:02 ` Leo Prikler
2021-05-15 18:32 ` [bug#47824] [PATCH] gnu: tsukundere: Update to 0.3.0 Leo Prikler
2021-05-16 20:21 ` Ludovic Courtès
2021-05-16 22:27 ` bug#47824: " Leo Prikler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874kfhjmfd.fsf_-_@gnu.org \
--to=ludo@gnu.org \
--cc=47824@debbugs.gnu.org \
--cc=efraim@flashner.co.il \
--cc=leo.prikler@student.tugraz.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).