unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Timotej Lazar <timotej.lazar@araneo.si>
To: Leo Prikler <leo.prikler@student.tugraz.at>, 49235@debbugs.gnu.org
Subject: [bug#49235] [PATCH] gnu: Add oneko.
Date: Sun, 27 Jun 2021 21:06:24 +0200	[thread overview]
Message-ID: <874kdjnn4f.fsf@araneo.si> (raw)
In-Reply-To: <40ae5fba85021344b4c6f372af08844ba5561d06.camel@student.tugraz.at>

Leo Prikler <leo.prikler@student.tugraz.at> [2021-06-27 20:24:04+0200]:
> Is man/$LANG/man the way this should be structured?

I followed the pattern for existing manpages in my profile. `man -L ja
oneko` also returns the correct page. On a related note, would it be a
good idea to change the encoding from ISO-2022-JP to utf-8? `iconv`
produces a file that at least looks correct.

> For the patch, I think that it deserves a better name + comment.  The
> copyright in those cases is not unclear – it is very clear who owns
> those bitmaps, and in at least one case it's further clear that the
> owner doesn't want others to reuse them.

I am not sure if the copyright actually covers *all* depictions of the
BSD daemon (and others), or just the (variatons of) the original image.
But I’ll reword the comment to say “nonfree” instead.

> The snippet should probably also remove the .include files, which at
> least seem referenced in the code.

Those includes are patched out. Just in case I’ll change the snippet to
remove whole directories instead of just the *xbm files.

Thanks,
Timotej




  reply	other threads:[~2021-06-27 19:07 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-26 19:20 [bug#49235] [PATCH] gnu: Add oneko Timotej Lazar
2021-06-27 12:45 ` Leo Prikler
2021-06-27 13:40   ` Timotej Lazar
2021-06-27 13:55     ` Leo Prikler
2021-06-27 17:51       ` Timotej Lazar
2021-06-27 18:24         ` Leo Prikler
2021-06-27 19:06           ` Timotej Lazar [this message]
2021-06-27 19:24             ` Leo Prikler
2021-06-27 19:45               ` Timotej Lazar
2021-06-27 19:50                 ` Leo Prikler
2021-06-27 17:49 ` [bug#49235] [PATCH v2] " Timotej Lazar
2021-06-28 17:02 ` [bug#49235] [PATCH v3] " Timotej Lazar
2021-06-28 19:05   ` bug#49235: " Leo Prikler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874kdjnn4f.fsf@araneo.si \
    --to=timotej.lazar@araneo.si \
    --cc=49235@debbugs.gnu.org \
    --cc=leo.prikler@student.tugraz.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).