[bug#50016] [PATCH] gnu: gnuradio: Don't include QtWebKit in the dependency graph.

[bug#50016] [PATCH] gnu: gnuradio: Don't include QtWebKit in the dependency graph.

[Leo Famulari]

This changes affects two leaf packages: gqrx and gr-satellites.

I tested that gqrx still works. I'm not sure how to use gr-satellites.

* gnu/packages/radio.scm (gnuradio)[inputs]: Replace python-pyqt with
python-pyqt-without-qtwebkit.
---
 gnu/packages/radio.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/radio.scm b/gnu/packages/radio.scm
index b0c5d960ed..4ca0bf65a7 100644
--- a/gnu/packages/radio.scm
+++ b/gnu/packages/radio.scm
@@ -531,7 +531,7 @@ used by RDS Spy, and audio files containing @dfn{multiplex} signals (MPX).")
        ("python-numpy" ,python-numpy)
        ("python-pycairo" ,python-pycairo)
        ("python-pygobject" ,python-pygobject)
-       ("python-pyqt" ,python-pyqt)
+       ("python-pyqt" ,python-pyqt-without-qtwebkit)
        ("python-pyyaml" ,python-pyyaml)
        ("qtbase" ,qtbase-5)
        ("qwt" ,qwt)
-- 
2.32.0

[bug#50016] [PATCH] gnu: gnuradio: Don't include QtWebKit in the dependency graph.

[Leo Famulari]

I am proposing this change because:

1) QtWebKit is hard to keep building:

<https://bugs.gnu.org/50014>

2) QtWebKit is not really "ready" to be used, being an alpha release
with a huge caveat from upstream:

"WARNING: This release is based on old WebKit revision with known
unpatched vulnerabilities. Please use it carefully and avoid visiting
untrusted websites and using it for transmission of sensitive data.
Please wait for new release from qtwebkit-dev branch to use it with
untrusted content."
https://github.com/qtwebkit/qtwebkit/releases/tag/qtwebkit-5.212.0-alpha4
https://seclists.org/oss-sec/2021/q3/66

3) It doesn't seem to be used by gnuradio, although I'm not 100% sure.
It's not mentioned in the gnuradio build log, anyways.

[bug#50016] [PATCH] gnu: gnuradio: Don't include QtWebKit in the dependency graph.

[Guillaume Le Vaillant]

[-- Attachment #1: Type: text/plain, Size: 1046 bytes --]

Leo Famulari <leo@famulari.name> skribis:

> I am proposing this change because:
>
> 1) QtWebKit is hard to keep building:
>
> <https://bugs.gnu.org/50014>
>
> 2) QtWebKit is not really "ready" to be used, being an alpha release
> with a huge caveat from upstream:
>
> "WARNING: This release is based on old WebKit revision with known
> unpatched vulnerabilities. Please use it carefully and avoid visiting
> untrusted websites and using it for transmission of sensitive data.
> Please wait for new release from qtwebkit-dev branch to use it with
> untrusted content."
> https://github.com/qtwebkit/qtwebkit/releases/tag/qtwebkit-5.212.0-alpha4
> https://seclists.org/oss-sec/2021/q3/66
>
> 3) It doesn't seem to be used by gnuradio, although I'm not 100% sure.
> It's not mentioned in the gnuradio build log, anyways.

gr-satellites has some functions using HTTP connections, but it's using
python-requests for that, not qtwebkit.
So it looks like nothing based on gnuradio actually depends on qtwebkit,
and your patch will not cause any issue.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

bug#50016: [PATCH] gnu: gnuradio: Don't include QtWebKit in the dependency graph.

[Leo Famulari]

On Thu, Aug 12, 2021 at 07:29:28AM +0000, Guillaume Le Vaillant wrote:
> gr-satellites has some functions using HTTP connections, but it's using
> python-requests for that, not qtwebkit.
> So it looks like nothing based on gnuradio actually depends on qtwebkit,
> and your patch will not cause any issue.

Thanks for the advice. I've gone ahead and pushed as
6ebba295038a84bdeb84adf7652c9a4409ca3d90