unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Andrew Tropin <andrew@trop.in>
To: Leo Famulari <leo@famulari.name>
Cc: 49486@debbugs.gnu.org
Subject: [bug#49486] [PATCH] gnu: msmtp: Make it configurable with envrinoment variables
Date: Tue, 14 Sep 2021 10:44:03 +0300	[thread overview]
Message-ID: <874kanmwjg.fsf@trop.in> (raw)
In-Reply-To: <YOxYJ4YgdambaV95@jasmine.lan>

[-- Attachment #1: Type: text/plain, Size: 1727 bytes --]

On 2021-07-12 10:56, Leo Famulari wrote:

> On Mon, Jul 12, 2021 at 06:33:11AM +0300, Andrew Tropin wrote:
>> Agree, --enqueue is a feature and probably doesn't belong to the PM
>> repo, the rest is more like a fix.  Ok, let's see, what Martin will
>> reply to proposed changes and I'll adjust this patch accordingly.
>
> Thanks, let us know what happens. I use msmtp so I'm interested :)

On 2021-08-26 08:59, Martin Lambers wrote:

> Hi, sorry for the late response.

> I am not sure about the changes. Changing behavior via environment
> variables is fragile and non-obvious to users. And there's a reason
> 'make install' does not put msmtpq in the user's $PATH: in its
> current state, the script is really only an example that needs to be
> customized.

> I would prefer a more complete solution, possibly including a
> configuration file.

> But interest in updating or maintaining the script has been very low in
> the last years, so I assume the user base is very small. This would mean
> that just keeping it as an example is ok.

It seems that this script is unmaintained and served as an example.
Martin also proposed to take the maintanance responsibility of it in the
other message, but I needed it only for testing and don't use it anymore
and thus don't want to take this duty.

However, the patches themselves still seems good to me and they can be
useful for other people.  So we can keep them downstream and provide a
little more flexible version of msmtpq script for guix users or close
this ticket and keep them only in that thread for the history)

The first one is a little more userfriendly IMO, the second one reduces
maintanance burden, which also is a good thing.

I'm ok with both options.  LMKWYT.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

      reply	other threads:[~2021-09-14  7:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-09 10:26 [bug#49486] [PATCH] gnu: msmtp: Make it configurable with envrinoment variables Andrew Tropin
2021-07-10 18:23 ` Leo Famulari
2021-07-12  3:33   ` Andrew Tropin
2021-07-12 14:56     ` Leo Famulari
2021-09-14  7:44       ` Andrew Tropin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874kanmwjg.fsf@trop.in \
    --to=andrew@trop.in \
    --cc=49486@debbugs.gnu.org \
    --cc=leo@famulari.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).