From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id IH8QN6moYWE2IQEAgWs5BA (envelope-from ) for ; Sat, 09 Oct 2021 16:35:21 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id +A3EMKmoYWFSdAAAbx9fmQ (envelope-from ) for ; Sat, 09 Oct 2021 14:35:21 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5D963658D for ; Sat, 9 Oct 2021 16:35:21 +0200 (CEST) Received: from localhost ([::1]:53212 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mZDRX-0001tw-Kb for larch@yhetil.org; Sat, 09 Oct 2021 10:35:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42506) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mZDRG-0001ta-Ho for guix-patches@gnu.org; Sat, 09 Oct 2021 10:35:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42381) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mZDRG-00088P-9j for guix-patches@gnu.org; Sat, 09 Oct 2021 10:35:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mZDRG-0007PB-11 for guix-patches@gnu.org; Sat, 09 Oct 2021 10:35:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50967] [PATCH 00/12] Move (gnu home-services XYZ) to (gnu services XYZ) Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 09 Oct 2021 14:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50967 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Oleg Pykhalov Cc: zimoun , Xinglu Chen , 50967@debbugs.gnu.org, Andrew Tropin Received: via spool by 50967-submit@debbugs.gnu.org id=B50967.163379008828441 (code B ref 50967); Sat, 09 Oct 2021 14:35:01 +0000 Received: (at 50967) by debbugs.gnu.org; 9 Oct 2021 14:34:48 +0000 Received: from localhost ([127.0.0.1]:53927 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mZDR1-0007Of-Mx for submit@debbugs.gnu.org; Sat, 09 Oct 2021 10:34:47 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40560) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mZDQw-0007OO-JN for 50967@debbugs.gnu.org; Sat, 09 Oct 2021 10:34:46 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:55868) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mZDQq-00087l-7f; Sat, 09 Oct 2021 10:34:36 -0400 Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:59226 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mZDQp-0002sQ-U0; Sat, 09 Oct 2021 10:34:36 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87h7dwq4cb.fsf_-_@gnu.org> <20211004231331.5269-1-go.wigust@gmail.com> <20211004231331.5269-3-go.wigust@gmail.com> <878rz54xmy.fsf@gmail.com> <87o87z2kge.fsf_-_@gnu.org> <87k0im74x5.fsf@gmail.com> Date: Sat, 09 Oct 2021 16:34:32 +0200 In-Reply-To: <87k0im74x5.fsf@gmail.com> (Oleg Pykhalov's message of "Sat, 09 Oct 2021 15:34:30 +0300") Message-ID: <874k9qxo5j.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1633790121; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=cq18Y+e4DbV+lxetZDp/yRZam++8nadKMWvTZ5HsStU=; b=uBG3z2voG2dmulK/SP/krRo/zw9I0cSsH4855rQltGh38X8fxK1OzYEfWCBPASvaM1W/7y TYoKSCmtYdXKhYXO9beRo7VyY38XRe++o0iqf46REQ9y7CDNvlLGxrERBBwhqXg3s0ztRQ xS83cLMUlmU+PPn+to7KSGKXafmVlvhCoLUpQC+4j/8Zhqc06CxhkfkGLpJdpyPYUIC12z kY1MAmNf88R6MwSyeUo+MoZQacvBHPkp7Enm52pSu8OjsOTqhEnQVHqAu93mKy9jPaxxS1 LHiMjc1SR5ntVO9vWsxf+YwC1cqfR0owABJd+/rLKUHhkCBKo2+ebHDqj3lb1g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1633790121; a=rsa-sha256; cv=none; b=I7PuZ9TYGInT0uBvimnDEYsF8dv02hgmNmGPmnjbPYlIZvlNjZH3RxpkIL8/d2naEiSeRd LsizhCKsbnWvzB1Ds+fKYDvYR80cH8ISIb89nJcMdP9tsyqUNvWMsrctbsSqrV6FMRvtNJ ukjH1M3inFwjTrRYnxukqqFC8bZzQURaM0k3b8mGj/upDFh0IYZywvyGGmhxHlnmhoqyA/ IuSGIJFjEN7TdSdRlObNjmhQNliX9M4tmQNV66R1H8ZDRx0TpzwT7hPPrsrySjMqtjhHqv zzpQjZg04NYl7PE/2Fii107In2fF1JlTewNtdqz8NK+DMZxjIHsCiG16yapJpw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.21 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 5D963658D X-Spam-Score: -2.21 X-Migadu-Scanner: scn1.migadu.com X-TUID: 6bDbR8PEPtg8 Oleg Pykhalov skribis: > Ludovic Court=C3=A8s writes: > >>> From eec2ab5f514ec6e156244898f8a635baf323ab70 Mon Sep 17 00:00:00 2001 >>> From: Oleg Pykhalov >>> Date: Tue, 5 Oct 2021 02:10:25 +0300 >>> Subject: [PATCH] scripts: home: Make sure profile directory exists. > > [=E2=80=A6] > >> Also, wouldn=E2=80=99t it be easier to set HOME to a new directory? >> >>> + guix home reconfigure "${test_directory}/home.scm" > > We probably should clean temporary $HOME directory with 'rm -rf' or > delete each file with 'rm' and then invoke 'rmdir' inside a Bash's > 'trap'. I fill worry about removing operations on $HOME directories. Like you wrote, the trap should =E2=80=9Crm -rf $test_directory=E2=80=9D ra= ther than =E2=80=9Crm -rf $HOME=E2=80=9D. It=E2=80=99s safer. :-) > Also returned Andrew's 'guix home search' tests. > > And 'home-bash-service-type' is replaced with 'simple-service' to not to > block the guix-home.sh test from merging in master until completion of > discussion about file-like objects. OK. > From 4b29f7f1592f4256c7cd628624d2225e2d427a9d Mon Sep 17 00:00:00 2001 > From: Oleg Pykhalov > Date: Sat, 9 Oct 2021 14:52:10 +0300 > Subject: [PATCH 1/2] scripts: home: Make sure profile directory exists. > > * guix/scripts/home.scm (process-action): Make sure profile directory exi= sts. LGTM. > From 5cc0b064af3f4a6238722fbb451a98b499c8d6d2 Mon Sep 17 00:00:00 2001 > From: Oleg Pykhalov > Date: Sat, 9 Oct 2021 14:52:13 +0300 > Subject: [PATCH 2/2] tests: Add guix-home.sh. > > * tests/guix-home.sh: New file. > * Makefile.am (SH_TESTS): Add this. LGTM, thanks! Ludo=E2=80=99.