From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id EJUcG/drlGJjAAAAbAwnHQ (envelope-from ) for ; Mon, 30 May 2022 09:02:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 6LIsGvdrlGKF+gAAG6o9tA (envelope-from ) for ; Mon, 30 May 2022 09:02:15 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id ECEF242D4E for ; Mon, 30 May 2022 09:02:14 +0200 (CEST) Received: from localhost ([::1]:52828 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nvZPq-0005Vx-1n for larch@yhetil.org; Mon, 30 May 2022 03:02:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53558) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nvZPe-0005Ut-MZ for guix-patches@gnu.org; Mon, 30 May 2022 03:02:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:48677) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nvZPe-0003YD-CL for guix-patches@gnu.org; Mon, 30 May 2022 03:02:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nvZPe-0006nx-8P for guix-patches@gnu.org; Mon, 30 May 2022 03:02:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55663] [PATCH] Image API: add FAT32 support Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 30 May 2022 07:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55663 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Pavel Shlyak Cc: 55663@debbugs.gnu.org Received: via spool by 55663-submit@debbugs.gnu.org id=B55663.165389408926107 (code B ref 55663); Mon, 30 May 2022 07:02:02 +0000 Received: (at 55663) by debbugs.gnu.org; 30 May 2022 07:01:29 +0000 Received: from localhost ([127.0.0.1]:42574 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nvZP7-0006n1-19 for submit@debbugs.gnu.org; Mon, 30 May 2022 03:01:29 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60092) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nvZP5-0006mo-9w for 55663@debbugs.gnu.org; Mon, 30 May 2022 03:01:27 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60526) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nvZOz-0003Ue-DA; Mon, 30 May 2022 03:01:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=McSCd3+vewy+ui27i2vnMU7KOy8mFWuO0P+xn9YOWX8=; b=HX5wIjM08pLzf58HHt/l VxKrZNoJ3EftiHxHA198FfFmqeCgO5jNxQu7zcm8OqAN4eNv9nJTSrVclkH+wAXXRkwJ0Y1dFW/PU fmUGQ8zx2C1QC7AY3JokMGSAN+OxExsdLVH3ki3bEbK2emzUw9FJZPGJf7RLjuHCUOrdj7CDfIUZS GjyFIUAe8FJGOaaCk5sRDVnksRHUH3e017KVRC0kS8zEoRRVid/yILJ0jFrEFdS7uX3UqY1V1MXm+ vRusHJ93KjkErSYSH4bj9YGCDVQK6qvCuZQ1Jk0LSPQQQeTX4Nqx8ZldpOPiMR6ilsuXcFty07FUb dX4rglbBlZtrJw==; Received: from 2a02-8429-81d2-3d01-94c9-8097-ea5c-2775.rev.sfr.net ([2a02:8429:81d2:3d01:94c9:8097:ea5c:2775]:49110 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nvZOz-0005lg-04; Mon, 30 May 2022 03:01:21 -0400 From: Mathieu Othacehe References: <3EE7299C-64ED-4062-BA31-ADF3A6AD6A37@pantherx.org> <4054081F-9D51-49E0-958F-C9B1BFA7FB24@pantherx.org> Date: Mon, 30 May 2022 09:01:18 +0200 In-Reply-To: <4054081F-9D51-49E0-958F-C9B1BFA7FB24@pantherx.org> (Pavel Shlyak's message of "Sun, 29 May 2022 17:35:50 +0300") Message-ID: <874k17ld1d.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1653894135; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=McSCd3+vewy+ui27i2vnMU7KOy8mFWuO0P+xn9YOWX8=; b=Xcv7aPIYX8TH1FWimY+qHhOqm6kQvj8tAJfxiJ2yeakYkko7wiUxL0IVtp5apjUgJb6PCk wFIlJJxYOXXqsnaEHihlUFCBoaRH46E6cxX4XdED5dvaaltUQZJiBgRYufgNRv7xZREry/ N9rPP9Yn1npjD/aK60WdYgPmpALZ64OlNYrI8pjlZP6/KbCBMla8WfJ5vnkp7pzvoYJ+Wq uPgrV8ZdN1hNKh4p/VULeGfUfGczhx9u3K1yrRNczsoGLoaFRkA3dLOkZnQFDcUiSd0JC9 d5uLuFohsxoS5R7yBfVu4tZ0wZ/5nVnYKQ4gNvmACdtwaL7TKquBilUCUx3+VA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1653894135; a=rsa-sha256; cv=none; b=MZ5oXGebnBIJL0j9H0umm4iwFfOyo/jA4Ln8hlqLBZG+oUVo78EjoMrxvMGZoPuGEfBunr Ecj1E48Qq3S6VtWUw6mhEbHV/fLxFOSpgiK/7XVDZJQyy/SOdZuxGYRwMqUGoyb4g01S+D 9aCMTPZpdfeuYFvGPY0eCuFO5V9e11VGcwIhwChOzn6HstEsDIvo3qlIAdsslOGEtLGV8b xL+QZXo8ehaq6J1dBcjkU2qQ+lasDN1qG2ukJNhpVroURwtNOAehFH0LYSaQPFRLkqDQd2 drPBCSWtlbCgeZLkZEVzHHw8iJcG6zF583FRsDHoqpx7z86cF+749CjneaSBbg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=HX5wIjM0; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -5.33 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=HX5wIjM0; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: ECEF242D4E X-Spam-Score: -5.33 X-Migadu-Scanner: scn0.migadu.com X-TUID: vAif+ubeewxo Hello Pavel, > gnu/build/image.scm | 24 ++++++++++++++---------- > gnu/system/image.scm | 9 +++++++-- Please write a commit message following the guidelines available here: https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html > +(define* (make-vfat-image partition target root fs_bits) s/fs_bits/fs-bits/ > + ((or (string=? file-system "vfat") (string=? file-system "fat16")) "0x0E") This line is longer than 78 characters you can break it between the two strings comparisons. > + ( > + (or (string=? file-system "vfat") Merge those two lines. > + (string=? file-system "fat32") > + ) "F") Ditto. Can you please send a v2? Thanks for your contribution, Mathieu