unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Mathieu Othacehe <othacehe@gnu.org>
To: Pavel Shlyak <p.shlyak@pantherx.org>
Cc: 55663@debbugs.gnu.org
Subject: [bug#55663] [PATCH] Image API: add FAT32 support
Date: Mon, 30 May 2022 09:01:18 +0200	[thread overview]
Message-ID: <874k17ld1d.fsf_-_@gnu.org> (raw)
In-Reply-To: <4054081F-9D51-49E0-958F-C9B1BFA7FB24@pantherx.org> (Pavel Shlyak's message of "Sun, 29 May 2022 17:35:50 +0300")


Hello Pavel,

>  gnu/build/image.scm  | 24 ++++++++++++++----------
>  gnu/system/image.scm |  9 +++++++--

Please write a commit message following the guidelines available here:
https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html

> +(define* (make-vfat-image partition target root fs_bits)

s/fs_bits/fs-bits/

> +         ((or (string=? file-system "vfat") (string=? file-system "fat16")) "0x0E")

This line is longer than 78 characters you can break it between the two
strings comparisons.

> +         (
> +          (or (string=? file-system "vfat")

Merge those two lines.

> +              (string=? file-system "fat32")
> +              ) "F")

Ditto.

Can you please send a v2?

Thanks for your contribution,

Mathieu




  reply	other threads:[~2022-05-30  7:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-26 18:02 [bug#55663] [PATCH] Image API: add FAT32 support Pavel Shlyak
2022-05-26 18:07 ` Tobias Geerinckx-Rice via Guix-patches via
2022-05-26 20:54   ` Pavel Shlyak
2022-05-29 11:46     ` Pavel Shlyak
2022-05-29 14:35 ` Pavel Shlyak
2022-05-30  7:01   ` Mathieu Othacehe [this message]
2022-05-30  9:01     ` Pavel Shlyak
2022-05-31 13:07       ` bug#55663: " Mathieu Othacehe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874k17ld1d.fsf_-_@gnu.org \
    --to=othacehe@gnu.org \
    --cc=55663@debbugs.gnu.org \
    --cc=p.shlyak@pantherx.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).