From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id ePOfNeEt22KRowAAbAwnHQ (envelope-from ) for ; Sat, 23 Jul 2022 01:08:18 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id uDChNOEt22L6KwEAG6o9tA (envelope-from ) for ; Sat, 23 Jul 2022 01:08:17 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A39902514D for ; Sat, 23 Jul 2022 01:08:17 +0200 (CEST) Received: from localhost ([::1]:38838 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oF1km-0001eF-GD for larch@yhetil.org; Fri, 22 Jul 2022 19:08:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55758) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oF1kY-0001ax-K2 for guix-patches@gnu.org; Fri, 22 Jul 2022 19:08:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:52959) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oF1kY-0002W5-B2 for guix-patches@gnu.org; Fri, 22 Jul 2022 19:08:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oF1kY-0005Hq-3s for guix-patches@gnu.org; Fri, 22 Jul 2022 19:08:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#51427] [PATCH] nix: libstore: Do not remove unused links when deleting specific items. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 22 Jul 2022 23:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51427 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 51427@debbugs.gnu.org, Tobias Geerinckx-Rice , Liliana Marie Prikler , maxim.cournoyer@gmail.com, zimon.toutoune@gmail.com Received: via spool by 51427-submit@debbugs.gnu.org id=B51427.165853124320269 (code B ref 51427); Fri, 22 Jul 2022 23:08:02 +0000 Received: (at 51427) by debbugs.gnu.org; 22 Jul 2022 23:07:23 +0000 Received: from localhost ([127.0.0.1]:42708 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oF1jv-0005Gq-9T for submit@debbugs.gnu.org; Fri, 22 Jul 2022 19:07:23 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42768) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oF1jr-0005Gd-W6 for 51427@debbugs.gnu.org; Fri, 22 Jul 2022 19:07:22 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54878) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oF1jl-0002MY-3K; Fri, 22 Jul 2022 19:07:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=cAE+f0Ta7GtB99ohwfiqcNLupYAgryi3fdHTd7hPma0=; b=gCfGskav3I5rm2OXRltd aoVcwiLFt7ks2gMSRNHZvh9J5eOHJi7B3Lq7wj3wUTEw0/NKgfyCj1f4/EqCP6CXqp+C0LdEFmrWn TEh4dUPU+1Wz4beCYNMNSfc9+6vrgG6FoUwoIGXd+j/aecwa501WcyNnxK3kjyJaS5/V8I0TLQU2R Nl12TXcwJKMO1+C1O1HOWg33R7nhArH2Y3GEpYxie+HItkFJxuDr/xEGxS24F4E0qFrIQxZprvrUU 88FwkUhU1pJCfoGjI0l9Vx9IFhT0vbOAQTIhAxzsfvRoVSOBC8GzKvAgVOFos2h11ATzCjFxhelZd RcXBjvaihaLcFQ==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:53610 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oF1jk-0005Xs-NA; Fri, 22 Jul 2022 19:07:12 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20211027034918.4591-1-maxim.cournoyer@gmail.com> <87o8795j61.fsf@gnu.org> <5c2dd60acfaa7d74b7554babb3e223bc855bac8a.camel@gmail.com> <87h7cxp9tl.fsf@gnu.org> <87sfwg7w9z.fsf@gmail.com> <87ee7tmdbd.fsf@gnu.org> <86k0hhnqss.fsf@gmail.com> <871r3f2j7y.fsf@gnu.org> <867dd7roi2.fsf@gmail.com> <87o7xmy14l.fsf_-_@gnu.org> <2441c768fea8faee800947a17aef896c35173845.camel@gmail.com> <87sfmxv6ue.fsf@gnu.org> <8538dc9925eb499ea2b728e349d98296eedeb14d.camel@gmail.com> <877d48lx41@nckx> <877d46n7n5.fsf_-_@gnu.org> <12c768df412e23b4d69e87631cd805f741c38ce3.camel@gmail.com> <87ilnpibu1.fsf@gnu.org> <4b81f06f-3e89-5a33-ae30-1710e447f849@telenet.be> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Quintidi 5 Thermidor an 230 de la =?UTF-8?Q?R=C3=A9volution, ?= jour du =?UTF-8?Q?B=C3=A9lier?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sat, 23 Jul 2022 01:07:10 +0200 In-Reply-To: <4b81f06f-3e89-5a33-ae30-1710e447f849@telenet.be> (Maxime Devos's message of "Fri, 22 Jul 2022 15:39:12 +0200") Message-ID: <874jz8eogx.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1658531297; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=cAE+f0Ta7GtB99ohwfiqcNLupYAgryi3fdHTd7hPma0=; b=TuA4tuzt+PhaRs0dECIIzwKDHCnwLHk3AekSk+BgsTvBXI2DURxq/M2DeIkv9c+wzY6Vxg BPqul+If74/0WwSKlET9FJXO2iUi3mIUWh2Nbii+oupbentCREjKjlCFNOAiKZusZx1/jD Ei1rSdf5LbX/izIPxi3uoEXMiL+8s04iHKcLRTekhEsfFhrt9VppSSaT/rBgHE77Z5YaaQ IEo41jqSHNko++DtfXvwXPmQLIHlU+x7eB3QX9kGJTh/FG21Mbap/BXynfz2gOOlL0bXUe TO/KGhX3khLLOxZtRECw/cQoNhWezka0+OmDZksSnFx+lRryA4yn0uAPks2tgA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1658531297; a=rsa-sha256; cv=none; b=IVsnr1Mc5BAa5Yhs7fYDR2Mc6RgQkd++PQ16gJwOJMBBVLxPl+NjTc0jmHXu3Xuiud0qIb H7OsDJUN6rJmw4Fjjz8kofNxbcNaKPcsBtlau4pY4/rJszTEPTRL+ToSWpUDH+EuJeMqQN tgbfI5JBLf03FxZ2e7qXRbMqcJffpH4pchiXPJBi1Mi0FmRpXy9N9AgIulr6i714J/pYqG YH1795NGN09i+t85alsHk6aQ8k4OedRFIAJhk37SzXl7fCqgjeE7IkPRQmPLqm2tT3bFV0 cxtaJQIPnznTLl89YxhJC4c2TYXKVyFFGWT1h5Nod8QxflCowOtj7QS2bkrW9g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=gCfGskav; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.23 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=gCfGskav; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: A39902514D X-Spam-Score: -2.23 X-Migadu-Scanner: scn0.migadu.com X-TUID: ZcqJFPaHYjX3 Hi, Maxime Devos skribis: > On 22-07-2022 14:14, Ludovic Court=C3=A8s wrote: >> Hi, >> >> Liliana Marie Prikler skribis: >> >>> I don't think deleting links will ever be fast on that disk. But what >>> I've been saying the whole time is that I don't always need the links >>> deleted. I think adding "expert" switches to skip these phases might >>> actually be enough =E2=80=93 after all, if I ever do want to run a full= GC, the >>> information ought to be the same, no? >> The expert will have to know that skipping that phase will have the >> effect of *not* freeing space on the device, so=E2=80=A6 > > I believe the word "expert" implies that the expert knows that, Apologies for being elliptic. My point here, as has been discussed earlier in this thread, is that we can=E2=80=99t just skip that phase or we= =E2=80=99d simply leave files around without actually deleting them. Thus, a command-line switch to skip the phase doesn=E2=80=99t seem valuable= to me because it=E2=80=99d let users run the GC in a way that doesn=E2=80=99t = actually collect garbage. I hope this is clearer! Thanks, Ludo=E2=80=99.