unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Mathieu Othacehe <othacehe@gnu.org>
To: "Artyom V. Poptsov" <poptsov.artyom@gmail.com>
Cc: 57365@debbugs.gnu.org
Subject: [bug#57365] [PATCH] gnu: guile-smc: Update to 0.5.0
Date: Fri, 26 Aug 2022 15:34:36 +0200	[thread overview]
Message-ID: <874jxzyvpv.fsf@gnu.org> (raw)
In-Reply-To: <87pmgqsss3.fsf@gmail.com> (Artyom V. Poptsov's message of "Tue,  23 Aug 2022 21:45:32 +0300")


Hey Artyom,

> -              (string-append
> -               "(add-handler! %logger\n"
> -               "              (make <rotating-log>\n"
> -               "                    #:file-name \"smc.log\"))\n")))
> -             #t))
> +               (("\\(add-handler! %logger %syslog\\)")
> +                (string-append
> +                 "(add-handler! %logger\n"
> +                 "              (make <port-log/us>\n"
> +                 "                    #:port (open-file \"/tmp/smc.log\" \"a+\")))\n")))))

What is this patch about? Can't it be upstreamed?

> +     (list autoconf automake pkg-config texinfo help2man))

You need to describe it in the commit message:

[native-inputs]: Add help2man.

> +     (list bash-minimal
> +           guile-3.0
> +           guile-lib
> +           inetutils))

Ditto:

[inputs]: Use the new inputs style.

Can you send an updated patch?

Thanks,

Mathieu




  reply	other threads:[~2022-08-26 13:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-23 18:45 [bug#57365] [PATCH] gnu: guile-smc: Update to 0.5.0 Artyom V. Poptsov
2022-08-26 13:34 ` Mathieu Othacehe [this message]
2022-08-27  3:15   ` Artyom V. Poptsov
2022-08-27  7:54   ` Maxime Devos
2022-09-02  6:20   ` Artyom V. Poptsov
2022-09-02  7:38     ` bug#57365: " Mathieu Othacehe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874jxzyvpv.fsf@gnu.org \
    --to=othacehe@gnu.org \
    --cc=57365@debbugs.gnu.org \
    --cc=poptsov.artyom@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).