unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Liliana Marie Prikler <liliana.prikler@gmail.com>
Cc: Mathieu Othacehe <othacehe@gnu.org>,
	Nicolas Graves <ngraves@ngraves.fr>,
	57092@debbugs.gnu.org
Subject: [bug#57092] repairing tox
Date: Thu, 01 Sep 2022 10:54:05 +0200	[thread overview]
Message-ID: <874jxr5vbm.fsf@gnu.org> (raw)
In-Reply-To: <7cb6d5c02a07a2319bcebf5e47f9cc40186aeae0.camel@gmail.com> (Liliana Marie Prikler's message of "Thu, 01 Sep 2022 08:08:23 +0200")

Hi,

Liliana Marie Prikler <liliana.prikler@gmail.com> skribis:

> The ChangeLog of the first patch needs to be rewritten to:
>
> * gnu/packages/python-xyz.scm (python-tox): Move from here...
> * gnu/packages/python-check.scm (python-tox): ... to here.
>
> Other than that, if python-tox builds after applying the second patch,
> I'd say it's good to go.

OK.  Could you apply it and adjust the commit log accordingly then?

I think we shouldn’t block contributions for small commit log edits.

Thanks,
Ludo’.




  reply	other threads:[~2022-09-01  9:43 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-09 21:27 [bug#57092] repairing tox Nicolas Graves via Guix-patches via
2022-08-09 22:07 ` [bug#57092] [PATCH 1/2] gnu: python-tox: Move from python-xyz.scm to python-check.scm Nicolas Graves via Guix-patches via
2022-08-09 22:07   ` [bug#57092] [PATCH 2/2] gnu: python-tox: Add native-inputs and enable tests Nicolas Graves via Guix-patches via
2022-08-10  8:47     ` Liliana Marie Prikler
2022-08-10  8:45   ` [bug#57092] [PATCH 1/2] gnu: python-tox: Move from python-xyz.scm to python-check.scm Liliana Marie Prikler
2022-08-11  5:48 ` [bug#57092] [PATCH v2 " Nicolas Graves via Guix-patches via
2022-08-11  5:48   ` [bug#57092] [PATCH v2 2/2] gnu: python-tox: Add native-inputs and enable tests Nicolas Graves via Guix-patches via
2022-08-15  9:16     ` [bug#57092] repairing tox Mathieu Othacehe
2022-08-20 22:33 ` [bug#57092] [PATCH v3 1/2] gnu: python-tox: Move from python-xyz.scm to python-check.scm Nicolas Graves via Guix-patches via
2022-08-20 22:33   ` [bug#57092] [PATCH v3 2/2] gnu: python-tox: Add native-inputs and enable tests Nicolas Graves via Guix-patches via
2022-08-20 22:45     ` Nicolas Graves via Guix-patches via
2022-08-31 21:27       ` [bug#57092] repairing tox Ludovic Courtès
2022-09-01  6:08         ` Liliana Marie Prikler
2022-09-01  8:54           ` Ludovic Courtès [this message]
2022-09-01 11:51             ` bug#57092: " Liliana Marie Prikler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874jxr5vbm.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=57092@debbugs.gnu.org \
    --cc=liliana.prikler@gmail.com \
    --cc=ngraves@ngraves.fr \
    --cc=othacehe@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).