From: "Ludovic Courtès" <ludo@gnu.org>
To: 58231@debbugs.gnu.org
Subject: [bug#58231] [PATCH 0/2] Checking the 'license' field of packages
Date: Mon, 10 Oct 2022 09:51:32 +0200 [thread overview]
Message-ID: <874jwc5d6j.fsf@gnu.org> (raw)
In-Reply-To: <20221001161911.8116-1-ludo@gnu.org> ("Ludovic Courtès"'s message of "Sat, 1 Oct 2022 18:19:11 +0200")
Ludovic Courtès <ludo@gnu.org> skribis:
> The funny part of this patch is that the license validation expands
> to #t in the majority of cases, meaning that it comes without
> run-time overhead (there is macro-expansion overhead, but I didn’t
> measure it).
A quick measurement of the time taken by the “Computing Guix derivation”
step¹ (most of which is macro expansion) suggests it’s going from ~1m34s
to ~1m44s on my laptop—so roughly a 10% slowdown on this stage.
I guess that’s the price to pay.
That phase has always been very slow though, mostly due to psyntax, and
we need to do something about it anyway.
Ludo’.
¹ I ran ‘time guix time-machine --branch=wip-license-checks --url=$PWD’
and similar for the commit before those changes.
prev parent reply other threads:[~2022-10-10 7:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-01 16:19 [bug#58231] [PATCH 0/2] Checking the 'license' field of packages Ludovic Courtès
2022-10-01 16:20 ` [bug#58231] [PATCH 1/2] licenses: Let 'license?' expand to #t in trivial cases Ludovic Courtès
2022-10-01 16:20 ` [bug#58231] [PATCH 2/2] packages: Raise an exception for invalid 'license' values Ludovic Courtès
2022-10-10 10:22 ` zimoun
2022-10-10 14:52 ` Ludovic Courtès
2022-10-15 22:12 ` Philip McGrath
2022-10-08 11:44 ` [bug#58231] [PATCH 0/2] Checking the 'license' field of packages pelzflorian (Florian Pelz)
2022-10-10 7:36 ` Ludovic Courtès
2022-10-10 7:51 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jwc5d6j.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=58231@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).