* [bug#61145] [PATCH] Added libcap to the native inputs of mako.
@ 2023-01-29 11:15 Samuel Fadel
2023-01-31 1:18 ` [bug#61191] [PATCH] gnu: Fix missing libcap dependency for mako Csepp
2023-01-31 18:06 ` [bug#61145] make & libcap itd
0 siblings, 2 replies; 5+ messages in thread
From: Samuel Fadel @ 2023-01-29 11:15 UTC (permalink / raw)
To: 61145; +Cc: Samuel Fadel
Hi Guix,
I have prepared this patch to fix the build of mako 1.7.1. Here is the failed build log:
http://ci.guix.gnu.org/build/370206/details
I'm not sure if this is the correct way to address this issue, but in my local tests it fixes the build.
Samuel
***
This allows pkg-config to detect libcap during the build of mako. This is used
by meson to generate cargs for basu (a dependency of mako), which in turn
needs libcap.
* gnu/packages/wm.scm (mako)[native-inputs]: Added libcap
---
gnu/packages/wm.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index 2fd70af07f..f17bc0af3f 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -1858,7 +1858,7 @@ (define-public mako
(search-input-file inputs "bin/jq")
" "))))))))
(inputs (list basu cairo gdk-pixbuf jq pango wayland))
- (native-inputs (list pkg-config scdoc wayland-protocols))
+ (native-inputs (list libcap pkg-config scdoc wayland-protocols))
(home-page "https://wayland.emersion.fr/mako")
(synopsis "Lightweight Wayland notification daemon")
(description "Mako is a lightweight notification daemon for Wayland
--
2.39.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [bug#61191] [PATCH] gnu: Fix missing libcap dependency for mako.
@ 2023-01-31 1:18 ` Csepp
2023-02-09 14:29 ` bug#61191: Mako build fixed Jelle Licht
0 siblings, 1 reply; 5+ messages in thread
From: Csepp @ 2023-01-31 1:18 UTC (permalink / raw)
To: 61191; +Cc: Csepp
* gnu/packages/wm.scm (mako)[inputs]: Add libcap.
---
Should solve upgrade headaches for Sway users like myself.
gnu/packages/wm.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index 2fd70af07f..2b552e5359 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -1857,7 +1857,7 @@ (define-public mako
(string-append
(search-input-file inputs "bin/jq")
" "))))))))
- (inputs (list basu cairo gdk-pixbuf jq pango wayland))
+ (inputs (list basu cairo gdk-pixbuf jq libcap pango wayland))
(native-inputs (list pkg-config scdoc wayland-protocols))
(home-page "https://wayland.emersion.fr/mako")
(synopsis "Lightweight Wayland notification daemon")
--
2.39.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [bug#61145] make & libcap
2023-01-29 11:15 [bug#61145] [PATCH] Added libcap to the native inputs of mako Samuel Fadel
2023-01-31 1:18 ` [bug#61191] [PATCH] gnu: Fix missing libcap dependency for mako Csepp
@ 2023-01-31 18:06 ` itd
2023-02-01 17:15 ` Josselin Poiret via Guix-patches via
1 sibling, 1 reply; 5+ messages in thread
From: itd @ 2023-01-31 18:06 UTC (permalink / raw)
To: 61191, 61145
Hi,
these two patches (61145, 61191) seem to address the same issue. (But
I'm not sure libcap should be in input or in native-inputs. Both
versions build here.)
Best regards
itd
^ permalink raw reply [flat|nested] 5+ messages in thread
* [bug#61145] make & libcap
2023-01-31 18:06 ` [bug#61145] make & libcap itd
@ 2023-02-01 17:15 ` Josselin Poiret via Guix-patches via
0 siblings, 0 replies; 5+ messages in thread
From: Josselin Poiret via Guix-patches via @ 2023-02-01 17:15 UTC (permalink / raw)
To: itd, 61191, 61145
Hi,
itd@net.in.tum.de writes:
> Hi,
>
> these two patches (61145, 61191) seem to address the same issue. (But
> I'm not sure libcap should be in input or in native-inputs. Both
> versions build here.)
Just to add one more patch to the list, I just sent [1] which should be
the "proper fix", propagating libcap from basu itself.
[1] https://issues.guix.gnu.org/61213
(29854884695de3d32b2fb8899e49282aaec74c9e.1675270507.git.dev@jpoiret.xyz)
Best,
--
Josselin Poiret
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#61191: Mako build fixed
2023-01-31 1:18 ` [bug#61191] [PATCH] gnu: Fix missing libcap dependency for mako Csepp
@ 2023-02-09 14:29 ` Jelle Licht
0 siblings, 0 replies; 5+ messages in thread
From: Jelle Licht @ 2023-02-09 14:29 UTC (permalink / raw)
To: 61191-close, 61145-close, 61262-close
I went ahead and pushed the solution posted with issue #61213 to master,
but thanks everyone and anyone who {reported,fixed} this issue!
- Jelle
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-02-09 14:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-29 11:15 [bug#61145] [PATCH] Added libcap to the native inputs of mako Samuel Fadel
2023-01-31 1:18 ` [bug#61191] [PATCH] gnu: Fix missing libcap dependency for mako Csepp
2023-02-09 14:29 ` bug#61191: Mako build fixed Jelle Licht
2023-01-31 18:06 ` [bug#61145] make & libcap itd
2023-02-01 17:15 ` Josselin Poiret via Guix-patches via
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).