From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id qN1uBh5L7mPaDgAAbAwnHQ (envelope-from ) for ; Thu, 16 Feb 2023 16:26:22 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 2NBaBh5L7mP3IQEA9RJhRA (envelope-from ) for ; Thu, 16 Feb 2023 16:26:22 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D579414C5B for ; Thu, 16 Feb 2023 16:26:21 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pSg95-0005nF-DV; Thu, 16 Feb 2023 10:26:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSg94-0005m2-My for guix-patches@gnu.org; Thu, 16 Feb 2023 10:26:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pSg94-0005Oq-DZ for guix-patches@gnu.org; Thu, 16 Feb 2023 10:26:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pSg94-000731-8L for guix-patches@gnu.org; Thu, 16 Feb 2023 10:26:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#61255] [PATCH 0/5] Add support for the RPM format to "guix pack" Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 16 Feb 2023 15:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61255 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Josselin Poiret , Christopher Baines , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , Ricardo Wurmus , 61255@debbugs.gnu.org Received: via spool by 61255-submit@debbugs.gnu.org id=B61255.167656114127050 (code B ref 61255); Thu, 16 Feb 2023 15:26:02 +0000 Received: (at 61255) by debbugs.gnu.org; 16 Feb 2023 15:25:41 +0000 Received: from localhost ([127.0.0.1]:37339 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSg8j-00072E-Ju for submit@debbugs.gnu.org; Thu, 16 Feb 2023 10:25:41 -0500 Received: from mail-qt1-f179.google.com ([209.85.160.179]:38751) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSg8g-000720-TZ for 61255@debbugs.gnu.org; Thu, 16 Feb 2023 10:25:40 -0500 Received: by mail-qt1-f179.google.com with SMTP id c2so2489359qtw.5 for <61255@debbugs.gnu.org>; Thu, 16 Feb 2023 07:25:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=hxO/pwV/DzJRBWF1qxgEollbC/Tgee4gOlu6LgsGPHw=; b=MzNid+HhAZNe0K2Szk5jkNfaLXg779fHraWumvMgRKhT1q85fM7PN1Q+lkqP3knnk0 asqIx4rAmRf9wHmJwEoDrI+xE/VI6J9kmT9woq2/ujhk37gZKGyLuiXpQRF/9Il48LqD DmD0GDlqwEDCXGD1TIe7/f8kjX+pWt71SWiAOnjAFBjDvC4OEWEm7g1eWBaqAlS+I5qf EiI9blHPI/FholhA+gE4NuablP8crwXh4yJ4foxxt5+807Rs+hlMqJjIcgb6Ju625ZhW 5Kqeai7hOGg9C3zhOlIeRubUas5IS+JJ/qWc1k+y2qb4Uj204e8DEXe71OlfNMqHfqBU QWyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=hxO/pwV/DzJRBWF1qxgEollbC/Tgee4gOlu6LgsGPHw=; b=rV8O83Q+GsdAAZVfK9Eqq3YD6ekheqsyDavdavXPZZ4z30cQqOkr/OxFAmURTwa7d9 lMU6QYNtQC5iJYaPmNs6/nJ2I2e9Qe2+g/o7Uei/buj/pLIml2NsiQ6Ko/5/KoTnDX2P rv1FHm42MN0rktg8lQ9814NHloy/WsOMkXExuXp5ql+jG0wCQzbFrbe45h05+XhQaUUH c7cD/SFURa0oRR5SHnHREFaDiWfvgJ3s3DdlPUFU3xL0hAUv47afMYxHwBI4uLCeGYlK KKLSamcsO5bGfBcsQjDdlkZiBF3QE+5JTBfuheORY53wQaP1fDC6c/hkRHbkV/Bm06iY w6XA== X-Gm-Message-State: AO0yUKWZlTd0r10wE5aKz1LWFRbd9r5+m1o3Ns0hiTq1YDj5wt2YK20u 1v6dfxSFdcEbdeEum1+cUUA= X-Google-Smtp-Source: AK7set8zMx9T0+VT2PiBtxa7Cm091Vg71Pu0iE7ikegGxrH0fl7BJd4SQji1a43KXxqWxajJDnGaxg== X-Received: by 2002:a05:622a:2c7:b0:3bb:7702:97f5 with SMTP id a7-20020a05622a02c700b003bb770297f5mr11014071qtx.15.1676561133353; Thu, 16 Feb 2023 07:25:33 -0800 (PST) Received: from hurd (dsl-152-188.b2b2c.ca. [66.158.152.188]) by smtp.gmail.com with ESMTPSA id 127-20020a370485000000b0073b732803c4sm1431700qke.5.2023.02.16.07.25.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Feb 2023 07:25:33 -0800 (PST) From: Maxim Cournoyer References: <20230203161926.26886-1-maxim.cournoyer@gmail.com> <20230203221409.15886-2-maxim.cournoyer@gmail.com> <877cwmk8yb.fsf_-_@gnu.org> Date: Thu, 16 Feb 2023 10:25:31 -0500 In-Reply-To: <877cwmk8yb.fsf_-_@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Sun, 12 Feb 2023 19:57:48 +0100") Message-ID: <874jrlws2c.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1676561181; a=rsa-sha256; cv=none; b=NQZzSRcjwH6B/nq+4Y5snhCgFoCwwWen2zHVoi1UhirwcRxl4iBpWqLUwTzJu4hrCV7NG0 uWzMS4A82ORdcxz1/klymDr2IDiLmx6W4vPT52gaGsMDkbOV94fJ+3QVKuvE+oJ5ERxYm/ YRnT85VPy+JNGMNgHJ6CEhaNb/E/hvwJp9VCRFioT2H7burbR9h+BtY0SvtkN+m/9AxRiB Pt4clFveX2zv8Cq+66HjEoJqRU/O7WrVpf1ytz2n3y7IL1oB9EHbKMd+Erc6wGi5PlHxGy 3VS1UXANpa/8fBP6Z9dPNeg46rNjOIzCVxz5EqQNzbeneLX0Xx0PNK965J1DcQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=MzNid+Hh; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1676561181; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=hxO/pwV/DzJRBWF1qxgEollbC/Tgee4gOlu6LgsGPHw=; b=hqFZAFNkUkbAmSJXosOrEyKQDtboatk9IgmE70Q/5hVdqkzbSbWpo/LfHqbAXu0H2gW4Nb uFCL2WLibaXPeUn2sdiWbIHSbgPtv4TBKHyEMOYmkS9tuic5F2ILIWiB87CdYXksaO/aJf Yt0uAQOEjm1+8C6tRqx2m6Jz7L1xUvq/JM8G26hcHov6YJz2dRN85NMeGCW0Jds62799in zj3bclpN2rS63jspBjyBkP2vnyGpdnrZdUtN8u+Dpx+XNuA7f8WoKxZLfpXS5+6+7miS5G aSfEb7SAoCcw4WwYv4dJf5febknrsK0SZelaRX7h2xC1mNYRoHPeCuUugDceig== Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=MzNid+Hh; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) X-Migadu-Spam-Score: 0.98 X-Spam-Score: 0.98 X-Migadu-Queue-Id: D579414C5B X-Migadu-Scanner: scn1.migadu.com X-TUID: mTMdGXZRp3CQ Hi Ludovic, Ludovic Court=C3=A8s writes: > Maxim Cournoyer skribis: > >> Rationale: the upcoming rpm-archive builder will also use it. >> >> * guix/scripts/pack.scm: >> (keyword-ref): New top-level procedure, extracted from... >> (debian-archive): ... here. Adjust usages accordingly. > > Commit aeded14b8342c1e72afd014a1bc121770f8c3a1c added #:extra-options, > which is why we need =E2=80=98keyword-ref=E2=80=99 now. > > I=E2=80=99m thinking a different option would be to use #:allow-other-key= s in > all the image build procedures. That way the deb and rpm build > procedures would get their extra arguments, which would be automatically > bound without requiring manual =E2=80=98keyword-ref=E2=80=99 calls. Soun= ds a bit nicer > maybe? I'm not sure; it sounds convenient, but at the same time, it makes the "contract" of the pack builders even fuzzier that it currently is. > If we skip to the current approach, we should consider using > =E2=80=98let-keywords=E2=80=99 from (ice-9 optargs) instead of adding =E2= =80=98keyword-ref=E2=80=99. > > Anyway, not a blocker IMO, but something to keep in mind. OK! I'll try adapting to use (ice-9 optargs) for the next revision. --=20 Thanks, Maxim