From: "Ludovic Courtès" <ludo@gnu.org>
To: Greg Hogan <code@greghogan.com>
Cc: 63092-done@debbugs.gnu.org
Subject: bug#63092: [PATCH] gnu: git: Update to 2.40.1 [security fixes].
Date: Thu, 11 May 2023 15:15:40 +0200 [thread overview]
Message-ID: <874joj3t6r.fsf_-_@gnu.org> (raw)
In-Reply-To: <20230426190346.3457310-3-code@greghogan.com> (Greg Hogan's message of "Wed, 26 Apr 2023 19:03:46 +0000")
Hi Greg,
Greg Hogan <code@greghogan.com> skribis:
> * gnu/packages/version-control.scm (git-minimal)
> [arguments]<#:phases>(remove-unusable-perl-commands): Add file check
> before deleting perl scripts so that this phase works for both new and
> old, pinned versions.
[...]
> + (if (file-exists? file)
> + (delete-file (string-append libexec
> + "/git-core/" file))))
> + ;; git-add--interactive was removed in Git 2.40 but
> + ;; this phase is inherited by older versions.
The ‘file-exists?’ and ‘delete-file’ calls are passed different file
names. Also, this won’t prevent a rebuild of ‘git-minimal/pinned’.
So I went with a different approach to achieve that goal. Applied now.
Thanks!
Ludo’.
prev parent reply other threads:[~2023-05-11 13:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-26 16:40 [bug#63092] [PATCH] gnu: git: Update to 2.40.1 [security fixes] Greg Hogan
2023-04-26 17:27 ` [bug#63092] [PATCH v2 0/2] Update git " Greg Hogan
2023-04-26 17:27 ` [bug#63092] [PATCH v2 1/2] gnu: git: Update to 2.40.1 " Greg Hogan
2023-04-26 17:27 ` [bug#63092] [PATCH v2 2/2] gnu: git-minimal: Remove deletion of removed file Greg Hogan
2023-04-26 19:03 ` [bug#63092] [PATCH v3 0/2] Update git [security fixes] Greg Hogan
2023-04-26 19:03 ` [bug#63092] [PATCH v3 1/2] gnu: git: Update to 2.40.1 " Greg Hogan
2023-04-26 19:03 ` [bug#63092] [PATCH v3 2/2] gnu: git-minimal: Check files exist before delete Greg Hogan
2023-05-11 13:15 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874joj3t6r.fsf_-_@gnu.org \
--to=ludo@gnu.org \
--cc=63092-done@debbugs.gnu.org \
--cc=code@greghogan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).