From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id eCOeNEB/gGS2RAAASxT56A (envelope-from ) for ; Wed, 07 Jun 2023 14:59:44 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id QFRLNEB/gGQtJwEAauVa8A (envelope-from ) for ; Wed, 07 Jun 2023 14:59:44 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 89B1F380BB for ; Wed, 7 Jun 2023 14:59:44 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q6ski-0006Lv-L7; Wed, 07 Jun 2023 08:59:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q6skg-0006KY-IM for guix-patches@gnu.org; Wed, 07 Jun 2023 08:59:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q6skg-00054h-84 for guix-patches@gnu.org; Wed, 07 Jun 2023 08:59:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q6skf-0006c8-Po for guix-patches@gnu.org; Wed, 07 Jun 2023 08:59:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#62726] [PATCH] services: Activate `setuid-program-service-type' in shepherd. Resent-From: Brian Cully Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 07 Jun 2023 12:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62726 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: 62726@debbugs.gnu.org Received: via spool by 62726-submit@debbugs.gnu.org id=B62726.168614271925382 (code B ref 62726); Wed, 07 Jun 2023 12:59:01 +0000 Received: (at 62726) by debbugs.gnu.org; 7 Jun 2023 12:58:39 +0000 Received: from localhost ([127.0.0.1]:53753 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q6skI-0006bK-TU for submit@debbugs.gnu.org; Wed, 07 Jun 2023 08:58:39 -0400 Received: from coleridge.kublai.com ([166.84.7.167]:57387 helo=mail.spork.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q6skH-0006bD-LL for 62726@debbugs.gnu.org; Wed, 07 Jun 2023 08:58:38 -0400 Received: from psyduck (unknown [24.184.233.231]) by mail.spork.org (Postfix) with ESMTPSA id 39CB4DA86 for <62726@debbugs.gnu.org>; Wed, 7 Jun 2023 08:58:37 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=spork.org; s=dkim; t=1686142717; bh=+buRmY39DNXyxDlBgP020I4kdb/bvX6g7hZEbbeojqQ=; h=From:To:Subject:In-Reply-To:References:Date; b=Kn5qZ0362VJpjt2NQIfRyzaSa0hp0wxU8BAz71CMTDoBeNevmYujF6VMNVRtPeW/S +fdnVOxDQszVRF96tg9rlm0zpT15WLLT2nOIEZB0ttnP2L3ATpLgZyvwx3xn7acK75 /ctpDh16vsnYIAK5xBFDUN8wJbA6DKesKsH5dxgU= In-Reply-To: (Brian Cully's message of "Sat, 8 Apr 2023 11:16:35 -0400") References: <874jpq4dfi.fsf@psyduck.jhoto.kublai.com> Date: Wed, 07 Jun 2023 08:58:16 -0400 Message-ID: <874jnja0pj.fsf_-_@psyduck.jhoto.kublai.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Brian Cully X-ACL-Warn: , Brian Cully via Guix-patches From: Brian Cully via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1686142784; a=rsa-sha256; cv=none; b=sW1IrKRrvirFkzIuWC23eKwQLliibMerYm1tn986Efh8rejs8H04HSxmsx6H9Tp+xlM8GS ftX002t7rZmX5KMZBkhSlg+dIO7hzbWhvaRiQEJ8CTmwXzQYtMbwFVyUsm05dpqG7IZltH cPl5eIYjMJwxxvlOseT/KK1qcTXlqJMxL0yPFIwLSS+zNviJFOn0tVBQH6oXCC69er9eOE 1Lm4Q3ACxCUT/Iwz1QEjx1rOUWWCEXLmSjhJZ+YFl4Vg+3N4K2HC47FYrH9ojKUFYctgaq uuFcRTrBRKonHuYH3Tmmoa2rAtauLRzzIc9m0IcgggQXMSq/FvJoU9pauGV+GA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=spork.org header.s=dkim header.b=Kn5qZ036; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1686142784; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=+buRmY39DNXyxDlBgP020I4kdb/bvX6g7hZEbbeojqQ=; b=s8pboFqSdYz4+HJkDxlhRo5CjPxms/8kdOW+x/lSZvGox60E4XqcPsYv7dhp92uPONZbRt VrE+aNvCMHnqRGFNPAuwgs8EKGhjzCNs4JOrzH9acdQSXen/Yac/+w0tpq9Flj8XHRhZH+ Z1bckks3s+NnZ4ZE+T3+XLc/tUTxwJLvZK4r/GQsQmBLRYmP2fbvcHwUGPzOzY67Jfmk91 6D5n7uVzZdEIC4C9ypl73STeT92Sw31zTnPuXDDHZUgc2YDs096LSmuVlLErpYXI9ua84C ge/icyhzO1yModsa7d+BVSrHNTtyfxZrwpcRhnqeDpR2X8acv2NqaCsSlXjOrg== Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=spork.org header.s=dkim header.b=Kn5qZ036; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -4.29 X-Spam-Score: -4.29 X-Migadu-Queue-Id: 89B1F380BB X-TUID: YilWMHLuvWIf I've made some changes to this patch to address some issues: 1) I've added =E2=80=98setuid-programs=E2=80=99 as a requirement to various= Shepherd services which need it, such as dbus and pam. I've also added it to =E2=80=98user-processes=E2=80=99 as a requirement to catch things we don't = specify explicitly. 2) I've removed (@ (gnu services) setuid-programs), rather than marking it deprecated. Since the variable name (setuid-programs-service-type) hasn't changed, normal deprecation doesn't work anyway, and just leads to annoying double-import warnings. This probably deserves an entry in =E2=80=98guix pull --news=E2=80=99, beca= use, as a Shepherd service it can now be used by other Shepherd services, and the module path has changed, which will cause errors for existing system configurations which use =E2=80=98setuid-programs-service-type=E2=80=99. I'= m not sure the best way to go about adding it, though, or if I should let a committer do it.