unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "宋文武 via Guix-patches via" <guix-patches@gnu.org>
To: Adam Faiz <adam.faiz@disroot.org>
Cc: 65565@debbugs.gnu.org
Subject: [bug#65565] [PATCH] gnu: chaiscript: Fix tests.
Date: Tue, 29 Aug 2023 18:46:41 +0800	[thread overview]
Message-ID: <874jkidt2m.fsf@envs.net> (raw)
In-Reply-To: <5f570fe8-b63c-2792-a2a1-3155f4c0b3b2@disroot.org> (Adam Faiz's message of "Sun, 27 Aug 2023 23:09:08 +0800")

Adam Faiz <adam.faiz@disroot.org> writes:

>> +    (arguments
>> +     (list
>> +      #:phases
>> +      #~(modify-phases %standard-phases
>> +          (add-after 'unpack 'fix-tests
>> +            (lambda _
>> +              ;; Its bundled catch2 fails to build with glibc-2.35.
>> +              (copy-file #$(file-append catch2 "/include/catch2/catch.hpp")
>> +                         "unittests/catch.hpp")))))
> Bundling a newer catch2 is not the solution, it's better to delete the
> bundled header so that it uses the catch2 provided in its inputs.

Um, this copy-file has the same result, it replace the bundled one with
our catch2, anyway I sent a v2 with 'snippet' and 'inputs'.

Thanks.




  reply	other threads:[~2023-08-29 10:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-27 12:30 [bug#65565] [PATCH] gnu: chaiscript: Fix tests iyzsong--- via Guix-patches via
2023-08-27 15:09 ` Adam Faiz via Guix-patches via
2023-08-29 10:46   ` 宋文武 via Guix-patches via [this message]
2023-08-29 10:40 ` [bug#65565] [PATCH v2] " iyzsong--- via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874jkidt2m.fsf@envs.net \
    --to=guix-patches@gnu.org \
    --cc=65565@debbugs.gnu.org \
    --cc=adam.faiz@disroot.org \
    --cc=iyzsong@envs.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).