From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id uPNiBbrJAmUJuQAAauVa8A:P1 (envelope-from ) for ; Thu, 14 Sep 2023 10:52:10 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id uPNiBbrJAmUJuQAAauVa8A (envelope-from ) for ; Thu, 14 Sep 2023 10:52:10 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B98CA34F62 for ; Thu, 14 Sep 2023 10:52:09 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=sfZg80KJ; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1694681529; a=rsa-sha256; cv=none; b=eHekZccAGo6JhVpRMikv5j2aYPfZcim+QzwkDfbLo7hjqZ6eT/el4VpJLZ/NQ+jsrRwj0y eiB76+TrpAA+Ja2NB4jmiswg7zCDlJKNREcWWwsoz6sy6fAB1dUfbZH/ImiyMm5zrHkpbA Cw8IaPAhNt90leB1PKm7f8qrNBAG7eaelozvkugX4sBpIJa1c9gm2cDsGkYJloSaCQu3jh s2ZI96LhgUUel3ZLtU/Dmju49GwTITGA6d5m2otDIirO17RHvSkz8WcjD8ffpPmp2kQtXD 4rMZz3rgaLwUn7jhozlowc1R3/c6LGoWWm7MXO33CGi5CZJr/7Y0PLMy/3k49g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1694681529; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=+h5HmTDPikTbUrqALtKk10ze8jM0sBrcyHMJat1/lHY=; b=A8nPJmISABl+FkLLfToXWczFCDW8foOoYT/VV8Ba6vGuIvSk53airMAlseItWc39NH/ZVO uMCxyDbqNFlXhMF51P9RNPsYfWCOBRgxYF3AW9d5SSeE2u2jzklQIxegC8bkNl3Rv7YSaS QR4KBkz0iTlKodYSOF8+abT7InsKmDXmO1pjvddwmhKx2U2GFnBiG24c7PbTbvGe98blS4 vtzMYDWyGK52Fs4DXCu+48V7f03IEZB5dRlTrc1HKjPO1CVlJLRq8JjSzkAUzt28mOCi7s WAxnE5XHCthjQ1+MD305mHbXakUHObYfLTvDDOqWO1LlwFdJOzF7IxlB0k61sw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=sfZg80KJ; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qgi4s-0007VK-Dm; Thu, 14 Sep 2023 04:51:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qgi4q-0007Uw-SY for guix-patches@gnu.org; Thu, 14 Sep 2023 04:51:56 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qgi4q-0007uz-HV for guix-patches@gnu.org; Thu, 14 Sep 2023 04:51:56 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qgi4w-0001jy-6v for guix-patches@gnu.org; Thu, 14 Sep 2023 04:52:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#65352] Fix time-machine and network Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 14 Sep 2023 08:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65352 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Simon Tournier Cc: 65352@debbugs.gnu.org, Maxim Cournoyer Received: via spool by 65352-submit@debbugs.gnu.org id=B65352.16946814976653 (code B ref 65352); Thu, 14 Sep 2023 08:52:02 +0000 Received: (at 65352) by debbugs.gnu.org; 14 Sep 2023 08:51:37 +0000 Received: from localhost ([127.0.0.1]:37608 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qgi4X-0001jE-3t for submit@debbugs.gnu.org; Thu, 14 Sep 2023 04:51:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42098) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qgi4R-0001iw-MO for 65352@debbugs.gnu.org; Thu, 14 Sep 2023 04:51:35 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qgi4G-0007oE-8d; Thu, 14 Sep 2023 04:51:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=+h5HmTDPikTbUrqALtKk10ze8jM0sBrcyHMJat1/lHY=; b=sfZg80KJWCzYAg4NAQOB cyZwVlTVA7TletkjzTv5y8/C+vF/KjrSxFGoAR2XzCsiP5L/gJr1yrTrPOeQh7PF6oHa0vDJTfaDA Px9U9EQ2VJL+nnAQzSr9iYJ2l7BbEzkYl9m29Z5OpnvjH9+pZF1+Im/RMwJivPgcsxY83hfNGFRgz tFjfLq/EZH9VV7XG6443paZlLcrcbGx4SGi4xEBBPJ0MlEHzKF2iLzIzSsMMaXoSaDfVxD8cwG0zJ gYRaKk46EU4kKMGEvH2b2RXgAru9vZkoKIoz9Y57WQebqIeDKSY3UPrR7aAHohUcheLDmffzUBp8f TAChCVWy7RST6A==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <86ledjoaly.fsf@gmail.com> <32d3fb5066e0b20e200dabef0fba897634e21dda.1694009405.git.zimon.toutoune@gmail.com> <875y4dltgm.fsf_-_@gnu.org> <86a5tqzze6.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Octidi 28 Fructidor an 231 de la =?UTF-8?Q?R=C3=A9volution, ?= jour du =?UTF-8?Q?Ma=C3=AFs?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 14 Sep 2023 10:50:58 +0200 In-Reply-To: <86a5tqzze6.fsf@gmail.com> (Simon Tournier's message of "Wed, 13 Sep 2023 02:32:17 +0200") Message-ID: <874jjxi1e5.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -6.91 X-Spam-Score: -6.91 X-Migadu-Queue-Id: B98CA34F62 X-Migadu-Scanner: mx2.migadu.com X-TUID: YC4D96DfTx2M Hi, Simon Tournier skribis: > On Wed, 13 Sep 2023 at 22:16, Ludovic Court=C3=A8s wrote: > >>> + (('commit . (? commit-id? commit)) >>> + (let ((oid (string->oid commit))) >>> + (->bool (commit-lookup repository oid)))) >>> + ((or ('tag . str) >>> + ('tag-or-commit . str)) >>> + (false-if-git-not-found >>> + (->bool (resolve-reference repository ref)))) >> >> IIUC, the differences compared to what we had are: >> >> 1. 'tag references are now handled on the fast path >> (=E2=80=98reference-available?=E2=80=99 can return #t); >> >> 2. short commit strings are now always on the slow path >> (=E2=80=98reference-available?=E2=80=99 always returns #f). >> >> Is that correct? > > No Sorry, could you explain what the difference is then on the hunk I quoted? https://issues.guix.gnu.org/65352#34-lineno11 I see different treatment of short commit IDs and tags, and no difference for full commit IDs. Thanks, Ludo=E2=80=99.