From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id AJTsGlWtBGVwRgEAauVa8A:P1 (envelope-from ) for ; Fri, 15 Sep 2023 21:15:33 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id AJTsGlWtBGVwRgEAauVa8A (envelope-from ) for ; Fri, 15 Sep 2023 21:15:33 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CF9D067F31 for ; Fri, 15 Sep 2023 21:15:32 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1694805332; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=uq73h7mYoWyf4jym+6XiQ/JCXAYXlR95HBF0O1m8eJk=; b=ZUe3TER7iLlcextE5NeB1zD6bS2nmb+oRSRdQAR724JOTkt/unyCSUvXp8fFnmak5mJNRb ljAVJKXVb4Jw2cqaA+oEt7WQ68lX/+UUOZS2kwozt1ucAVflXEoosqcdb2qpWhueIv7NsN 5ObV9V5a8bSH8P4J5FVjhutUVJm0Ot6uG5Wm2eZ7b7X+V12Bw3bH9bqQe8pukivqHhAwsL gWRnqS5Ubft2pwtfAE8zKWy6TZcexGgfk1fYeeVb8z8gLI4S8TzjOO3haVm+SEjyw+8xcK 478femjsq+Edg6X9dxyR7/OpndcOwm+2vU93mHkmPhht9JBY6/2DvlVaEQgUsg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1694805332; a=rsa-sha256; cv=none; b=ce6CpIbTOu9ooe7xKSimAXtzqv6pXfV/hEN6YKQpVZVBjCXK0PE/gPD1aaLNj0wAczgvm/ Pe8ztW/7Io1X5cDrHzMjYD4QVC6XSkR4PGDQjRQU96jx5gBhgFC5j9w8MTONgOsXttqFTx I7T9BU7YDqqiBRP4Q820VfPOSILpyBxnP3Ild5a9uykgXM6t54IbBfRVg537ASSofnwfkR V06M1vOFnTgXbEnPX6Sguw/VD8GynvW06IUQg1+iooSz17uSy4d/sPoVqmthEi12/Mi7XE 0Z7ghYIh8HTVvezPbo86eI5ZGi0JXVfA+eeBdYQAHnmH1Ein3O75aC4LfAZ12A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qhEHZ-0001YT-KX; Fri, 15 Sep 2023 15:15:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qhEHH-0001Ut-M4 for guix-patches@gnu.org; Fri, 15 Sep 2023 15:14:57 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qhEHH-00025p-75 for guix-patches@gnu.org; Fri, 15 Sep 2023 15:14:55 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qhEHN-00074c-PH for guix-patches@gnu.org; Fri, 15 Sep 2023 15:15:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#65755] This broke make check on master Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 15 Sep 2023 19:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65755 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Janneke Nieuwenhuizen Cc: Marius Bakke , 65755@debbugs.gnu.org, Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 65755-submit@debbugs.gnu.org id=B65755.169480527827147 (code B ref 65755); Fri, 15 Sep 2023 19:15:01 +0000 Received: (at 65755) by debbugs.gnu.org; 15 Sep 2023 19:14:38 +0000 Received: from localhost ([127.0.0.1]:44794 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qhEH0-00073n-3W for submit@debbugs.gnu.org; Fri, 15 Sep 2023 15:14:38 -0400 Received: from mira.cbaines.net ([212.71.252.8]:42918) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qhEGy-00073f-RQ for 65755@debbugs.gnu.org; Fri, 15 Sep 2023 15:14:37 -0400 Received: from localhost (unknown [217.155.61.229]) by mira.cbaines.net (Postfix) with ESMTPSA id 1421B27BBE2; Fri, 15 Sep 2023 20:14:29 +0100 (BST) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 07651004; Fri, 15 Sep 2023 19:14:28 +0000 (UTC) References: <871qez1e59.fsf@gnu.org> User-agent: mu4e 1.10.5; emacs 28.2 From: Christopher Baines Date: Fri, 15 Sep 2023 19:56:06 +0100 In-reply-to: <871qez1e59.fsf@gnu.org> Message-ID: <874jjvqmel.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -5.37 X-Spam-Score: -5.37 X-Migadu-Queue-Id: CF9D067F31 X-Migadu-Scanner: mx0.migadu.com X-TUID: VX7Bm25gtvYH --=-=-= Content-Type: text/plain Janneke Nieuwenhuizen writes: > Marius found that building the updated "guix" package on the > just-rebased hurd-team branch failed. > > It turns out that the packages.scm test on master fails notably: > package-transitive-supported-systems, implicit inputs > > test-name: package-transitive-supported-systems, implicit inputs > location: /home/janneke/src/guix/master/tests/packages.scm:496 > source: > + (test-equal > + "package-transitive-supported-systems, implicit inputs" > + %supported-systems > + (let ((p (dummy-package > + "foo" > + (build-system gnu-build-system) > + (supported-systems > + `("does-not-exist" "foobar" ,@%supported-systems))))) > + (parameterize > + ((%current-system "armhf-linux")) > + (package-transitive-supported-systems p)))) > expected-value: ("x86_64-linux" "mips64el-linux" "aarch64-linux" "powerpc64le-linux" "riscv64-linux" "i686-linux" "armhf-linux" "i586-gnu" "powerpc-linux") > actual-value: ("x86_64-linux" "mips64el-linux" "aarch64-linux" "powerpc64le-linux" "riscv64-linux" "i686-linux" "armhf-linux" "powerpc-linux") > result: FAIL I would say interesting, but I've struggled with the supported system stuff for years. The data service does use package-transitive-supported-systems, but in a very weird way. To check if a package supports a system, you call package-transitive-supported-systems with the package and system (as the second optional argument), then check if that system is present in the returned list. This is to say that in my uninformed opinion, the presence of the system which you pass to package-transitive-supported-systems in the returned list seems to mean something, but I wouldn't be able to say anything else about the returned value. I don't think there's anything wrong with adjusting the expectation to have the test pass, but to me the longer term thing to do is look at changing the code around supported systems. On not breaking tests when making changes though, I don't generally run make check unless I'm changing code in guix/ but it would be nice to start QA doing that for every patch series. We should also probably try to avoid tests that break when making changes to packages. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmUErRJfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9Xf4HhAAjIKlLiK6SQlIDol1fu0Eug2nXpwAwFim 1WiCaWlUBBSJZm6ESVch2VeDHAeysvlCB65CNlmK0QNyQCyQ9CjMpOypp/eoVMlu LTkzyIAwG9EUhrLCpIhN3i09HQ4uyTdcOn1YK8p3lND9yiP4g77otmW+r+MKkStS 9Z0zt9V652BaUkdHJFEzsWE1nY/Ptv5f+ewknzb3fD7rxQEZOo5b0LlQaW/JRamW ycHZUn5/Q8ISgv5t6BdkUS/RQo4Fa4CgiEhH2eKt8UmDHeKwcJMdFRICE3k6h0xn f0DZA6UuNOOLhPJW34PU5xwyz+cB170NTg5iHzYZcgUNXW2nCGjtFpXcQPu0PIEk k5L4Vx05WiPdlsVGmrhhBm/5cwwDZGXrrwz99DimuWDzvod+4x/uYEMKnx0SLnTt lt7hERvUca6l1V94pAra8xl0vo7yiDxCjZkvsS1UoX3rfZTpjuCkWKYN3p2MCTM1 4TCdg4eBxku+Bkno6r25rDsLO8wzbfOSdWj1a47+Y7tTIEXr3f7VNBq0DouCrcUM gjCV/TaqPrm7nGdMzPuh5BI05ZYJozwbyoJsQz57xG+9YthkATb9kryK6HiO0adQ a9EYwAIl5YsRN7mWW6g4LBiJemherHLZ831seOX1e3ZmQ99ua+AnvkQcOyo7xAO/ oJQVK9cJI50= =nKGY -----END PGP SIGNATURE----- --=-=-=--