From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id AObwHvJjQWWx9QAAauVa8A:P1 (envelope-from ) for ; Tue, 31 Oct 2023 21:30:42 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id AObwHvJjQWWx9QAAauVa8A (envelope-from ) for ; Tue, 31 Oct 2023 21:30:42 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 19603650F0 for ; Tue, 31 Oct 2023 21:30:42 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=Jvocq7L2; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1698784242; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=sGEiTLQqzJLYDl9fBFDJg3N2B+OdYudCdI1NBTjJIBU=; b=FC+PYdWL6cd/lUMRWhnUayNFSW3gKMLSFgbYCNJcBkow2XUJIUbguLB4NnbdzRaLBDuqAN f4rvzdKp7Qy5jltYbEcWhHjTZ1uoKydmxEAp214DlcuwSQ/unlpLmyLDU2ueJz59R7NNOS zvLQL/qsFH4EKG5Nc+6/6FBG6RE4lmuHt1qxVDlq0vjq4AR+dDG90ap4zsjAycoNcTfTbG VUvNok5zXwhENKXgQ1ZEsaCMWwH64aUsYk9jZqTnqf9PGWRDVE87eiCZtC1Dbvh79nQLAN 04Mr+x8tm668eCkIfZ61YJkpxA4CTOdCWlBIp+rkkZ2JxyITmwYKeo5wE1GfYA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=Jvocq7L2; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1698784242; a=rsa-sha256; cv=none; b=jlz0yHrHEfWrRLDOrrM3Ufw+1umvxRInQfIma9dcheUf4qHD2eBLt5cZSumOL60C5RiTza jUI0gwM9DJvZc0VPojXA9EG4uJnrGpTyDAOkziYX51MdOCBTkNrJsmy9EcKYl72eFwh47y majvQt4D4ljuelbm3q221Y3LqSiJU1hyaEkdoXWjoMEJUKq+QGWQU5HiioyrKQ9U8GPWIk 2QkO9NSc6z8QQdf3czGVvCDTVa1E0skek88jn84V5BxyoWInj3t6OUT7498u29wUb/mzEP u3HSBvzb1uDpuX7938yO0lH4iRDEpYwQrGYgVRjIrSgQ2OZHvghLbtXY+M0Xvw== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qxvNf-0002jh-1o; Tue, 31 Oct 2023 16:30:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qxvNc-0002jB-RK for guix-patches@gnu.org; Tue, 31 Oct 2023 16:30:28 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qxvNc-0005om-JF for guix-patches@gnu.org; Tue, 31 Oct 2023 16:30:28 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qxvOA-0001Zp-E8 for guix-patches@gnu.org; Tue, 31 Oct 2023 16:31:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#66475] (was 66436)] [PATCH 2/2] git-download: Add support for Git Large File Storage (LFS). Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 31 Oct 2023 20:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66475 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= , Simon Tournier Cc: Josselin Poiret , Mathieu Othacehe , Tobias Geerinckx-Rice , 66475@debbugs.gnu.org, Ricardo Wurmus , Christopher Baines Received: via spool by 66475-submit@debbugs.gnu.org id=B66475.16987842535157 (code B ref 66475); Tue, 31 Oct 2023 20:31:02 +0000 Received: (at 66475) by debbugs.gnu.org; 31 Oct 2023 20:30:53 +0000 Received: from localhost ([127.0.0.1]:49334 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qxvO1-0001KW-4S for submit@debbugs.gnu.org; Tue, 31 Oct 2023 16:30:53 -0400 Received: from mail-ot1-x32c.google.com ([2607:f8b0:4864:20::32c]:54301) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qxvNy-00012G-IA for 66475@debbugs.gnu.org; Tue, 31 Oct 2023 16:30:51 -0400 Received: by mail-ot1-x32c.google.com with SMTP id 46e09a7af769-6cd0963c61cso3528591a34.0 for <66475@debbugs.gnu.org>; Tue, 31 Oct 2023 13:30:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698784211; x=1699389011; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sGEiTLQqzJLYDl9fBFDJg3N2B+OdYudCdI1NBTjJIBU=; b=Jvocq7L2MNShBXJibxyMjOIc3GZv5nHH/jaXjKikoPhjN71DoHhVlc6VviIjpjvELm OmR8C+W+JeULEYBhz+XUUtIGRU0ytnWSWbNrZgy0+cj1Hd+wnqbo5uo8HckYbDL/bfht TTjKwxaUTm//IyaEIFbRErHTRHtbh4So9bCUpUKA4qdgQfOB38DdUNsUV9CMHoMaud+z aGcujLyAcEt7teWSB0meQK5TU+4Ypub0wat7mpV+DkFWMm5cB7WDFrADykubjPF+dvkM e7Hlc+BZsJnI89FWeTJEEu3mvHBthHABSUM5Q65OpXIkM6IEo7hSiqMrRQ8x9+boAvTJ +X2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698784211; x=1699389011; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=sGEiTLQqzJLYDl9fBFDJg3N2B+OdYudCdI1NBTjJIBU=; b=wrGNOiMHEl2jhmmE3JBxno9+yp5CXF62R6aFaGssvR9tUsrsqtVXRUqteXyxa8jZ+f IIf36GBnbZpXqi64DzKsAe7wgvqJiPJHW+IlzLzgPpCg1xNzae6hngNWQa6Xf+46qxbM EQY8eONkYqYokOvpiUR6/KA9nWNbWIyXvNnUS18q7LFWOUjE5zDcp+1AM/Prh3q4x/pv GSMG3U2w5VajzmuSUURpzUE+bm9NHpUSDwBRAQU+85HkzhUR3XVoL8Q9Bg+Ca/jXtg1w 5/OhdSoKTESvnMQwYR0Fd4dFmYGby+LdCNEN4irZEprThIespmiEmakzx7Sk6OJeypOv Vthw== X-Gm-Message-State: AOJu0Yw5dsiNt8V3Too201+a951ViLcebRLZB9zCYY2jfbQo0/cyVKn9 rdkyS3zJtBxufKSbleDhTWU= X-Google-Smtp-Source: AGHT+IHgayixmyV+bszgI2ftxRLX9xPIo7qNRWihTQo7NxKXA7ypzbVUfdkiQTohOUXb9WQq335jqw== X-Received: by 2002:a9d:7499:0:b0:6bc:8afe:8a15 with SMTP id t25-20020a9d7499000000b006bc8afe8a15mr12888501otk.38.1698784210825; Tue, 31 Oct 2023 13:30:10 -0700 (PDT) Received: from hurd (dsl-10-128-239.b2b2c.ca. [72.10.128.239]) by smtp.gmail.com with ESMTPSA id x25-20020ac84d59000000b00419c40a0d70sm796122qtv.54.2023.10.31.13.30.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Oct 2023 13:30:09 -0700 (PDT) From: Maxim Cournoyer In-Reply-To: <87fs2awn6r.fsf@gmail.com> (Maxim Cournoyer's message of "Mon, 16 Oct 2023 12:23:56 -0400") References: <58269ccea06b016c38d3bea8678608c8cccce1ca.1697078865.git.maxim.cournoyer@gmail.com> <877cnpdt6d.fsf@gnu.org> <87fs2ar42s.fsf@gmail.com> <87fs2awn6r.fsf@gmail.com> Date: Tue, 31 Oct 2023 16:30:07 -0400 Message-ID: <874ji6pmb4.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: 4.39 X-Spam-Score: 4.39 X-Migadu-Queue-Id: 19603650F0 X-Migadu-Scanner: mx10.migadu.com X-TUID: /wdoWBNt87d8 Hi, Maxim Cournoyer writes: > Hi, > > Simon Tournier writes: > >> Hi, >> >> I reorder Ludo=E2=80=99s answers for clarity. >> >> On Sat, 14 Oct 2023 at 19:12, Ludovic Court=C3=A8s wrote: >> >>> Also, it is crucial for the =E2=80=9Cbuiltin:git-download=E2=80=9D sema= ntics to be the >>> same across all installations and to be very stable. >> >> I agree and that=E2=80=99s one strong argument for me. >> >>> Overall, I feel like LFS support, if needed, should be =E2=80=9Con the = side=E2=80=9D, >>> with a custom =E2=80=98git-fetch/lfs=E2=80=99 or something along these = lines (just like >>> we have =E2=80=98url-fetch/tarbomb=E2=80=99). >> >> I agree with this direction. Most of the fetching methods should not be >> implemented with =E2=80=9Cbuiltin=E2=80=9C but the converse, git-fetch/l= fs. >> >> ( Even, I think the current git-fetch using out-of-band builtin >> recently introduced should be a =E2=80=99git-fetch/bootstrap=E2=80=99 me= thod, and >> git-fetch using in-band should be the default method. ) > > Thanks for tipping in, I'll look into adding a whole new 'git-fetch/lfs' > procedure. Done, see v2. The 'orcus' package makes use of it -- its test suite is broken without it. --=20 Thanks, Maxim