From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>,
"Simon Tournier" <zimon.toutoune@gmail.com>
Cc: Josselin Poiret <dev@jpoiret.xyz>,
Mathieu Othacehe <othacehe@gnu.org>,
Tobias Geerinckx-Rice <me@tobias.gr>,
66475@debbugs.gnu.org, Ricardo Wurmus <rekado@elephly.net>,
Christopher Baines <guix@cbaines.net>
Subject: [bug#66475] (was 66436)] [PATCH 2/2] git-download: Add support for Git Large File Storage (LFS).
Date: Tue, 31 Oct 2023 16:30:07 -0400 [thread overview]
Message-ID: <874ji6pmb4.fsf_-_@gmail.com> (raw)
In-Reply-To: <87fs2awn6r.fsf@gmail.com> (Maxim Cournoyer's message of "Mon, 16 Oct 2023 12:23:56 -0400")
Hi,
Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
> Hi,
>
> Simon Tournier <zimon.toutoune@gmail.com> writes:
>
>> Hi,
>>
>> I reorder Ludo’s answers for clarity.
>>
>> On Sat, 14 Oct 2023 at 19:12, Ludovic Courtès <ludo@gnu.org> wrote:
>>
>>> Also, it is crucial for the “builtin:git-download” semantics to be the
>>> same across all installations and to be very stable.
>>
>> I agree and that’s one strong argument for me.
>>
>>> Overall, I feel like LFS support, if needed, should be “on the side”,
>>> with a custom ‘git-fetch/lfs’ or something along these lines (just like
>>> we have ‘url-fetch/tarbomb’).
>>
>> I agree with this direction. Most of the fetching methods should not be
>> implemented with “builtin“ but the converse, git-fetch/lfs.
>>
>> ( Even, I think the current git-fetch using out-of-band builtin
>> recently introduced should be a ’git-fetch/bootstrap’ method, and
>> git-fetch using in-band should be the default method. )
>
> Thanks for tipping in, I'll look into adding a whole new 'git-fetch/lfs'
> procedure.
Done, see v2. The 'orcus' package makes use of it -- its test suite is
broken without it.
--
Thanks,
Maxim
prev parent reply other threads:[~2023-10-31 20:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1697078865.git.maxim.cournoyer@gmail.com>
2023-10-12 2:48 ` [bug#66436] [PATCH 1/2] gnu: git-lfs: Patch /bin/sh references Maxim Cournoyer
2023-10-14 17:04 ` Ludovic Courtès
2023-10-16 14:46 ` Maxim Cournoyer
2023-10-16 21:28 ` [bug#66475] " Maxim Cournoyer
2023-10-12 3:02 ` [bug#66475] [PATCH 2/2] git-download: Add support for Git Large File Storage (LFS) Maxim Cournoyer
2023-10-14 17:12 ` [bug#66436] " Ludovic Courtès
2023-10-16 15:10 ` Maxim Cournoyer
2023-10-16 15:15 ` Simon Tournier
2023-10-16 16:23 ` Maxim Cournoyer
2023-10-31 20:30 ` Maxim Cournoyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874ji6pmb4.fsf_-_@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=66475@debbugs.gnu.org \
--cc=dev@jpoiret.xyz \
--cc=guix@cbaines.net \
--cc=ludo@gnu.org \
--cc=me@tobias.gr \
--cc=othacehe@gnu.org \
--cc=rekado@elephly.net \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).