From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:5f26::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id slsEJPvYkWUaewAAkFu2QA (envelope-from ) for ; Sun, 31 Dec 2023 22:11:23 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id 4G7iHvvYkWXJSwEAqHPOHw (envelope-from ) for ; Sun, 31 Dec 2023 22:11:23 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=YB9C7aEr; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1704057083; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=UscSEKXhcOTWdMw0j2XdbQMKI6WCMd7GWgbBdMWWp8k=; b=lpk86pZlCxX20gEtjTxLUiFW0fxDZEUjZTxl8gVJKri9Xr5+T9ctR6EdRxKxaceyhoW6aH 7cY284A/mqb+EJe6xpL7i/q87AfuTq9yiIZxYubhPxuIAj19FX1t79e45bmrOsUwVr6goF u4sezii66bKfIrlRz121chr3Vzvyo3Hx6FWv/EvE3W3uusSLGnuVSgoBHG0IbeJtE1Vm4U K05JYSBefmJe5eB4upMsdZEb5DgWFe5UQIOTq7+4j+Znteoz/9uPz+kzInnfgMXBKNJe1Z fp8aw1ExQ7pwBCbsnzLyIbRDrdcyBxt2MxGBIXBCmkU6ByYCinuspzNCQ5vOAw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=YB9C7aEr; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1704057083; a=rsa-sha256; cv=none; b=mLb7XuwNQCfgtFyrNoV9W9ivKIBqpn6QgVGjL4zBQZLr3TefQo2oeCyqrDguQhSABo6B4K bZObkxoEPUCz/GPT8tDZphEJsRf4DucSUA0HDS9b4pOCFEjIZ1D+bYsMOg60MyaZ94Lggg ldJQxiVxA1cfTeWb4kIp92DXbjvYXsDH4cjx5wjua7btzFwa+Ut3MdOAF1nRM1Jvhykfkw Bqz9OKZSADimF+HviQd7Mmi3OtbIbGtVUFtLB511vlHXYnzWNepx986nu5PU2t2BKulsDS 3PZXSdbOSyHRNExVo250CLpCNa85lEygMTlQ7jhR7ATiHoSCtPRW7V2kEhWugA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3B15C55956 for ; Sun, 31 Dec 2023 22:11:23 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rK35K-0000Ra-TT; Sun, 31 Dec 2023 16:11:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rK35I-0000RJ-VU for guix-patches@gnu.org; Sun, 31 Dec 2023 16:11:00 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rK35I-0000El-Na for guix-patches@gnu.org; Sun, 31 Dec 2023 16:11:00 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rK35J-0000bM-L2 for guix-patches@gnu.org; Sun, 31 Dec 2023 16:11:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#68180] [PATCH 1/4] gnu: emacs: Add awk, find, sed and sh to PATH wrapper. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 31 Dec 2023 21:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68180 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler Cc: 68180@debbugs.gnu.org, Katherine Cox-Buday , Andrew Tropin Received: via spool by 68180-submit@debbugs.gnu.org id=B68180.17040570142247 (code B ref 68180); Sun, 31 Dec 2023 21:11:01 +0000 Received: (at 68180) by debbugs.gnu.org; 31 Dec 2023 21:10:14 +0000 Received: from localhost ([127.0.0.1]:47115 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rK34X-0000aB-Os for submit@debbugs.gnu.org; Sun, 31 Dec 2023 16:10:14 -0500 Received: from mail-qv1-xf2f.google.com ([2607:f8b0:4864:20::f2f]:42181) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rK34V-0000Zu-H6 for 68180@debbugs.gnu.org; Sun, 31 Dec 2023 16:10:12 -0500 Received: by mail-qv1-xf2f.google.com with SMTP id 6a1803df08f44-680b69b1cd9so298496d6.0 for <68180@debbugs.gnu.org>; Sun, 31 Dec 2023 13:10:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704057004; x=1704661804; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UscSEKXhcOTWdMw0j2XdbQMKI6WCMd7GWgbBdMWWp8k=; b=YB9C7aErL2O68U9JONp38TcQbtnzfyq0qrloN3Rm3VZb0FUlQYfrC2LIA8UN/Blcaq 6nDEdMkGVTV5vwaiexDCuizui9CuKFck7YwKdut+GgBsAjNigrqmkkerr6OIYkDhFJt5 mZjBNMfdtjPYSdtx40ostb3L9Yf57KLgw0P7N1JwKHovohp1b1EtDxIab048ikC/7a9w w54USS/k2yYx8vUAc+eTFNHy1qX2fRAci4JTlTGj0+/Mc2dglz+MWHI2y+lNZxoGBidE +CFe1b6UElWZuI9QxLV0VYo1SEjus6ujDYGnOfMVpG7PuUbmOeKIih1/H3lqCqY9zafh sJVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704057004; x=1704661804; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=UscSEKXhcOTWdMw0j2XdbQMKI6WCMd7GWgbBdMWWp8k=; b=M+qLWPDrzQwZR+IDEu7d08tta1IoYCW1aE5M8vppygYhIclZXWQD9TrSr0/3SX+hyt MNyOZDFkH8xvwTcTVU9kJOb/BNIjADQVaiAH5NbDLHDjR0kc4064TKeAIEn6XcsA78No 2fdstsSLL6Nana2g5R2EppL+c3im5mLG6gXIq+Z8OnBxfUYp1siqkD4IXtzzY1/TgSRW p8E4XspYnzJpbSqWuK4p0pD/bML+bTTdGH1agCf8eqyFrZpVzd+qymaKAq+/zoul2TMQ gEDPF27zOgau8aL2mxeaxkThYaLB6938AS9RzdcSW+4SVPBsDlGwHjNucGD3Mwc3IkGY CyCQ== X-Gm-Message-State: AOJu0YzPcZfUrqo4DsM3eG12gw1/HkkVHwl6FnH4DoliDKqvOtsobIDM sbbqJkWz+b3tkbXf9x7eaOo= X-Google-Smtp-Source: AGHT+IGJLCHBjAFuwU4Wg6CEehjsfVQdx1UE/mVfgTYnmeKBca2RfHv+za45g604hIFBa/fGH4dubA== X-Received: by 2002:a05:6214:e47:b0:67f:e29:d4f4 with SMTP id o7-20020a0562140e4700b0067f0e29d4f4mr16084022qvc.14.1704057004496; Sun, 31 Dec 2023 13:10:04 -0800 (PST) Received: from hurd (dsl-10-141-187.b2b2c.ca. [72.10.141.187]) by smtp.gmail.com with ESMTPSA id w3-20020a0562140b2300b0067f4507b64dsm8817043qvj.63.2023.12.31.13.10.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 31 Dec 2023 13:10:04 -0800 (PST) From: Maxim Cournoyer In-Reply-To: <6b33be06b0ea3a9aa4e29b8c8a958150cc05a7e9.camel@gmail.com> (Liliana Marie Prikler's message of "Sun, 31 Dec 2023 20:13:06 +0100") References: <6b33be06b0ea3a9aa4e29b8c8a958150cc05a7e9.camel@gmail.com> Date: Sun, 31 Dec 2023 16:10:03 -0500 Message-ID: <874jfyoz84.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -3.65 X-Spam-Score: -3.65 X-Migadu-Queue-Id: 3B15C55956 X-TUID: GurtckVAUXgM Hi Liliana, Liliana Marie Prikler writes: > Am Sonntag, dem 31.12.2023 um 11:59 -0500 schrieb Maxim Cournoyer: >> Before this change, using Emacs in a pure environment, e.g. 'guix >> shell --pure emacs', would cause problems such as: >>=20 >> =C2=A0 jka-compr-insert-file-contents: Uncompression program =E2=80=98sh= =E2=80=99 not >> found >>=20 >> And other problems were found requiring the other tools.=C2=A0 While the >> above could be patched in place for 'sh', it seems more robust and >> universally useful to have the commands appear on PATH, should other >> Elisp modules want to call to these directly as well. >>=20 >> * gnu/packages/emacs.scm (emacs-minimal) [arguments] : Adjust >> the >> wrap-emacs-paths phase to wrap additional inputs. >> [inputs]: Add findutils, gawk and sed. >> (%emacs-modules): Add (srfi srfi-26). >>=20 >> Change-Id: Ifb4fe2fc12ddc9eae387adb3da3f7821fab78e65 >> --- > We already have a phase to patch in the real path of /bin/sh where it's > used. This appears to be an odd case that's missed. I appreciate exactness, but it seems fragile to rely on nobody adding new references or someone catching them as new Emacs modules get added or changed :-). My reasoning was that since Emacs already depends on bash, why not ensure it'll always be found on PATH, by wrapping instead of substituting. Does it make sense? --=20 Thanks, Maxim