From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id QNc+NqzMvGX4hQAAe85BDQ:P1 (envelope-from ) for ; Fri, 02 Feb 2024 12:06:21 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id QNc+NqzMvGX4hQAAe85BDQ (envelope-from ) for ; Fri, 02 Feb 2024 12:06:21 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lassieur.org header.s=fm2 header.b=GN1ox8T5; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm3 header.b="n JRf0lK"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1706871980; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=7aRoExnv2jEX8wYY4AAiHxbZntz5vmFWWuWvPye39UU=; b=d8czMA+dyxMX8pOknjL7/1P+y1oVLRx6DX3zSfySLBwSzA8NUTC7hhkvcC0+hZzoowRRbs kIFqpMN2F3pZ/oWjxFNhiT57YLkKThfk84LCTVQn3wzbECh/nk8nE9kLpG08o+99yMyL82 aOQTPWLlYui0Cuej1mChOvZyUSuYa+Lq0ZO0A6PR+r484lq89zSvhkWFfKOKJ9leoWkH0S CBYnG7bzFHT3Ct9O5RacPaLvPWhk0Cr0FGxpOh2Hmt4z7+Dt3f9lGEnLPTeauid5XbFGLb jm86ZuiQFGfPBFCLZKw++02v4sRFiyN5MFThQUdNX0N7rBrbPz0IVX7589xhTA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lassieur.org header.s=fm2 header.b=GN1ox8T5; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm3 header.b="n JRf0lK"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1706871980; a=rsa-sha256; cv=none; b=rM3CfSXpbeSd9F3M7OH9rZqWWPn3FW1BGXq1/COEr85aO4VeBmAf5tit6K4ne7YXv6qR3V CjEYCbybi/X4iaZ+A7W6i8S406Urx8mAsOSWphMGPamydN1RzZn+HX9oGbAg4xz1R1RRZ5 rEwOjnZLE9vptBZOj1dCc6t/ovGeFtgQAI1JwDX23YVLb4qCnhRvXtrGw0/xyX0EXx3qZD kCJMPsI8hA4aMcBi44gqj9o0KBibflxSOHvihn4g8KN/uTcoCPuMDgCzNV+qwE/him2Ben 3NzDW1smMEwGQSJ5/rLeSd3Jwfo3PUXE2GVcS0xZQHUjqnAc22MagtZMZ7/LSw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C97A76B754 for ; Fri, 2 Feb 2024 12:06:19 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rVrMq-0004po-IG; Fri, 02 Feb 2024 06:05:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rVrMm-0004pQ-AQ for guix-patches@gnu.org; Fri, 02 Feb 2024 06:05:53 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rVrMm-0005U0-1q for guix-patches@gnu.org; Fri, 02 Feb 2024 06:05:52 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rVrMw-0007xK-BN for guix-patches@gnu.org; Fri, 02 Feb 2024 06:06:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#68577] [PATCH v2 1/2] gnu: torbrowser: Stop inheriting Icecat. Resent-From: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 02 Feb 2024 11:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68577 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: =?UTF-8?Q?Andr=C3=A9?= Batista Cc: Mark H Weaver , 68577@debbugs.gnu.org, Jonathan Brielmaier , Ian Eure Received: via spool by 68577-submit@debbugs.gnu.org id=B68577.170687190730503 (code B ref 68577); Fri, 02 Feb 2024 11:06:02 +0000 Received: (at 68577) by debbugs.gnu.org; 2 Feb 2024 11:05:07 +0000 Received: from localhost ([127.0.0.1]:43758 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rVrM3-0007vt-0G for submit@debbugs.gnu.org; Fri, 02 Feb 2024 06:05:07 -0500 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:50991) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rVrM0-0007vK-Jx for 68577@debbugs.gnu.org; Fri, 02 Feb 2024 06:05:05 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 21C483200AC7; Fri, 2 Feb 2024 06:04:45 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Fri, 02 Feb 2024 06:04:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lassieur.org; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1706871884; x=1706958284; bh=7aRoExnv2jEX8wYY4AAiHxbZntz5vmFWWuWvPye39UU=; b= GN1ox8T59o5xB2ia9M5baVfg/T+GFNSk5E+sbHveb3Wet708ifsDcwZTti2w/7Eb aV83m2OCk10ALQoSj9G0iz8Je14X2cua4U1y7kqOVfZaKyyzOjrLt0K2XWEbvVid gZQuwXU9dRoRZ4pK03IPD1H9pOnJePn1YVlLTFhn+/0hMaR/iX5t6lr/kQmeYk6S /WE906HwjGaLmVu3aD/K9/e2hghCPndxErGFa41/3MXKbNZt/R89XioJ7b/LuBsB 7ZxL5Y/HQWu3UC6TZzKmR1Z4dxuavuXgbw6pDVQV73uEXXBHnQF+TwGfeZ26/HO1 7rjxnyEtKU973ixDlcH1vA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1706871884; x= 1706958284; bh=7aRoExnv2jEX8wYY4AAiHxbZntz5vmFWWuWvPye39UU=; b=n JRf0lKh/6treArJmdYMUwqc0qwOIqbyeC2hOyzaMedqjwKHY/bdBmhNCmtkKYV2A KZBPm/4mgJnv2FA1TAIoV3EfOcuuQ11pX6GeYbMGr9gOmBxDaSC7ZpCZBJUoL9+4 Mb+xEMvj4rqID+PS/vGI8a2sWpb6G4VSsaiZLsHAKuKpjxlglyH+bddB/EQvXxAO LErHw1Eq3JnXzO06B0ZthR83HjeH8nNhvDZQGN1Y2PxU791WGQ7Bl6liSmvGVFNX CDJviwL+OIlmktjSM9rt6tCNCgfo2yXAeqdHf5lusu9mr8fcIn42/Ic6+ntAOtsd m5etsjCoObSkn7T0rE6RA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrfedugedgvdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefujghffffkfgggtgfgsehtqhertddtreejnecuhfhrohhmpeevlhor mhgvnhhtucfnrghsshhivghurhcuoegtlhgvmhgvnhhtsehlrghsshhivghurhdrohhrgh eqnecuggftrfgrthhtvghrnhepgeekheefffdtfeffueevkefgfffhtddugfdugeeugeev gfduteffudfgfefhjedunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrg hilhhfrhhomheptghlvghmvghntheslhgrshhsihgvuhhrrdhorhhg X-ME-Proxy: Feedback-ID: i4c21472a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 2 Feb 2024 06:04:43 -0500 (EST) From: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur In-Reply-To: ("=?UTF-8?Q?Andr=C3=A9?= Batista"'s message of "Thu, 1 Feb 2024 20:46:58 -0300") References: <7044a87b07b302fb861f9853725ec0ca0abb8354.1706222112.git.clement@lassieur.org> Date: Fri, 02 Feb 2024 12:04:39 +0100 Message-ID: <874jerktyw.fsf@lassieur.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -2.76 X-Migadu-Queue-Id: C97A76B754 X-Spam-Score: -2.76 X-Migadu-Scanner: mx11.migadu.com X-TUID: FYl7XCPIYJ1q Hi Andr=C3=A9, On Thu, Feb 01 2024, Andr=C3=A9 Batista wrote: > qui 25 jan 2024 =C3=A0s 23:54:36 (1706237676), clement@lassieur.org envio= u: >> + >> +;; Must be of the form YYYYMMDDhhmmss as in `date +%Y%m%d%H%M%S`. >> +(define %moz-build-date "20240123154553") > > First just a heads up so that you do not forget to update the build-date. Yes, I did rebase locally. Thanks for the reminder! > And also on tor.scm: > >> diff --git a/gnu/packages/tor.scm b/gnu/packages/tor.scm >> index 6ded83b83fee..2e2a19ae3e41 100644 >> --- a/gnu/packages/tor.scm >> +++ b/gnu/packages/tor.scm >> ... >> >> @@ -37,16 +36,10 @@ (define-module (gnu packages tor) >> #:use-module (guix utils) >> #:use-module (guix download) >> #:use-module (guix git-download) >> - #:use-module (guix hg-download) >> - #:use-module (guix build-system copy) >> #:use-module (guix build-system gnu) >> - #:use-module (guix build-system mozilla) >> #:use-module (guix build-system python) >> #:use-module (guix build-system pyproject) >> #:use-module (gnu packages) >> - #:use-module (gnu packages base) > > I think you've mistankenly removed base and also > >> - #:use-module (gnu packages bash) >> - #:use-module (gnu packages browser-extensions) >> #:use-module (gnu packages libevent) >> #:use-module (gnu packages linux) >> #:use-module (gnu packages check) >> @@ -54,11 +47,8 @@ (define-module (gnu packages tor) >> #:use-module (gnu packages pcre) >> #:use-module (gnu packages freedesktop) >> #:use-module (gnu packages glib) >> - #:use-module (gnu packages golang) >> - #:use-module (gnu packages gnuzilla) >> #:use-module (gnu packages pkg-config) >> #:use-module (gnu packages python) >> - #:use-module (gnu packages python-check) > > python-check here. > > They were there before the commit which has added torbrowser. > > On git logs, it seems 'base' is needed for the 'which' input to torsocks, > as per f3cf25c3c2aef91a47b790fe69b5008cdb6a6316. > > 'python-check' OTOH is needed for the 'python-colorama' input to > onionshare, as per 55db762b31531609f43b32680298762487702280. =E2=80=98make=E2=80=99 was happy but maybe it's not enough? I'll add them = back. > I have not yet tried to rebuild them without those inputs to see if they > are actually still needed though. In case they are not, for clarity, I > think it would be better to remove them on a separate patch anyway. Yes! > Finally, I've noticed that we are still using 'ffmpeg-5' as an input to > both icecat and torbrowser. However, as we are now based on firefox > version 115, ffmpeg is compatible. I've built it to check and it appears > to be working fine (though I've only watched one single video to test > it and only on torbrowser). IMO, this should be also a separate patch. I agree, for a separate patch! > Other than that, all looks good to me, even if it gives me a headache. :D Gives me headaches too :) Thanks, pushed. Cl=C3=A9ment