From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Andrew Tropin <andrew@trop.in>
Cc: 71111@debbugs.gnu.org, richard@freakingpenguin.com,
zhengjunjie@iscas.ac.cn, pelzflorian@pelzflorian.de,
matt@excalamus.com, ludo@gnu.org
Subject: [bug#71111] [PATCH 0/1] services: home: Use pairs instead of lists.
Date: Thu, 23 May 2024 12:02:42 -0400 [thread overview]
Message-ID: <874jaojz31.fsf@gmail.com> (raw)
In-Reply-To: <877cfl13sc.fsf@trop.in> (Andrew Tropin's message of "Thu, 23 May 2024 09:43:47 +0400")
Hi,
Andrew Tropin <andrew@trop.in> writes:
> On 2024-05-23 11:38, Zheng Junjie wrote:
>
>> Andrew Tropin via Guix-patches via <guix-patches@gnu.org> writes:
>>
>>> After rewriting from car/cdr to match-lambda in v2 of this patch:
>>> https://yhetil.org/guix-patches/3394b0b51f6a5a608ebcfb7a63fdc34e52fe928e.1711046203.git.richard@freakingpenguin.com/
>>>
>>> the format changed from pairs to lists, I didn't noticed this nuance
>>> during review because the documentation still says that service should
>>> be configured and extended with pairs. Also, pairs are more
>>> apropriate data type here. And this match-lambda rewrite will break
>>> downstream RDE user's setups after migrating to upstreamed version of
>>> service.
>>>
>>> That's why I propose to go back to pairs.
>>
>> Maybe we can support pairs and list of length two at same time?
>
> Thank you for the idea, however I think ambiguity is a bad practice,
> from my early experience with guix it's more confusing rather than
> helpful.
I agree.
--
Thanks,
Maxim
next prev parent reply other threads:[~2024-05-23 16:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-22 10:02 [bug#71111] [PATCH 0/1] services: home: Use pairs instead of lists Andrew Tropin via Guix-patches via
2024-05-22 10:02 ` [bug#71112] [PATCH 1/1] " Andrew Tropin via Guix-patches via
2024-05-22 11:06 ` [bug#71111] " Andrew Tropin via Guix-patches via
2024-05-22 21:33 ` [bug#71111] [PATCH 0/1] " Richard Sent
2024-05-23 5:45 ` Andrew Tropin via Guix-patches via
2024-05-23 3:38 ` Zheng Junjie
2024-05-23 5:43 ` Andrew Tropin via Guix-patches via
2024-05-23 16:02 ` Maxim Cournoyer [this message]
2024-05-23 5:53 ` [bug#71111] [PATCH v2 " Andrew Tropin via Guix-patches via
2024-05-23 5:53 ` [bug#71111] [PATCH v2 1/1] " Andrew Tropin via Guix-patches via
2024-05-23 9:16 ` Ludovic Courtès
2024-05-23 13:06 ` Andrew Tropin via Guix-patches via
2024-06-02 9:50 ` [bug#71111] [PATCH 0/1] " Andrew Tropin via Guix-patches via
2024-06-02 10:15 ` Ludovic Courtès
2024-06-02 10:37 ` Efraim Flashner
2024-06-02 11:12 ` Andrew Tropin via Guix-patches via
2024-06-02 10:57 ` Andrew Tropin via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jaojz31.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=71111@debbugs.gnu.org \
--cc=andrew@trop.in \
--cc=ludo@gnu.org \
--cc=matt@excalamus.com \
--cc=pelzflorian@pelzflorian.de \
--cc=richard@freakingpenguin.com \
--cc=zhengjunjie@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).