unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Guillaume Le Vaillant <glv@posteo.net>
To: jgart <jgart@dismail.de>
Cc: 73170@debbugs.gnu.org
Subject: [bug#73170] [PATCH] gnu: Add cl-async-process.
Date: Tue, 17 Sep 2024 13:16:36 +0000	[thread overview]
Message-ID: <874j6es9mz.fsf@kitej> (raw)
In-Reply-To: <21b927da240259b41c3ceee1a246019095509740.1725985244.git.jgart@dismail.de> (jgart@dismail.de's message of "Tue, 10 Sep 2024 11:20:44 -0500")

[-- Attachment #1: Type: text/plain, Size: 3456 bytes --]

Hi.

jgart <jgart@dismail.de> skribis:

> +(define (async-process-origin commit name version)
> +  (origin
> +    (method git-fetch)
> +    (uri (git-reference
> +          (url "https://github.com/lem-project/async-process")
> +          (commit commit)))
> +    (file-name (git-file-name name version))
> +    (sha256
> +     (base32 "1m2sfgfg6c0gqqy1pqsahsiw3j25y473mfw7sx0akkqbhwhm7mjb"))
> +    (modules '((guix build utils)))
> +    (snippet
> +     ;; Delete precompiled artifacts.
> +     `(begin
> +        (for-each delete-file-recursively
> +                  (list "static"
> +                        "static_old0001-819cbf6"))))))

I don't think this function is necessary; and the sha256 hash is fixed
here but it would in fact depend on the commit passed as argument to the
function.


> +(define async-process-c-sources
> +  (let ((commit "9690530fc92b59636d9f17d821afa7697e7c8ca4")
> +        (revision "0"))
> +    (package
> +      (name "async-process-c-sources")
> +      (version (git-version "0.0.1" revision commit))
> +      (source (async-process-origin commit name version))
> +      (build-system gnu-build-system)
> +      (arguments
> +       (list
> +        #:phases
> +        #~(modify-phases %standard-phases
> +            (replace 'bootstrap
> +              (lambda _
> +                (invoke "libtoolize")
> +                (invoke "aclocal")
> +                (invoke "autoheader")
> +                (invoke "automake" "-a")
> +                (invoke "autoconf"))))))
> +      (native-inputs (list autoconf automake libtool))
> +      (home-page "https://github.com/lem-project/async-process")
> +      (synopsis "Asynchronous process execution for Common Lisp")
> +      (description "This library provides an asynchronous process
> +execution mechanism for Common Lisp.")
> +      (license license:expat))))

So I would rather put the 'origin' field in this package building the
C library. And as the purpose of this package is to build the
libasyncprocess library, I would just call it "libasyncprocess".


> +(define-public sbcl-async-process
> +  (let ((commit "9690530fc92b59636d9f17d821afa7697e7c8ca4")
> +        (revision "0"))
> +    (package
> +      (name "sbcl-async-process")
> +      (version (git-version "0.0.1" revision commit))
> +      (source (async-process-origin commit name version))
> +      (build-system asdf-build-system/sbcl)
> +      (arguments
> +       (list
> +        #:phases
> +        #~(modify-phases %standard-phases
> +            (add-after 'unpack 'fix-paths
> +              (lambda* (#:key inputs #:allow-other-keys)
> +                (substitute* "src/async-process.lisp"
> +                  (("libasyncprocess\\.so")
> +                   (search-input-file inputs
> +                                      "/lib/async-process/libasyncprocess.so"))))))))
> +      (inputs (list async-process-c-sources sbcl-cffi))
> +      (home-page "https://github.com/lem-project/async-process")
> +      (synopsis "Asynchronous process execution for Common Lisp")
> +      (description "This library provides an asynchronous process
> +execution mechanism for Common Lisp.")
> +      (license license:expat))))

Then the sbcl-async-process package could be simplified by inheriting
from the libasyncprocess package, and modifying the 'name',
'build-system', 'inputs' and 'arguments' fields.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

  parent reply	other threads:[~2024-09-17 13:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-10 16:20 [bug#73170] [PATCH] gnu: Add cl-async-process jgart via Guix-patches via
2024-09-10 16:41 ` jgart via Guix-patches via
2024-09-17 13:16 ` Guillaume Le Vaillant [this message]
2024-09-26  6:54 ` bug#73170: " jgart via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874j6es9mz.fsf@kitej \
    --to=glv@posteo.net \
    --cc=73170@debbugs.gnu.org \
    --cc=jgart@dismail.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).