From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id oGEDGesbJWeAPgAAe85BDQ:P1 (envelope-from ) for ; Fri, 01 Nov 2024 18:20:27 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id oGEDGesbJWeAPgAAe85BDQ (envelope-from ) for ; Fri, 01 Nov 2024 19:20:27 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b="sdwD6/LY"; dkim=fail ("headers rsa verify failed") header.d=nicolasgoaziou.fr header.s=mailo header.b=fNFykErH; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1730485227; a=rsa-sha256; cv=none; b=BMKCa8ghaCWO12Vn1THUufOSA4u/42Ee6vGd94SCAhsKDKZCKSxCF9G3VTz5GBpzhBum6t DN5jzZkGjIw9b6DvLXK+heirTFmugXEJ0dyy8OgL5B1HKb0t8gBYQ4cKRfd9XY2+mEtc1a dm6cx2p0z+xC6wdrlwNYp0KchBRssOKCF69a58u+7UGjeifIRZV7ZDAj4cchhXOg/wyPo0 852gnF86BF6/LhmoUnZNFe8sWp3AtdqsfQ7Mwk1EL7dPTqXM89gEjDlWH44Wo4Szianps7 bmvQz5kaRn5DChC7MX5xUcR2ds0UXS+HY+EDloSA2mb+x2+2Vc74AeYvuqhuSQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b="sdwD6/LY"; dkim=fail ("headers rsa verify failed") header.d=nicolasgoaziou.fr header.s=mailo header.b=fNFykErH; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1730485227; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=RnbSWEA2zdn0LRYr1NtFhaXD2xL3RfmGEovbGZWmS9k=; b=XaryTFEz+8EY3n1V8xvAoTYDda6X6ZupL4JhoPYaG15sDAIK3RT75XikkCMoa1k3Qpt6Cd YNB4oj7m/ZeGfKtAWKXZSnXQ04c+//NhyzZLR8UKOS/sdWZVY4zOVY7dUna2jFA1y/XC9A mhKeDaixqg2dKcFVXxXcqFX4+UxgmO4DdaJRmSJdPtfl0SHw2+zXIBqdzXhqEb5lFPHcpj yW6Z8NW9Rt7oyAbVylSDXFoa1rc1KPULsDeE7l5OMOn8ZRcopSVqGT+N32Ovq3Izxe0cT2 8JfG8eU5itt7+Pm+iB5/zIifmMBQlBhS73Mz7Jv/duRAK4tVPGeOAiCAzgPtqw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6F65782CD0 for ; Fri, 01 Nov 2024 19:20:26 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t6wFg-0006h2-RU; Fri, 01 Nov 2024 14:20:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t6wFe-0006fs-N3 for guix-patches@gnu.org; Fri, 01 Nov 2024 14:20:02 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t6wFe-0005Kk-EE for guix-patches@gnu.org; Fri, 01 Nov 2024 14:20:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=RnbSWEA2zdn0LRYr1NtFhaXD2xL3RfmGEovbGZWmS9k=; b=sdwD6/LYh6wRRaXsrOiopZa4sHG0AqYNSz7ZvOiYZn5THQ5m3di8sIJpZ/spzSHD0Nd4KPowP7YOb+T14CWlJcocynwH7wdQD90UuZtZfgATP9WtygAWsH8N9AyPR+fqa+G9RXy69m1PUMDQfn0ax1xowx2ohBImqZTcbv8Da3Kg8hsxZEjjM2ZAvLPOBTaFb2fl9gKaW2OgDeb19ZLbqUO0E8CICgSg7Am1EUxgCdIR5neuYNjnFEnmJ1btmrluDoTyns+L3/EJj9m/rd25LRNrZiPGkNHqxlj0P9Bn+wiPCFVuT5VUfWLcWVFnrUqtwVjxReY2PBHbb1QMErRAwA==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t6wFd-0001cZ-Qq for guix-patches@gnu.org; Fri, 01 Nov 2024 14:20:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#74135] [PATCH 1/2] gnu: Improve emacs-popwin definition. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 01 Nov 2024 18:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74135 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Rostislav Svoboda Cc: Andrew Tropin , Katherine Cox-Buday , Liliana Marie Prikler , 74135@debbugs.gnu.org Received: via spool by 74135-submit@debbugs.gnu.org id=B74135.17304852006219 (code B ref 74135); Fri, 01 Nov 2024 18:20:01 +0000 Received: (at 74135) by debbugs.gnu.org; 1 Nov 2024 18:20:00 +0000 Received: from localhost ([127.0.0.1]:51108 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t6wFc-0001cF-8f for submit@debbugs.gnu.org; Fri, 01 Nov 2024 14:20:00 -0400 Received: from msg-1.mailo.com ([213.182.54.11]:40756 helo=mailo.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t6wFZ-0001c7-H7 for 74135@debbugs.gnu.org; Fri, 01 Nov 2024 14:19:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=nicolasgoaziou.fr; s=mailo; t=1730485189; bh=RnbSWEA2zdn0LRYr1NtFhaXD2xL3RfmGEovbGZWmS9k=; h=X-EA-Auth:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding; b=fNFykErHE2YCt0BxFEIy3os33Nj1jEHzDJkGJu2qkli5d25TZRqWLkBr8Wl3I9blU c6X+NlEmbaDsal2HacUKfLzMhSlmqlj1d+i874KZHqoOGlhQsp+gAyHBuK96wXzgTi NxDZSUunKtQjC35nEK7qZ6ggC2Gg7g3XiFN1cBK4= Received: by b221-6.in.mailobj.net [192.168.90.26] with ESMTP via ip-20.mailobj.net [213.182.54.20] Fri, 1 Nov 2024 19:19:49 +0100 (CET) X-EA-Auth: uG8b/FOwD+RH5bVTt0G61I4yHDujErrdvK1HlAstwfANSH1uaXjgaFGxQ0v/Sc/9uLZzRuraRrVg+U0WbF5o0EOVc2zY37JpkkWM/qwUjt4= In-Reply-To: (Rostislav Svoboda's message of "Fri, 1 Nov 2024 18:54:15 +0100") References: <2205123045e70a7cfb11d78405f48586e77df80e.1730382156.git.Rostislav.Svoboda@gmail.com> <87o72zkozl.fsf@nicolasgoaziou.fr> Date: Fri, 01 Nov 2024 19:19:30 +0100 Message-ID: <874j4qlsul.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Nicolas Goaziou X-ACL-Warn: , Nicolas Goaziou via Guix-patches From: Nicolas Goaziou via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: 2.04 X-Spam-Score: 2.04 X-Migadu-Queue-Id: 6F65782CD0 X-Migadu-Scanner: mx12.migadu.com X-TUID: C9Yb90F6XnHl Hello, Rostislav Svoboda writes: >> I disagree with the removal of "#:tests? #f". It is more meaningful than >> simply omitting the keyword. It tells us that the package has tests, but >> they are difficult or even impossible to run. Without the keyword, it >> could as well mean: "I didn't bother to check if there are tests". > > Which is, in fact, the default behavior of the #:tests parameter. By > default, we do not run any tests, so why bother verifying their > existence when they=E2=80=99re unnecessary by default? By default, the `emacs' build system does not run any test, but many packages run them nevertheless. Some people, including me, try to run tests from Emacs packages whenever it is possible. As pointed out, in this situation, "#:tests? #f" with a reason brings some valuable information. I simply suggest to keep that line. >> I have no opinion about the removal of native inputs. > > Including emacs-ert-runner - a package designed for "Emacs projects > tested using ERT" - among native inputs is pointless if no tests are > executed. OTOH, it might help anyone trying to make the tests run someday (not all tests require emacs-ert-runner). But in this package, this may not be possible ultimately, hence "I have no opinion". >> I also think the change to version should go in the second patch. > > In the first patch, I intended to fix the Guix package definition > without updating the package itself. That's why I incremented the > revision number from its default (presumably 0) to 1. The v1.0.2 tag > corresponds to commit 215d6cb509b11c63394a20666565cd9e9b2c2eab. There is nothing to "fix". The first version correctly uses the tag instead of the commit hash. Of course, you can update it in the second patch. The first version change is unnecessary, please keep the second one only. Regards,