From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id MPJkGbkDU2daDwAA62LTzQ:P1 (envelope-from ) for ; Fri, 06 Dec 2024 14:01:29 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id MPJkGbkDU2daDwAA62LTzQ (envelope-from ) for ; Fri, 06 Dec 2024 15:01:29 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b="V/DT6/jT"; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=VmSLqvES; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1733493689; a=rsa-sha256; cv=none; b=ffWmobGMTv1lzLgEFf+xqvNHauwlnfjrLii5KHeP44tiCk+L+Lts2CkSyvOnyvpahiNeKG ou6gvkWAXiF6MMYIkUsb8vghvgFyBd705nS/4FCUSkmJ+GzPgdK9K9p2kQ3gkEWJG0JnFm zuJ5nBI6Bg5ZJ2+0nnGEdWtd1t98SsHM9KC76DMTlB2YoRhYzYsVcNZGmZJzvbvcAjnq+i iJfYGmWMWAhvoseGb6+KcnnBCUVg+r5N905EWTZoGynB343UKpypwzFUz/EB4FbbC1tFzm 7307MnOE0Vquvmotf6T7vcX3K6MYGcZ0yudIe84jMhQWDlhaB/Rpngyf/2lSqw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b="V/DT6/jT"; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=VmSLqvES; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1733493689; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=uib2yUPMpwZ7+8AjWLp+q9i1Gwppw3l+SPCZOKBNf2I=; b=a7lcyZWffgzjUoQyLRVlRNAE/hWUVZTU3yO1APIHK0avBZkvUla6ZyS2ZUClHsFEFiMNEM 2BEii78AQy/czClmDPwBwVFco2FjtPhL4a7ZOkCq85bfUidyKhFUFnk8E/gq4w6LnlbbDW l6/QmBaB5ZT2yJdRTE6ks2DnK+OHGZUCA9kC56UxGd7J1RzoNLNGHjLK6ywemOgQjMA0Sj jtoHALgVGACOSCN66PSjpiR+Mn7KcyYKWy+A1UInM6gu1f7muW7/v7lpONIHy/pWhss/Dy YfpthAzDl67i7axD5ugYdNM9JpjNRy/L3kG3rDyeuyKBnVDirpnlfxLFiziRcQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 32EEB8293D for ; Fri, 06 Dec 2024 15:01:29 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tJYtL-0001kJ-Vi; Fri, 06 Dec 2024 09:01:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tJYtE-0001hg-Lf for guix-patches@gnu.org; Fri, 06 Dec 2024 09:01:06 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tJYtE-0002vH-7j for guix-patches@gnu.org; Fri, 06 Dec 2024 09:01:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=uib2yUPMpwZ7+8AjWLp+q9i1Gwppw3l+SPCZOKBNf2I=; b=V/DT6/jTMPxpWBYKXTBqLqsEuVWsY7Ew4JCx+723blX+VU56B3BEWCH8HrF6UdUU/5gy9j1RMunIJ5+AR9xq89fdezdUP5b0Kb1S6xpDhYN7swiFoIq3E31RPdmVG0MMMYflti6tVpfr+KM1W6hYTQxXmSXZNA4hJArTIrvZwEnU8mXTEaTDABJ87xYQMWO9ijFIB0f1tW1kcFf3PcFCb/B/rzGo052bYMuKdWF5eXfthz8mbzzsmmCKN2gc50pp6PcF8XA9jq2Cj2WnCYpZlI+g1FEUSNdNXbMfTQuIx+B3qjNcvTLZujwVDkPu8zps/CXSpX/2v1z9TV5ZKl5Jew==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tJYtC-0002P6-O8 for guix-patches@gnu.org; Fri, 06 Dec 2024 09:01:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#74542] [PATCH v2 05/16] packages: Factorize =?UTF-8?Q?=E2=80=98all-packages=E2=80=99.?= Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 06 Dec 2024 14:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74542 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Josselin Poiret , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , 74542@debbugs.gnu.org, Christopher Baines Received: via spool by 74542-submit@debbugs.gnu.org id=B74542.17334936609223 (code B ref 74542); Fri, 06 Dec 2024 14:01:02 +0000 Received: (at 74542) by debbugs.gnu.org; 6 Dec 2024 14:01:00 +0000 Received: from localhost ([127.0.0.1]:42418 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tJYt9-0002Og-3l for submit@debbugs.gnu.org; Fri, 06 Dec 2024 09:00:59 -0500 Received: from mail-qk1-f177.google.com ([209.85.222.177]:42187) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tJYt0-0002OG-UG for 74542@debbugs.gnu.org; Fri, 06 Dec 2024 09:00:56 -0500 Received: by mail-qk1-f177.google.com with SMTP id af79cd13be357-7b66ea49407so185255785a.0 for <74542@debbugs.gnu.org>; Fri, 06 Dec 2024 06:00:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733493585; x=1734098385; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uib2yUPMpwZ7+8AjWLp+q9i1Gwppw3l+SPCZOKBNf2I=; b=VmSLqvES0gfmXHxBHF3if7s33Lpbr9rpizeQNLRgFbCLNtcX5JdG6FKqquneRAKvI2 +p52vYYNAjqPAnUG0wkA0F69nm1mpLx4j5ZCEBJ64e36DJvlb8Bmc/iJYt9+88m34o8d /OxsGuUp1LusMzo8NJn6GLURyt//KAnjZovrKuR5GPiJsgI6MXyKYW6KLfa76j1NlLHA YV/aFJrvVE9YD1qXWb1dzstph2oI/d3p+TgzIh+8E1Fl2xBxGoaiYig1ZLYQXm1rn7P4 OtNYx1GDClMTU30bs1ZWfvonO6YOEAkUUUPBlcpU+tq1S+azdjttzxyxN8XRjsFhH5vY gaLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733493585; x=1734098385; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=uib2yUPMpwZ7+8AjWLp+q9i1Gwppw3l+SPCZOKBNf2I=; b=XBBqp0cROnUi/AY+eke2Cd/Cs1iZJno8EGfWLAh47dbITGQ2rJSfvAHkqd77s8TM4M PBeXzCI/D7th8qL+R5JnlFU0JAwfd4dqBQZdxbJUOCq2M5f0nzA3xLJPJ8+0KIC/UFLH 2RQ6WKJ6LRyTQw/n/61mDwUzqZ0Of7sCjQiCW0cvOGq+3zXHVDQrhkijTySx9MC4L9XH nPcVTrdV9TJcENCt1ZFmdwgC2BdR0SswdscxZZKNiNMtEb30pnx+0cEWiMNCIxzIiuvD 0P6GNvHxG1B0q4cIciXzaiI/9jRzSVm/5w+Mb2MsMlBanHZIGuz8vCSRcNWvLsS+Jq2K P/vA== X-Forwarded-Encrypted: i=1; AJvYcCW04RXrALYfm+Q0dsNnnZ7747BnzAU/LmS8jXM6ECyHfO7g0KP8syIbHtzJ9hB3ze3HnVTeOA==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyhrUXlxL2ZrS/H7PUbPfTbd01ozeSoS8G4i+6sA5KyBx/AhvuJ pT7rD4j6OWNjwsv5MdNQ17NxrF6r/FrxQ5e6z6E7LJwkDgr+tISV X-Gm-Gg: ASbGncvXlsOCths3v45n2q5QLFgNo+MwwlT0eAXQ2w5ZlqvawflAefiDqokTutsb3LN kaq2Eh91lMUoJViJW6jfCm8mB1Ap86v0r00kbXY0r7jCvzYEEWkP+A6+13lGkWxBSRzi7q2VeW4 z5t04p52/60n+YnqordMzPr8Xa5Y3Yy/gzA/fKNrdC2J7JOMbFM1tdINsn4UAuYSv3DaPLIGVJu gkTtqhWduUov7pbV7R4zX08YfhvGHDn8feMYE6T0Q3XwIo1ODdvi+ernfV/q/gWXcOsPJs= X-Google-Smtp-Source: AGHT+IHOsmutyijzBalNXDHdBKlY0p/UIfpO8RKuUiD1Agu8FEjJAuKet0ydhYQMlJOfSmFyrjn0cw== X-Received: by 2002:a05:620a:1a90:b0:7a9:b82e:723a with SMTP id af79cd13be357-7b6bc9a7a54mr365020085a.31.1733493585199; Fri, 06 Dec 2024 05:59:45 -0800 (PST) Received: from terra (vps-6234970c.vps.ovh.ca. [51.222.13.224]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7b6b5a51868sm174582785a.2.2024.12.06.05.59.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Dec 2024 05:59:44 -0800 (PST) From: Maxim Cournoyer In-Reply-To: <874j3ns6ku.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Sun, 01 Dec 2024 17:37:05 +0100") References: <8bcbbc485aa264424b29ea873fee3e2b6aa30008.1732872498.git.ludo@gnu.org> <87jzcmhz0m.fsf@gmail.com> <874j3ns6ku.fsf@gnu.org> Date: Fri, 06 Dec 2024 22:59:34 +0900 Message-ID: <874j3glxo9.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -3.15 X-Spam-Score: -3.15 X-Migadu-Queue-Id: 32EEB8293D X-Migadu-Scanner: mx12.migadu.com X-TUID: 5wpFd96U4DEO Hi Ludovic, Ludovic Court=C3=A8s writes: > Maxim Cournoyer skribis: > >>> @@ -253,6 +254,23 @@ (define* (fold-packages proc init >>> init >>> modules)) >>>=20=20 >>> +(define all-packages >>> + (mlambda () >>> + "Return the list of all public packages, including replacements an= d hidden >>> +packages, excluding superseded packages." >> >> Reading the above doc made me question; are replacements always supposed >> to be made public? I typically would leave them private to avoid >> cluttering the CLI with duplicate packages. > > Replacements are always reachable via the =E2=80=98replacement=E2=80=99 f= ield, whether > they=E2=80=99re public or not. > > If they=E2=80=99re public, they=E2=80=99re also visible from the user int= erface, which > is probably nicer. Other than that, it doesn=E2=80=99t make a big differ= ence. I see, thanks for explaining. Assuming they have the same name, the interface for 'guix search $name' would now should two versions available, while in theory if you 'guix shell $name@older-version' you'd get the graft anyway, which is at the newer (fixed) version. And, 'guix build $name', although the CLI would say version is Y, would actually show version X in the store, which could be confusing in some cases. Both have good and bad points... I'm not too sure which one is preferable. Probably, as you said, seeing the newest version which is used on the CLI is preferable to seeing the same version match in the package store file name, so I think I'll make replacements public from now on... another thing to document some day! --=20 Thanks, Maxim