unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: 74958@debbugs.gnu.org
Subject: [bug#74958] [PATCH rust-team 1/5] build/cargo.scm: Remove '--release' from default cargo-test-flags.
Date: Thu, 19 Dec 2024 21:50:24 +0900	[thread overview]
Message-ID: <874j2zltv3.fsf@gmail.com> (raw)
In-Reply-To: <Z2PUole1d4bDuBcL@3900XT> (Efraim Flashner's message of "Thu, 19 Dec 2024 10:09:06 +0200")

Hi,

Efraim Flashner <efraim@flashner.co.il> writes:

> IIRC we chose to use '--release' for cargo-test-flags to minimize the
> amount of rebuilding we did with each package.  If the tests are
> expected to be run not in release mode then I guess we should change it.

I see.  I guess it's worth it, I expect it'll reduce the occurrence of
the dreaded 'why does this fail in Guix and not in upstream's CI?'
question.

> I'll apply the patch to rust-team and then go through and see about
> removing the cargo-test-flags from various packages.

Sounds good, thanks for your reactivity!

-- 
Thanks,
Maxim




  reply	other threads:[~2024-12-19 12:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-19  1:43 [bug#74958] [PATCH rust-team 0/5] build/cargo.scm: Remove '--release' from default cargo-test-flags Maxim Cournoyer
2024-12-19  1:46 ` [bug#74958] [PATCH rust-team 1/5] " Maxim Cournoyer
2024-12-19  8:09   ` Efraim Flashner
2024-12-19 12:50     ` Maxim Cournoyer [this message]
2024-12-19 12:52   ` bug#74958: " Efraim Flashner
2024-12-19  1:46 ` [bug#74958] [PATCH rust-team 2/5] gnu: rust-zerocopy-0.8: Reinstate all tests Maxim Cournoyer
2024-12-19  1:46 ` [bug#74958] [PATCH rust-team 3/5] gnu: rust-libc-0.2: Update to 0.2.168 Maxim Cournoyer
2024-12-19  1:46 ` [bug#74958] [PATCH rust-team 4/5] gnu: rust-zerocopy-0.8: Update to 0.8.13 Maxim Cournoyer
2024-12-19  1:46 ` [bug#74958] [PATCH rust-team 5/5] gnu: rust-zerocopy-derive-0.8: " Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874j2zltv3.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=74958@debbugs.gnu.org \
    --cc=efraim@flashner.co.il \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).