From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id MOrnNJU2bWeaQgAA62LTzQ:P1 (envelope-from ) for ; Thu, 26 Dec 2024 10:57:26 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id MOrnNJU2bWeaQgAA62LTzQ (envelope-from ) for ; Thu, 26 Dec 2024 11:57:25 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=X2jKoaJc; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=F4FH7bWR; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1735210645; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=HB7+zRJORCoY1MIO3v/uKFBzfI+4kJi8WBweit7OsLc=; b=fYC8YoRS2bv2H/BB06sKVkv36KER5gz4ei/lh3esOWLybs4LAHQT0uEIgiBTfXV9OXMNQv UPbnvbx+f5UVZ0Ay/Xc7fLs+hsA4yRn1C1l+jq7uUNFN2/bZRh45rBlzl7HHGvIRN4Hps1 5xwq44ADjBvgpqryEK+oJAkT2aeRSNRyTZjRbQie9oNrpNrxI4gRJ0KQL/0AEHADf9iNEA J5PMZSCKA9myhbsPboUN7x2O5SU8PjxTzQO21WMGuvL67+rwqPEYmAbQXLWVMwjv0u9Vge pTFoLw+T4Wp1x24sCIBuCuzoUy5GIDB40yMjEE+MfvJL6s40f8AgsK6BnAXwvQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=X2jKoaJc; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=F4FH7bWR; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1735210645; a=rsa-sha256; cv=none; b=PYulhKz6jyqXCiIz3lKjEgh3SsPf1LgzvNLvAsq/ZfhIXzqAmKaf9OUXjGqQU9SJVunVmm 0IdRRTFN62angXwNzYaprkG2VPWgr2Qr92FhmgLN0UEpMOKixc9f1fSaZbz6jOXz2sRxZa oQmRGOEa/KrngiKl2d44AED0EMJqMdcnMM3FZJLLt5BYsKh/dlxPD/6M0KuqASxsaeVSqI ZgBJPhaUa+UshG0iw/K4AFPynoqLKrSqmIT40lncoUAWivO9C68qMWQW1jWePeT5cB0C21 JfRQH+ZimGkPTLcjku2qWqqXjkFwV6UBJ0AdRSH7/vo55hjvyv9ObmPqdIqG/A== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AC2B124EC7 for ; Thu, 26 Dec 2024 11:57:25 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tQlY9-0003Qx-5Z; Thu, 26 Dec 2024 05:57:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tQlY7-0003QS-Nt for guix-patches@gnu.org; Thu, 26 Dec 2024 05:57:03 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tQlY7-000096-9U for guix-patches@gnu.org; Thu, 26 Dec 2024 05:57:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=HB7+zRJORCoY1MIO3v/uKFBzfI+4kJi8WBweit7OsLc=; b=X2jKoaJcDa78M0RP7JUybGxmRWVfvX/Z1DSCOBF5NUlZrdg7NkV3ZTyrXFRLWUMmKSQjCHjX7Nvd4ia5N80wYt99Us6acLXTeGcIj8OXM0Lq8hWWn2v92LmD06Jfx+DsqCRXfLC7IJxhokBV1ElTQJR/+krKHw38BAl6rBsh0Tyvvbdvvs7mSzf5E0WVEJ3aKIWp1MeccDonLpDFzaeDgDv60fyVFOzBU1e6I5XtK+zxQjnsAOmyNrqIi3T+Fh+I+4gUqzSCXsLopYCZp5gnGvVRjuUkZDMMf27FfeA+qJWgvkJ7up5xnrnaFtF/xkecPHf5T0SOVbvKAmUyHO6yEQ==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tQlY7-0007ZC-4E for guix-patches@gnu.org; Thu, 26 Dec 2024 05:57:03 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#74962] [PATCH v3 3/5] etc/guix-install.sh: Fix quoting and other issues. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 26 Dec 2024 10:57:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74962 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: Mathieu Othacehe , Josselin Poiret , 74962@debbugs.gnu.org, Janneke Nieuwenhuizen Received: via spool by 74962-submit@debbugs.gnu.org id=B74962.173521058629034 (code B ref 74962); Thu, 26 Dec 2024 10:57:03 +0000 Received: (at 74962) by debbugs.gnu.org; 26 Dec 2024 10:56:26 +0000 Received: from localhost ([127.0.0.1]:40235 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tQlXW-0007YE-75 for submit@debbugs.gnu.org; Thu, 26 Dec 2024 05:56:26 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53710) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tQlXT-0007Y0-QA for 74962@debbugs.gnu.org; Thu, 26 Dec 2024 05:56:24 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tQlXO-00007a-H7; Thu, 26 Dec 2024 05:56:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=HB7+zRJORCoY1MIO3v/uKFBzfI+4kJi8WBweit7OsLc=; b=F4FH7bWRvgDbqW7SrtbU n/RQZdbhqE7soVsUawHDjZYg20QhlYb7nQbs0hYTqacGeRENsw2opmvsk8b26kyJcMxHXs/MHq4Ba Jvq9gHQ6fXGfoa4YGik6xtbgG43v+EwbsOoot31+rLPFKIHk3SPTatoC1vCw6aAAozdIvOyLfkS+A h/+JxOtATGRGO6fcuqxgKHb92ivkOSwqPC+6vxlT3EuugyhR2MgG/uhJ5f24AbLEG/miXGCn9e0Ia sXXrkQypsWN6XvKMIC0NupFcolJH+kPAObQ6DAZKi2J6IC9wJHMAMZtSqEsEkhLmr0cvz3LFLIUS1 IpaWJX05luZRiQ==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <093604124092d3b024127068cbbeff3f9aa62d76.1734594333.git.maxim.cournoyer@gmail.com> (Maxim Cournoyer's message of "Thu, 19 Dec 2024 16:45:31 +0900") References: <3d0ccfc5f28f48b0a4e513e4ebfd3018c85b4407.1734594333.git.maxim.cournoyer@gmail.com> <093604124092d3b024127068cbbeff3f9aa62d76.1734594333.git.maxim.cournoyer@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Sextidi 6 =?UTF-8?Q?Niv=C3=B4se?= an 233 de la =?UTF-8?Q?R=C3=A9volution,?= jour de la Lave X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 26 Dec 2024 11:56:15 +0100 Message-ID: <874j2qzp9s.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -0.21 X-Spam-Score: -0.21 X-Migadu-Queue-Id: AC2B124EC7 X-TUID: GcPv9DXVN50n Maxim Cournoyer skribis: > This change fixes most issues reported by the 'shellcheck' command. > > * etc/guix-install.sh (add_init_sys_require): Use -n instead of ! -z. > (sys_create_build_user): Quote variable expansion. > (sys_delete_build_user): Likewise. > (sys_create_shell_completion): Likewise. > (sys_delete_user_profiles): Likewise. > (sys_delete_guix_daemon): Explicitly access first array item. > (sys_create_store): Update shellcheck code to ignore. > (SYSV_INIT_REQUIRE): Ignore unused warning. > (sys_customize_bashrc): Ignore warnings due to using variables inside a > literal. > (main): Replace $@ with $* inside string. > > Change-Id: Ia88509b461b3844f2dd5abf9fb21a5b2bbb8a1e1 LGTM.