unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Ian Eure <ian@retrospec.tv>
To: 75172@debbugs.gnu.org
Subject: [bug#75172] [PATCH] gnu: fennel: Update to 1.5.1.
Date: Mon, 30 Dec 2024 11:50:31 -0800	[thread overview]
Message-ID: <874j2lvtko.fsf@retrospec.tv> (raw)
In-Reply-To: <20cc82b3d64dd9d2355234df2271ca919a1905e7.1735464449.git.yovan@gorski.stream>

Hi Yovan,

I think it’d be a better approach to remove test/irc.lua from the 
test suite entirely, rather than patch test/irc.lua itself.  I 
believe removing the second argument to t.run in test/init.lua 
will accomplish this.

I’d also suggest to upstream that there should be a clearer 
mechanism to enable/disable IRC reporting, perhaps via an 
environment variable.

  -- Ian




  parent reply	other threads:[~2024-12-30 19:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-29  9:52 [bug#75172] [PATCH] gnu: fennel: Update to 1.5.1 Yovan Naumovski
2024-12-29 18:03 ` [bug#75172] QA review for 75172 Noé Lopez via Guix-patches via
2024-12-30  9:18 ` [bug#75172] [PATCH] gnu: fennel: Update to 1.5.1 Yovan Naumovski
2024-12-30 19:50 ` Ian Eure [this message]
2024-12-30 21:11 ` Yovan Naumovski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874j2lvtko.fsf@retrospec.tv \
    --to=ian@retrospec.tv \
    --cc=75172@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).