From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47727)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ctrg9-0001xD-Il
	for guix-patches@gnu.org; Fri, 31 Mar 2017 04:13:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ctrg6-0005xM-Co
	for guix-patches@gnu.org; Fri, 31 Mar 2017 04:13:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:55337)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1ctrg6-0005xB-9Y
	for guix-patches@gnu.org; Fri, 31 Mar 2017 04:13:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ctrg5-0003Zt-VQ
	for guix-patches@gnu.org; Fri, 31 Mar 2017 04:13:01 -0400
Subject: bug#26314: [PATCH] substitute: Send
	=?UTF-8?Q?=E2=80=98User-Agent=E2=80=99?= header.
Resent-Message-ID: <handler.26314.B26314.149094796813730@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20170330184439.8896-1-me@tobias.gr>
Date: Fri, 31 Mar 2017 10:12:35 +0200
In-Reply-To: <20170330184439.8896-1-me@tobias.gr> (Tobias Geerinckx-Rice's
	message of "Thu, 30 Mar 2017 20:44:39 +0200")
Message-ID: <8737dt7tl8.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Tobias Geerinckx-Rice <me@tobias.gr>
Cc: 26314@debbugs.gnu.org

Heya!

Tobias Geerinckx-Rice <me@tobias.gr> skribis:

> * guix/scripts/substitute.scm (narinfo-request): Pass =E2=80=98User-Agent=
=E2=80=99 #:headers
> to =E2=80=98build-request=E2=80=99.
> ---
>
> Guix,
>
> This makes the User-Agent sent to substitute servers consistent.
>
> Currently, =E2=80=98http-fetch=E2=80=99 (used to download .nars) sets it =
to =E2=80=98GNU Guile=E2=80=99,
> while http-multiple-get (used to download .narinfos) leaves it empty.

Sounds good to me.

Did the lack of =E2=80=98User-Agent=E2=80=99 cause you any problems?

> (This brings the number of scattered '"GNU Guile"' user-agent settings
>  in Guix to 5, but moving it to %guix-default-http-user-agent does not
>  strike me as a meaningful improvement.)

Agreed.  :-)

Go for it!

Ludo=E2=80=99.