From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47501) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d7kQI-0006Er-3X for guix-patches@gnu.org; Mon, 08 May 2017 11:18:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d7kQD-0001pb-Vo for guix-patches@gnu.org; Mon, 08 May 2017 11:18:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:36333) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d7kQD-0001pV-Rg for guix-patches@gnu.org; Mon, 08 May 2017 11:18:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d7kQD-0000jY-Ln for guix-patches@gnu.org; Mon, 08 May 2017 11:18:01 -0400 Subject: bug#26713: [PATCH] gnu: Move netsurf to web-browsers.scm. Resent-Message-ID: From: Kei Kebreau References: <20170429220942.26880-1-kei@openmailbox.org> <20170430191306.GA26169@jasmine> <87shkpoehf.fsf@openmailbox.org> <87o9vdo805.fsf@openmailbox.org> <87lgqaghsh.fsf@openmailbox.org> <87pofmypni.fsf@fastmail.com> <87h90ygd0j.fsf@openmailbox.org> <87k25tzy07.fsf@fastmail.com> Date: Mon, 08 May 2017 11:17:39 -0400 In-Reply-To: <87k25tzy07.fsf@fastmail.com> (Marius Bakke's message of "Sat, 06 May 2017 19:38:32 +0200") Message-ID: <8737cfxtrg.fsf@openmailbox.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Marius Bakke Cc: 26713@debbugs.gnu.org --=-=-= Content-Type: text/plain Marius Bakke writes: > Kei Kebreau writes: > >> Marius Bakke writes: >>> >>> There are other things using netsurf-build-system as well, so I would >>> just leave it for now. >> >> I intend to copy, not move, netsurf-build-system into web-browsers.scm >> so that NetSurf can build. > > There are many other packages in web.scm using netsurf-build-system. IMO > it would be "cleaner" to have all that in a "netsurf" module, but I'm not > sure if it's worth the hassle. > > The current patch duplicates netsurf-build-system, which means we have > to maintain it two different places. I think we should avoid that. > Another option is moving all of the "NetSurf components" into web-browsers.scm. None of them are depended on by anything but NetSurf and each other. >>> Also some copyright information is missing in the patch. >> >> What information in particular? > > Netsurf was added in 2016, but web-browsers.scm only includes 2017. Okay, this was fixed in the patch I just submitted. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJZEIwTAAoJEOal7jwZRnoNyssP/iW6pVsvL2Teec1W1QarDsKS 2kwXNu4V2xER0h0NkpZvR8d+ptyazLZjJRazqoJJg8Cov+dTQBSDnElZnvln2HIv D4LWUjvaRqg4PngnvTs84HjamsQtEzMWC4+LVqZH+acXgBCD5TDXhOinPQxuFJ/6 R3pA/FNwB4MzJhKTSbyZ06TTzeuvt1ytUQIvN4sYuBLyAx9sKQbKe/8Rag+uSx62 qk65M80vSxGEmUQJA84ErQNRNe/ftS/XLsMh+vzu9/112Gvs6o/WOKi+gsZCieqD YgFZgFJ9Q6sm1GFptQeVIvlCE8oDcj09qntKqQHxkSdZJXi8cfAspzRMTnyTqVnH zMxP7IuiYlDUJ8x4vxO/Gt/Q0ZQq+M2/RCV1apdFJR9a3KHirT3gEGg+ZYqVS28L mmAXkneCBtXDoFe52OfsTF/juPysicUL27lgZi4oTrzQX0/fMn+1etfKN2ZbRrd/ xTJWJO+2lZwR4WSb390HYPZbZICLMQx5SK8WdsaZ34Qw7iIeZ8Riq7fDBLFjZKBl MEe3Y9Av0c2bq20jvblpI4Fq1s+oQ2UBKOleGKvydNgL+XW29wPYjuzTg2eYrFxi gZO3u3qV45Ih7XK+TsZ4rpu+bxvmUf5kl5Zh3MbinZOrErjdHhkUNz/l7/hC1Yyd DrK7+y5AIrHQ3ygyehqn =dNSQ -----END PGP SIGNATURE----- --=-=-=--