From: Kei Kebreau <kei@openmailbox.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 26713@debbugs.gnu.org
Subject: bug#26713: [PATCH] gnu: Move netsurf to web-browsers.scm.
Date: Mon, 08 May 2017 11:17:39 -0400 [thread overview]
Message-ID: <8737cfxtrg.fsf@openmailbox.org> (raw)
In-Reply-To: <87k25tzy07.fsf@fastmail.com> (Marius Bakke's message of "Sat, 06 May 2017 19:38:32 +0200")
[-- Attachment #1: Type: text/plain, Size: 1055 bytes --]
Marius Bakke <mbakke@fastmail.com> writes:
> Kei Kebreau <kei@openmailbox.org> writes:
>
>> Marius Bakke <mbakke@fastmail.com> writes:
>>>
>>> There are other things using netsurf-build-system as well, so I would
>>> just leave it for now.
>>
>> I intend to copy, not move, netsurf-build-system into web-browsers.scm
>> so that NetSurf can build.
>
> There are many other packages in web.scm using netsurf-build-system. IMO
> it would be "cleaner" to have all that in a "netsurf" module, but I'm not
> sure if it's worth the hassle.
>
> The current patch duplicates netsurf-build-system, which means we have
> to maintain it two different places. I think we should avoid that.
>
Another option is moving all of the "NetSurf components" into
web-browsers.scm. None of them are depended on by anything but NetSurf
and each other.
>>> Also some copyright information is missing in the patch.
>>
>> What information in particular?
>
> Netsurf was added in 2016, but web-browsers.scm only includes 2017.
Okay, this was fixed in the patch I just submitted.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
prev parent reply other threads:[~2017-05-08 15:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-29 22:09 bug#26713: [PATCH] gnu: Move netsurf to web-browsers.scm Kei Kebreau
2017-04-30 15:31 ` Christopher Allan Webber
2017-04-30 18:12 ` Kei Kebreau
2017-04-30 19:13 ` Leo Famulari
2017-04-30 19:57 ` Kei Kebreau
2017-04-30 22:17 ` Kei Kebreau
2017-05-06 14:51 ` Kei Kebreau
2017-05-06 15:24 ` Marius Bakke
2017-05-06 16:34 ` Kei Kebreau
2017-05-06 17:38 ` Marius Bakke
2017-05-08 15:17 ` Kei Kebreau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8737cfxtrg.fsf@openmailbox.org \
--to=kei@openmailbox.org \
--cc=26713@debbugs.gnu.org \
--cc=mbakke@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).