From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38853)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dY70B-0006UU-57
	for guix-patches@gnu.org; Thu, 20 Jul 2017 04:40:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dY706-0001yp-9n
	for guix-patches@gnu.org; Thu, 20 Jul 2017 04:40:07 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:45843)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dY706-0001yO-5U
	for guix-patches@gnu.org; Thu, 20 Jul 2017 04:40:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dY705-00080f-T8
	for guix-patches@gnu.org; Thu, 20 Jul 2017 04:40:01 -0400
Subject: [bug#27695] [PATCH 1/2] bootloader: Add grub-hybrid-bootloader.
Resent-Message-ID: <handler.27695.B27695.150053996730742@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20170714185954.4381-1-dannym@scratchpost.org>
	<20170714190157.4529-1-dannym@scratchpost.org>
Date: Thu, 20 Jul 2017 10:39:14 +0200
In-Reply-To: <20170714190157.4529-1-dannym@scratchpost.org> (Danny
	Milosavljevic's message of "Fri, 14 Jul 2017 21:01:56 +0200")
Message-ID: <87379rzeml.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 27695@debbugs.gnu.org

Hi,

Danny Milosavljevic <dannym@scratchpost.org> skribis:

> * gnu/packages/bootloaders.scm (grub-hybrid): New variable.
> * gnu/bootloader/grub.scm (grub-hybrid-bootloader): New variable.

[...]

> +(define-public grub-hybrid
> +  (package
> +    (inherit grub-efi)
> +    (name "grub-hybrid")
> +    (synopsis "GRand Unified Boot loader (Hybrid version)")
                                             ^
Lower-case please.

> +    (native-inputs
> +     `(("grub" ,grub)
> +       ,@(package-native-inputs grub-efi)))
> +    (arguments
> +     (substitute-keyword-arguments (package-arguments grub-efi)
> +      ((#:phases phases)
> +      `(modify-phases ,phases
> +         (add-after 'install 'install-non-efi
> +           (lambda* (#:key inputs outputs #:allow-other-keys)
> +             (copy-recursively (string-append (assoc-ref inputs "grub")
> +                                              "/lib/grub/i386-pc")
> +                               (string-append (assoc-ref outputs "out")
> +                                              "/lib/grub/i386-pc"))
> +             #t))))))))

Is it really all it takes to make a GRUB that can do both BIOS and UEFI?
I wonder why GRUB upstream doesn=E2=80=99t do it by default.  Do you think =
we
should discuss it with them?

If that works, we might just as well make it the new =E2=80=9Cgrub=E2=80=9D=
 package and
remove =E2=80=9Cgrub-efi=E2=80=9D.  Or is there any downside?

Thanks,
Ludo=E2=80=99.