[bug#27695] [PATCH 1/2] bootloader: Add grub-hybrid-bootloader.

[ludo@gnu.org (Ludovic Courtès)]

Hi,

Danny Milosavljevic <dannym@scratchpost.org> skribis:

> * gnu/packages/bootloaders.scm (grub-hybrid): New variable.
> * gnu/bootloader/grub.scm (grub-hybrid-bootloader): New variable.

[...]

> +(define-public grub-hybrid
> +  (package
> +    (inherit grub-efi)
> +    (name "grub-hybrid")
> +    (synopsis "GRand Unified Boot loader (Hybrid version)")
                                             ^
Lower-case please.

> +    (native-inputs
> +     `(("grub" ,grub)
> +       ,@(package-native-inputs grub-efi)))
> +    (arguments
> +     (substitute-keyword-arguments (package-arguments grub-efi)
> +      ((#:phases phases)
> +      `(modify-phases ,phases
> +         (add-after 'install 'install-non-efi
> +           (lambda* (#:key inputs outputs #:allow-other-keys)
> +             (copy-recursively (string-append (assoc-ref inputs "grub")
> +                                              "/lib/grub/i386-pc")
> +                               (string-append (assoc-ref outputs "out")
> +                                              "/lib/grub/i386-pc"))
> +             #t))))))))

Is it really all it takes to make a GRUB that can do both BIOS and UEFI?
I wonder why GRUB upstream doesn’t do it by default.  Do you think we
should discuss it with them?

If that works, we might just as well make it the new “grub” package and
remove “grub-efi”.  Or is there any downside?

Thanks,
Ludo’.