From: Marius Bakke <mbakke@fastmail.com>
To: "Björn Höfling" <bjoern.hoefling@bjoernhoefling.de>,
27774@debbugs.gnu.org
Subject: [bug#27774] [PATCH] gnu: add libgeotiff
Date: Sat, 22 Jul 2017 14:46:24 +0200 [thread overview]
Message-ID: <87379o63mn.fsf@fastmail.com> (raw)
In-Reply-To: <20170720175018.49ec09ac@alma-ubu>
[-- Attachment #1: Type: text/plain, Size: 2334 bytes --]
Hi Björn!
Björn Höfling <bjoern.hoefling@bjoernhoefling.de> writes:
> From 4e96405382258d0aa3a1760ac77dd0ac72706786 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Bj=C3=B6rn=20H=C3=B6fling?=
> <bjoern.hoefling@bjoernhoefling.de>
> Date: Tue, 24 Jan 2017 09:00:07 +0100
> Subject: [PATCH] gnu: add libgeotiff
>
> * gnu/packages/geo.scm (libgeotiff): New variable.
[...]
> +(define-public libgeotiff
> + (package
> + (name "libgeotiff")
> + (version "1.4.2")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append "http://download.osgeo.org/geotiff/libgeotiff/"
> + "libgeotiff-"
> + version ".tar.gz"))
> + (sha256
> + (base32
> + "0vjy3bwfhljjx66p9w999i4mdhsf7vjshx29yc3pn5livf5091xd"))))
> + (build-system gnu-build-system)
> + (arguments
> + `(#:configure-flags
> + `( ,(string-append "--with-zlib")
> + ,(string-append "--with-jpeg")
> + ,(string-append "--with-libtiff="
> + (assoc-ref %build-inputs "libtiff")))
I think this can be reduced to...
#:configure-flags
(list "--with-zlib" "--with-jpeg"
(string-append "--with-libtiff" (assoc-ref ....)))
> + #:phases
> + (modify-phases %standard-phases
> + (add-after
> + 'unpack 'delete-nonfree-files
> + (lambda _
> + ;; Remove .csv-files, distributed from
> + ;; EPSG under a restricted license.
> + ;; See LICENSE.txt for full license text.
> + (for-each delete-file (find-files "." "\\.csv$"))
> + ;; Now that we remove the csv-files, we need to modify the Makefile:
> + (substitute* "Makefile.in"
> + (("all-am: Makefile \\$\\(LTLIBRARIES\\) \\$\\(DATA\\) \\$\\(HEADERS\\) geo_config.h")
> + "all-am: Makefile $(LTLIBRARIES) $(HEADERS) geo_config.h")
> + (("install-data-am: install-dist_csvDATA install-includeHEADERS")
> + "install-data-am: install-includeHEADERS"))
> + #t)))))
Thanks for finding this. Can you move this section to a 'snippet'
instead? Otherwise these restricted files will show up in `guix build -S
libgeotiff`, which we can not allow.
The rest LGTM!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2017-07-22 12:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-20 15:50 [bug#27774] [PATCH] gnu: add libgeotiff Björn Höfling
2017-07-22 12:46 ` Marius Bakke [this message]
2017-07-22 13:48 ` Arun Isaac
2017-07-23 11:22 ` Björn Höfling
[not found] ` <0c9f175f.AEQANc_cQw0AAAAAAAAAAAPYhrgAAAACwQwAAAAAAAW9WABZc1em@mailjet.com>
2017-07-23 11:27 ` Björn Höfling
2017-07-23 15:36 ` Arun Isaac
2017-09-08 15:53 ` Ludovic Courtès
2017-09-13 6:55 ` Björn Höfling
2017-10-18 21:20 ` Ricardo Wurmus
2017-07-25 6:58 ` Arun Isaac
2018-01-03 16:55 ` [bug#27774] [PATCH 0/1] Add libgeotiff Arun Isaac
2018-01-03 16:56 ` [bug#27774] [PATCH 1/1] gnu: " Arun Isaac
2018-01-27 20:07 ` Björn Höfling
2018-01-03 18:24 ` [bug#27774] [PATCH 0/1] " Leo Famulari
2018-01-04 6:55 ` bug#27774: " Arun Isaac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87379o63mn.fsf@fastmail.com \
--to=mbakke@fastmail.com \
--cc=27774@debbugs.gnu.org \
--cc=bjoern.hoefling@bjoernhoefling.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).