From: Oleg Pykhalov <go.wigust@gmail.com>
To: Alex Kost <alezost@gmail.com>
Cc: 28381@debbugs.gnu.org
Subject: [bug#28381] [PATCH] gnu: emacs-skewer-mode: Install html and js files.
Date: Sun, 17 Sep 2017 12:15:18 +0300 [thread overview]
Message-ID: <87377ladp5.fsf@gmail.com> (raw)
In-Reply-To: <87bmmjsk4j.fsf@gmail.com> (Alex Kost's message of "Sat, 09 Sep 2017 23:16:28 +0300")
[-- Attachment #1: Type: text/plain, Size: 1919 bytes --]
Hello Alex,
Alex Kost <alezost@gmail.com> writes:
> Oleg Pykhalov (2017-09-07 15:06 +0300) wrote:
>
>>>>From 1cc40f4a0088cbed1ae9f6ca0efdf89a52bf01a5 Mon Sep 17 00:00:00 2001
>> From: Oleg Pykhalov <go.wigust@gmail.com>
>> Date: Thu, 7 Sep 2017 15:03:31 +0300
>> Subject: [PATCH] gnu: emacs-skewer-mode: Install html and js files.
>>
>> * gnu/packages/emacs.scm (emacs-skewer-mode): Install html and js files.
>> ---
>> gnu/packages/emacs.scm | 15 +++++++++++++++
>> 1 file changed, 15 insertions(+)
>>
>> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
>> index 9c0f9bc89..a7ec0b146 100644
>> --- a/gnu/packages/emacs.scm
>> +++ b/gnu/packages/emacs.scm
>> @@ -1967,6 +1967,21 @@ serve files and directory listings.")
>> (propagated-inputs
>> `(("emacs-simple-httpd" ,emacs-simple-httpd)
>> ("emacs-js2-mode" ,emacs-js2-mode)))
>> + (arguments
>> + `(#:phases
>> + (modify-phases %standard-phases
>> + (add-after 'install 'install-html-js
>> + (lambda* (#:key outputs #:allow-other-keys)
>> + (let ((skewer-mode (string-append (assoc-ref outputs "out")
>> + "/share/emacs/site-lisp/guix.d"
>> + "/skewer-mode-"
>> + ,version)))
>> + (for-each (lambda (file)
>> + (install-file file skewer-mode))
>> + '("example.html"
>> + "skewer-everything.user.js"
>> + "skewer.js")))
>> + #t)))))
>
> I think it would be easier to use '#:include' instead of this phase,
> like this:
>
> (arguments '(#:include '("\\.el$" "\\.js$" "\\.html$")))
>
> What do you think? If it is OK for you, could you please send an
> updated patch?
Sure, it's better. Thanks for great suggestion.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-emacs-skewer-mode-Include-html-and-js-files.patch --]
[-- Type: text/x-patch, Size: 907 bytes --]
From 595a0e662d9e18f366870497555dee77ea22dae2 Mon Sep 17 00:00:00 2001
From: Oleg Pykhalov <go.wigust@gmail.com>
Date: Sun, 17 Sep 2017 12:08:11 +0300
Subject: [PATCH] gnu: emacs-skewer-mode: Include html and js files.
* gnu/packages/emacs.scm (emacs-skewer-mode): Include html and js files.
---
gnu/packages/emacs.scm | 3 +++
1 file changed, 3 insertions(+)
diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 2b82ced4e..5839f0faf 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -1979,6 +1979,9 @@ serve files and directory listings.")
(propagated-inputs
`(("emacs-simple-httpd" ,emacs-simple-httpd)
("emacs-js2-mode" ,emacs-js2-mode)))
+ (arguments
+ '(#:include
+ '("\\.el$" "\\.js$" "\\.html$")))
(home-page "https://github.com/skeeto/skewer-mode")
(synopsis "Live web development in Emacs")
(description
--
2.14.1
next prev parent reply other threads:[~2017-09-17 9:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-07 12:06 [bug#28381] [PATCH] gnu: emacs-skewer-mode: Install html and js files Oleg Pykhalov
2017-09-09 20:16 ` Alex Kost
2017-09-17 9:15 ` Oleg Pykhalov [this message]
2017-09-19 16:48 ` bug#28381: " Alex Kost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87377ladp5.fsf@gmail.com \
--to=go.wigust@gmail.com \
--cc=28381@debbugs.gnu.org \
--cc=alezost@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).