From: Carlo Zancanaro <carlo@zancanaro.id.au>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 30637@debbugs.gnu.org
Subject: [bug#30637] [WIP] shepherd: Poll every 0.5s to find dead forked services
Date: Fri, 02 Mar 2018 21:13:53 +1100 [thread overview]
Message-ID: <87371ihjj2.fsf@zancanaro.id.au> (raw)
In-Reply-To: <87r2p2izgz.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1962 bytes --]
Hey Ludo,
On Fri, Mar 02 2018, Ludovic Courtès wrote:
>> I am doing that. The problem is that when a service dies
>> (crashes, quits, etc.) the `respawn?` option cannot be honoured
>> because shepherd is not notified that the process has
>> terminated (because it never receives a SIGCHLD for the forked
>> pid). My patch polls for the processes we expect, to make up
>> for the lack of notification.
>
> I see.
>
> Actually, thinking more about it, we should be using
> PR_SET_CHILD_SUBREAPER from prctl(2), which is designed exactly
> for that.
Excellent! This is exactly the information that I needed. This is
what I've been looking for, but without enough knowledge to be
able to find it. Thanks!
> So what about this plan:
>
> 1. Add FFI bindings in (shepherd system) for prctl(2). We
> should arrange for it to throw to 'system-error when the
> ‘prctl’ symbol is missing, as is the case on GNU/Hurd.
Are we okay with having this just not work on GNU/Hurd (or kernels
older than 3.4, according to the prctl manpage)? We could fall
back to a polling approach if prctl isn't available? I don't
really like the idea of this working on some kernels but not
others, given that process supervision is one of the main jobs of
shepherd.
> 2. Use prctl/PR_SET_CHILD_SUBREAPER in ‘exec-command’. Here we
> must ‘catch-system-error’ around that call to cater to
> GNU/Hurd.
Why would we need to set it in exec-command? It looks like it
modifies the state of the calling process, which means we'd want
to set it in the shepherd service, not in each of the child
processes.
> That would address the main issue without having to resort to
> polling. Respawning will work only when #:pid-file is used
> though, but that’s already an improvement.
>
> Thoughts?
I'll try to get this working in the next few days. Hopefully
you'll see a patch from me soon.
Carlo
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2018-03-02 10:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-27 21:56 [bug#30637] [WIP] shepherd: Poll every 0.5s to find dead forked services Carlo Zancanaro
2018-02-28 22:06 ` Ludovic Courtès
2018-03-01 22:37 ` Carlo Zancanaro
2018-03-02 9:44 ` Ludovic Courtès
2018-03-02 10:13 ` Carlo Zancanaro [this message]
2018-03-02 12:42 ` Ludovic Courtès
2018-03-03 7:58 ` Carlo Zancanaro
2018-03-03 15:21 ` Ludovic Courtès
2018-03-03 20:49 ` Carlo Zancanaro
2018-03-04 22:11 ` Ludovic Courtès
2018-03-04 22:35 ` Carlo Zancanaro
2018-03-04 22:49 ` Ludovic Courtès
2018-03-04 23:08 ` Carlo Zancanaro
2018-03-05 14:15 ` bug#30637: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87371ihjj2.fsf@zancanaro.id.au \
--to=carlo@zancanaro.id.au \
--cc=30637@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).