From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35829) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1esElC-00074f-AX for guix-patches@gnu.org; Sat, 03 Mar 2018 16:32:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1esEl8-0003Bz-D8 for guix-patches@gnu.org; Sat, 03 Mar 2018 16:32:06 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:35225) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1esEl8-0003AS-9M for guix-patches@gnu.org; Sat, 03 Mar 2018 16:32:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1esEl7-0005tM-Tt for guix-patches@gnu.org; Sat, 03 Mar 2018 16:32:01 -0500 Subject: [bug#30679] [PATCH] Update VLC to 3.0.1 (Fixed submission - second try) Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: Date: Sat, 03 Mar 2018 22:31:00 +0100 In-Reply-To: (pkill9@runbox.com's message of "Fri, 02 Mar 2018 10:36:45 +0000 (GMT)") Message-ID: <87371galt7.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: pkill9@runbox.com Cc: 30679@debbugs.gnu.org Hello pkill9, Thanks for the patch! In the future, can you please send a patch containing a commit log that follows the project=E2=80=99s conventions, and produced by =E2=80=98git for= mat-patch=E2=80=99? See . Don=E2=80=99t worry if you=E2=80=99re unsure about the details, we can help. skribis: > (native-inputs > `(("git" ,git) ; needed for a test > + ("gcc" ,gcc) This is normally not needed. Can you remove it? > + ;Optional inputs > + ;("lua" ,lua) ;Configure phase doesn't find this > + ("libarchive" ,libarchive) > + ("livemedia-utils" ,livemedia-utils) > + ("libbluray" ,libbluray) > + ("samba" ,samba) > + ;("nfs-utils" ,(@ (gnu packages nfs) nfs-utils)) ;configure phase= doesn't find this > + ;("freerdp" ,(@ (gnu packages rdesktop) freerdp)) ;causes compila= tion failure > + ("libshout" ,libshout) > + ("libebml" ,libebml) > + ("libmatroska" ,libmatroska) > + ("libmodplug" ,libmodplug) > + ("mpg123" ,mpg123) > + ;("gstreamer" > + ; ,(@ (gnu packages gstreamer) gstreamer)) ;configure phase doesn= 't find this. Nitpick: please use two semicolons for comments like this (one semicolon is for margin comments.) > + ("libva" ,libva) > + ("twolame" ,twolame) > + ("libdca" ,libdca) > + ("libmpeg2" ,libmpeg2) > + ("speexdsp" ,speexdsp) > + ("fluidsynth" ,fluidsynth) > + ("libass" ,libass) > + ("fribidi" ,fribidi) > + ("librsvg" ,librsvg) > + ("libcaca" ,libcaca) > + ("jack" ,jack-1) > + ("soxr" ,soxr) > + ("chromaprint" ,chromaprint) > + ("protobuf" ,protobuf) > + ("eudev" ,eudev) > + ("libmtp" ,libmtp) > + ("libupnp" ,libupnp) > + ("taglib" ,taglib) > + ("libsecret" ,libsecret) > + ("libnotify" ,libnotify))) That=E2=80=99s a lot of new dependencies! :-) Could you check the impact this has on the size of vlc plus its dependencies, as shown by =E2=80=9Cguix size vlc=E2=80=9D? In many cases we add all the optional dependencies of the package, for convenience. However there are cases where doing it may be impractical, because that would make the whole thing just too big. If that is the case, we should keep a reduced set of dependencies of the =E2=80=98vlc=E2= =80=99 package and, if needed, add specific package variants with additional dependencies. > + (add-after 'build 'fix-misnamed-appdata > + ;; vlc.appdata.xml.in gets created instead of vlc.appdata.xml= , so > + ;; we copy it to the correct name - This solution is hacky, if the > + ;; root cause is found then please supply a patch. > + (lambda _ (copy-file "share/vlc.appdata.xml.in" "share/vlc.ap= pdata.xml"))) That looks fishy. Could you check if there=E2=80=99s a Makefile(.am) that mentions =E2=80=9Cvlc.appdata.xml=E2=80=9D so we can see how it=E2=80=99s s= upposed to be built? Thanks, Ludo=E2=80=99.