From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59558)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1f8tzr-0003LH-6d
	for guix-patches@gnu.org; Wed, 18 Apr 2018 16:48:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1f8tzm-0004ud-Sg
	for guix-patches@gnu.org; Wed, 18 Apr 2018 16:48:07 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:51802)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1f8tzm-0004uR-PA
	for guix-patches@gnu.org; Wed, 18 Apr 2018 16:48:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1f8tzm-0003Mw-Bl
	for guix-patches@gnu.org; Wed, 18 Apr 2018 16:48:02 -0400
Subject: [bug#31133] [PATCH 2/3] gnu: emacs-lispy: Change source to recent Git
	commit.
Resent-Message-ID: <handler.31133.B31133.152408443012879@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20180412073715.6123-1-clement@lassieur.org>
	<20180412073715.6123-2-clement@lassieur.org>
Date: Wed, 18 Apr 2018 22:47:05 +0200
In-Reply-To: <20180412073715.6123-2-clement@lassieur.org>
	("=?UTF-8?Q?Cl=C3=A9ment?=
	Lassieur"'s message of "Thu, 12 Apr 2018 09:37:14 +0200")
Message-ID: <8736zsutrq.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur <clement@lassieur.org>
Cc: 31133@debbugs.gnu.org

Cl=C3=A9ment Lassieur <clement@lassieur.org> skribis:

> Release 0.26.0 was almost 3 years ago, and there have been ~772 commits s=
ince.
>
> * gnu/packages/emacs.scm (emacs-lispy): Wrap with let, and change source =
to
> the Git repository.
> [propagated-inputs]: Add emacs-zoutline.

Could you move the sentence above as a comment here:

> +  (let ((commit "a7e1cf742e72199cc75aa5e1e686991ba4a23bc4")
> +        (revision "0"))
> +    (package
> +      (name "emacs-lispy")
> +      (version (git-version "0.26.0" revision commit))

?

Otherwise LGTM, thanks!

Ludo=E2=80=99.