From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47142)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fMv8b-0003gi-5S
	for guix-patches@gnu.org; Sun, 27 May 2018 08:51:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fMv8Y-0003K8-46
	for guix-patches@gnu.org; Sun, 27 May 2018 08:51:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:42306)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1fMv8Y-0003Jj-0G
	for guix-patches@gnu.org; Sun, 27 May 2018 08:51:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fMv8X-00033A-Jk
	for guix-patches@gnu.org; Sun, 27 May 2018 08:51:01 -0400
Subject: [bug#31592] [PATCH 1/4] gnu: Add squashfs-tools-next.
Resent-Message-ID: <handler.31592.B31592.152742542611682@debbugs.gnu.org>
From: ludovic.courtes@inria.fr (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <idj4liv95cu.fsf@bimsb-sys02.mdc-berlin.net>
	<20180525154730.23955-1-ricardo.wurmus@mdc-berlin.de>
Date: Sun, 27 May 2018 14:50:16 +0200
In-Reply-To: <20180525154730.23955-1-ricardo.wurmus@mdc-berlin.de> (Ricardo
	Wurmus's message of "Fri, 25 May 2018 17:47:27 +0200")
Message-ID: <8736ydz2if.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: 31592@debbugs.gnu.org

Hello!

Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:

> * gnu/packages/compression.scm (squashfs-tools-next): New variable.

[...]

> +;; We need this for building squashfs images with symlinks.
> +(define-public squashfs-tools-next
> +  (let ((commit "fb33dfc32b131a1162dcf0e35bd88254ae10e265")
> +        (revision "1"))

Does it mean that the current version does not support symlinks in the
image?

> +    (package (inherit squashfs-tools)
> +      (name "squashfs-tools-next")
> +      (version (string-append "4.3-" revision (string-take commit 7)))

Nitpick: you can use (git-version =E2=80=A6) here.

Otherwise LGTM, thanks!

Ludo=E2=80=99.