From: ludovic.courtes@inria.fr (Ludovic Courtès)
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: 31592@debbugs.gnu.org
Subject: [bug#31592] [PATCH 1/4] gnu: Add squashfs-tools-next.
Date: Sun, 27 May 2018 14:50:16 +0200 [thread overview]
Message-ID: <8736ydz2if.fsf@gnu.org> (raw)
In-Reply-To: <20180525154730.23955-1-ricardo.wurmus@mdc-berlin.de> (Ricardo Wurmus's message of "Fri, 25 May 2018 17:47:27 +0200")
Hello!
Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:
> * gnu/packages/compression.scm (squashfs-tools-next): New variable.
[...]
> +;; We need this for building squashfs images with symlinks.
> +(define-public squashfs-tools-next
> + (let ((commit "fb33dfc32b131a1162dcf0e35bd88254ae10e265")
> + (revision "1"))
Does it mean that the current version does not support symlinks in the
image?
> + (package (inherit squashfs-tools)
> + (name "squashfs-tools-next")
> + (version (string-append "4.3-" revision (string-take commit 7)))
Nitpick: you can use (git-version …) here.
Otherwise LGTM, thanks!
Ludo’.
next prev parent reply other threads:[~2018-05-27 12:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-25 14:28 [bug#31592] Add Singularity and squashfs image support to guix pack Ricardo Wurmus
2018-05-25 15:47 ` [bug#31592] [PATCH 1/4] gnu: Add squashfs-tools-next Ricardo Wurmus
2018-05-25 15:47 ` [bug#31592] [PATCH 2/4] gnu: Add singularity Ricardo Wurmus
2018-05-27 12:52 ` Ludovic Courtès
2018-05-27 18:14 ` Ricardo Wurmus
2018-06-06 8:31 ` Danny Milosavljevic
2018-06-06 9:57 ` Ricardo Wurmus
2018-05-25 15:47 ` [bug#31592] [PATCH 3/4] pack: Rename "tar" to "archiver" Ricardo Wurmus
2018-05-25 15:47 ` [bug#31592] [PATCH 4/4] pack: Add support for squashfs images Ricardo Wurmus
2018-05-27 12:57 ` Ludovic Courtès
2018-05-27 18:17 ` Ricardo Wurmus
2018-05-28 7:49 ` Ludovic Courtès
2018-05-27 12:50 ` Ludovic Courtès [this message]
2018-05-27 18:11 ` [bug#31592] [PATCH 1/4] gnu: Add squashfs-tools-next Ricardo Wurmus
2018-05-28 15:37 ` bug#31592: " Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736ydz2if.fsf@gnu.org \
--to=ludovic.courtes@inria.fr \
--cc=31592@debbugs.gnu.org \
--cc=ricardo.wurmus@mdc-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).