unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#31729] [PATCH] gnu: debootstrap: Substitute chroot in 'patch-source' phase.
@ 2018-06-05 20:20 Kei Kebreau
  2018-06-08 14:45 ` Ludovic Courtès
  0 siblings, 1 reply; 3+ messages in thread
From: Kei Kebreau @ 2018-06-05 20:20 UTC (permalink / raw)
  To: 31729; +Cc: Kei Kebreau

* gnu/packages/debian.scm (debootstrap)[arguments]: In 'patch-source' phase,
substitute chroot in the debootstrap script file.
---
 gnu/packages/debian.scm | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/debian.scm b/gnu/packages/debian.scm
index 01df30c55..5df575255 100644
--- a/gnu/packages/debian.scm
+++ b/gnu/packages/debian.scm
@@ -129,6 +129,7 @@ contains the archive keys used for that.")
          (add-after 'unpack 'patch-source
            (lambda* (#:key inputs outputs #:allow-other-keys)
              (let ((out    (assoc-ref outputs "out"))
+                   (coreutils (assoc-ref inputs "coreutils"))
                    (wget   (assoc-ref inputs "wget"))
                    (debian (assoc-ref inputs "debian-keyring"))
                    (ubuntu (assoc-ref inputs "ubuntu-keyring")))
@@ -141,6 +142,7 @@ contains the archive keys used for that.")
                (substitute* "scripts/gutsy"
                  (("/usr") ubuntu))
                (substitute* "debootstrap"
+                 (("chroot ") (string-append coreutils "/bin/chroot "))
                  (("=/usr") (string-append "=" out)))
                (substitute* "functions"
                  (("wget ") (string-append wget "/bin/wget ")))
@@ -154,7 +156,8 @@ contains the archive keys used for that.")
        #:make-flags (list (string-append "DESTDIR=" (assoc-ref %outputs "out")))
        #:tests? #f)) ; no tests
     (inputs
-     `(("debian-keyring" ,debian-archive-keyring)
+     `(("coreutils" ,coreutils)
+       ("debian-keyring" ,debian-archive-keyring)
        ("ubuntu-keyring" ,ubuntu-keyring)
        ("wget" ,wget)))
     ;; The following are required for debootstrap to work correctly
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [bug#31729] [PATCH] gnu: debootstrap: Substitute chroot in 'patch-source' phase.
  2018-06-05 20:20 [bug#31729] [PATCH] gnu: debootstrap: Substitute chroot in 'patch-source' phase Kei Kebreau
@ 2018-06-08 14:45 ` Ludovic Courtès
  2018-06-08 15:09   ` bug#31729: " Kei Kebreau
  0 siblings, 1 reply; 3+ messages in thread
From: Ludovic Courtès @ 2018-06-08 14:45 UTC (permalink / raw)
  To: Kei Kebreau; +Cc: 31729

Hello Kei,

Kei Kebreau <kkebreau@posteo.net> skribis:

> * gnu/packages/debian.scm (debootstrap)[arguments]: In 'patch-source' phase,
> substitute chroot in the debootstrap script file.

Please add “[inputs]: Add COREUTILS.” as well.  Otherwise LGTM!

Thanks,
Ludo’.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#31729: [PATCH] gnu: debootstrap: Substitute chroot in 'patch-source' phase.
  2018-06-08 14:45 ` Ludovic Courtès
@ 2018-06-08 15:09   ` Kei Kebreau
  0 siblings, 0 replies; 3+ messages in thread
From: Kei Kebreau @ 2018-06-08 15:09 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 31729-done

[-- Attachment #1: Type: text/plain, Size: 413 bytes --]

ludo@gnu.org (Ludovic Courtès) writes:

> Hello Kei,
>
> Kei Kebreau <kkebreau@posteo.net> skribis:
>
>> * gnu/packages/debian.scm (debootstrap)[arguments]: In 'patch-source' phase,
>> substitute chroot in the debootstrap script file.
>
> Please add “[inputs]: Add COREUTILS.” as well.  Otherwise LGTM!
>
> Thanks,
> Ludo’.

Thanks for reviewing! Pushed to master with the suggested change.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-06-08 15:11 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-05 20:20 [bug#31729] [PATCH] gnu: debootstrap: Substitute chroot in 'patch-source' phase Kei Kebreau
2018-06-08 14:45 ` Ludovic Courtès
2018-06-08 15:09   ` bug#31729: " Kei Kebreau

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).