From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43704) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fi2qt-0006ot-Bd for guix-patches@gnu.org; Tue, 24 Jul 2018 15:20:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fi2qo-0007iQ-QV for guix-patches@gnu.org; Tue, 24 Jul 2018 15:20:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:50793) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fi2qo-0007iM-LH for guix-patches@gnu.org; Tue, 24 Jul 2018 15:20:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fi2qo-0006Fa-B0 for guix-patches@gnu.org; Tue, 24 Jul 2018 15:20:02 -0400 Subject: [bug#32192] [PATCH 0/7] Remove duplicated packages. Resent-Message-ID: References: <87k1ptehfi.fsf@cbaines.net> <20180717210733.GC12949@jasmine.lan> <877elry3xo.fsf@gnu.org> <8736w954fe.fsf@gnu.org> From: Christopher Baines In-reply-to: <8736w954fe.fsf@gnu.org> Date: Tue, 24 Jul 2018 20:19:29 +0100 Message-ID: <8736w81lxa.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 32192@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > ludo@gnu.org (Ludovic Court=C3=A8s) skribis: > >> It=E2=80=99s terrible to see there were so many duplicate packages. >> >> The package lookup machinery detects and warns about same-named packages >> when you do things like: >> >> (define-public var1 >> (package (name "something") =E2=80=A6)) >> (define-public var2 >> (package (name "something") =E2=80=A6)) >> >> The problem here is that duplicates were in the same module and using >> the same variable name, such that the second definition would shadow the >> first one, and so Guix only sees one package. >> >> I think we should add a warning in the compiler for this situation. > > Done! > > https://git.savannah.gnu.org/cgit/guile.git/commit/?h=3Dstable-2.2&id= =3Dbdcd0ba8a71af24f0b64d7acac3130d8f541d26c > > Now you get warnings like this: > > --8<---------------cut here---------------start------------->8--- > $ /data/src/guile-2.1/meta/uninstalled-env guild compile -Wshadowed-tople= vel gnu/packages/haskell.scm > gnu/packages/haskell.scm:9224:0: warning: shadows previous definition of = `ghc-th-lift-instances' at gnu/packages/haskell.scm:5437:0 > gnu/packages/haskell.scm:9306:0: warning: shadows previous definition of = `ghc-time-locale-compat' at gnu/packages/haskell.scm:2591:0 > wrote `/data/src/guile-2.1/cache/guile/ccache/2.2-LE-8-3.A/home/ludo/src/= guix/gnu/packages/haskell.scm.go' > $ /data/src/guile-2.1/meta/uninstalled-env guild compile -Wshadowed-tople= vel gnu/packages/emacs.scm > gnu/packages/emacs.scm:8704:0: warning: shadows previous definition of `e= macs-load-relative' at gnu/packages/emacs.scm:3467:0 > gnu/packages/emacs.scm:9648:0: warning: shadows previous definition of `e= macs-csv-mode' at gnu/packages/emacs.scm:7390:0 > wrote `/data/src/guile-2.1/cache/guile/ccache/2.2-LE-8-3.A/home/ludo/src/= guix/gnu/packages/emacs.scm.go' > --8<---------------cut here---------------end--------------->8--- > > This will be in Guile 2.2.5. Awesome! Thanks Ludo=E2=80=99 :D --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAltXe8FfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9Xfdjg//VFV2/OKBPPY3720pQq/wC1Oi/yGb4UaTTTcJqk5OoyLnPjA8c4xRpkKr +Io/CbUcZsyBhlrGy2eBf3dBrN9u/wx4WFjBUw9B1N3DDlBLBX6o1IN3HIbqY8ch Hr4Afz0w4zTPvRq+hH3AMFTw+WqOIpE9QAekY9uOVbE7smIaoFcqjcphO7c1PyXu Y+hjo+0D/rRAH3It6heOKQiwamjUtab5MDkiYzzCmqT1fg09sNPSggWH6ghzqLV+ jLE4TAM5S5KtNyeUnmrWctmhKJtOa3bO9b3bZrdL9kBdA32zbei2eyRNW3yoxjX9 9w9AsVF/wtQQZtsu3Fg6dnH9wJnVcG6bTYD6DRLApNTszZiilzGDV6HcPhcAQTBH fBlSqJap5h6cb9wsItZYV0RElESHy0Z9DPl9ZFloqnS+El1NG5Xd79RJO3TL4fyL Aa+DB6mLesr8JRtIMnqv/giZBpixaS0FXpmJBiLx5YBKQ8unLqPD9TLwVuqlc5N3 9+a7rVxXQcHAacfVxsEiyAHzPYR4QK19R7jOVtD3kFgVmOtpBkasMlh+NA7raeTe lSN5W3X9sOLQ8gMkwucr81O/G0pGQ6p1/7MicW7sZ3X035FDh9nPJM2z7FmGo4QC q/dh0lu8RQhePa6JFLiEmdFbfiLNa+e2vFzJXuoL3Vyk5ropo74= =tiKT -----END PGP SIGNATURE----- --=-=-=--