From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36537) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fkD8N-0007GB-Qm for guix-patches@gnu.org; Mon, 30 Jul 2018 14:43:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fkD8J-0000kY-16 for guix-patches@gnu.org; Mon, 30 Jul 2018 14:43:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:58596) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fkD8I-0000kS-Mw for guix-patches@gnu.org; Mon, 30 Jul 2018 14:43:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fkD8I-000404-Ak for guix-patches@gnu.org; Mon, 30 Jul 2018 14:43:02 -0400 Subject: [bug#31999] [PATCH 3/7] gnu: Add libbytesize. Resent-Message-ID: From: Marius Bakke In-Reply-To: <20180730133612.29802-1-ambrevar@gmail.com> References: <87a7q911sy.fsf@gmail.com> <20180730133612.29802-1-ambrevar@gmail.com> Date: Mon, 30 Jul 2018 20:42:25 +0200 Message-ID: <8736w036r2.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Pierre Neidhardt , 31999@debbugs.gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Pierre Neidhardt writes: > * gnu/package/c.scm (libbytesize): New variable. [...] > +(define-public libbytesize > + (package > + (name "libbytesize") > + (version "1.3") > + (source (origin > + (method url-fetch) > + (uri (string-append > + "https://github.com/storaged-project/libbytesize/arc= hive/" > + version ".tar.gz")) > + (file-name (string-append name "-" version "-checkout")) > + (sha256 > + (base32 > + "0pfm1d0cpm3l0f17n567fhfh9dxjn9y59pgjajgsagp0nc0lmf2x"))= )) Please use the release tarball instead of a git checkout: https://github.com/storaged-project/libbytesize/releases/download/1.3/libby= tesize-1.3.tar.gz > + (build-system gnu-build-system) > + (native-inputs > + `(("autoconf" ,autoconf) > + ("automake" ,automake) > + ("libtool" ,libtool) > + ("gettext" ,gettext-minimal) ...then you can (probably) remove these inputs as well. Apart from that LGTM! > + ("pkg-config" ,pkg-config) > + ("python" ,python))) > + (inputs > + `(("mpfr" ,mpfr) > + ("pcre" ,pcre))) > + ;; One test fails because busctl (systemd only?) and python2-pocketl= int > + ;; are missing. Should we fix it, we would need the "python-2" , > + ;; "python2-polib" and "python2-six" native-inputs. > + (arguments `(#:tests? #f)) > + (home-page "https://github.com/storaged-project/libbytesize") > + (synopsis "Tiny C library for working with arbitrary big sizes in by= tes") > + (description > + "The goal of this project is to provide a tiny library that would > +facilitate the common operations with sizes in bytes. Many projects nee= d to > +work with sizes in bytes (be it sizes of storage space, memory...) and a= ll of > +them need to deal with the same issues like: > + > +@itemize > +@item How to get a human-readable string for the given size? > +@item How to store the given size so that no significant information is = lost? > +@item If we store the size in bytes, what if the given size gets over the > +MAXUINT64 value? > +@item How to interpret sizes entered by users according to their locale = and > +typing conventions? > +@item How to deal with the decimal/binary units (MB versus MiB) ambiguit= y? > +@end itemize > + > +@code{libbytesize} offers a generally usable solution that could be used= by > +every project that needs to deal with sizes in bytes. It is written in = the C > +language with thin bindings for other languages.") > + (license license:lgpl2.1+))) > --=20 > 2.18.0 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAltfXBEACgkQoqBt8qM6 VPq7Ygf9H7HTiEGSsVrVDpcxpZf003zKkHjCvShnwAKdCFV8RiaKGYRwtT1SLZM1 StW5X6q4+FhCr1Sw1dtIDuInpfHf6wWUagmu8NnFH58ukTqyeYLWu9qFgBkjFCPn 2m7bNDXxQR8+rFWLeXB9QnOzMl7o/pVASTHWbYhaj0o2cx2k7FS0Hn5r82n8bdUP 4R9rkTazUXCSjsgaiRBv2TcQNZ2F6D0AHgBbvLoqjHaH3WajHTwDK2nhXDsD7dS5 WWeNnaMK9MuTH3w05XlLQLBhioxk33ISKyH7GrxccfqbwyhZkVmil4Zf31od9Na7 4meMeP+G9/7OYU1QSFFqnh8OwikGNQ== =PMKJ -----END PGP SIGNATURE----- --=-=-=--