From: Kei Kebreau <kkebreau@posteo.net>
To: Arun Isaac <arunisaac@systemreboot.net>
Cc: 33963@debbugs.gnu.org
Subject: [bug#33963] [PATCH] gnu: octave: Fix makeinfo path configuration
Date: Fri, 04 Jan 2019 22:24:30 -0500 [thread overview]
Message-ID: <8736q7bxch.fsf@posteo.net> (raw)
In-Reply-To: <cu7h8epheiq.fsf@systemreboot.net> (Arun Isaac's message of "Thu, 03 Jan 2019 22:20:05 +0530")
[-- Attachment #1: Type: text/plain, Size: 2476 bytes --]
Arun Isaac <arunisaac@systemreboot.net> writes:
> The makeinfo path now needs to be substituted in
> libinterp/corefcn/help.h, not libinterp/corefn/help.cc. I have addressed
> this in the attached patch.
>
> I have also filed a bug upstream asking them to add a configure flag
> --with-makeinfo. Hopefully, we won't have to manually substitute
> the path to makeinfo in the next release.
>
> https://savannah.gnu.org/bugs/index.php?55371
>
> From 36612684f6f7719aef4b1b9fd40632b8749fcd90 Mon Sep 17 00:00:00 2001
> From: Arun Isaac <arunisaac@systemreboot.net>
> Date: Thu, 3 Jan 2019 21:56:26 +0530
> Subject: [PATCH] gnu: octave: Fix makeinfo path configuration.
>
> * gnu/packages/maths.scm (octave-cli)[arguments]: Fix makeinfo path
> configuration in configure-makeinfo phase.
> ---
> gnu/packages/maths.scm | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
> index 448d9e373..e67bc5e93 100644
> --- a/gnu/packages/maths.scm
> +++ b/gnu/packages/maths.scm
> @@ -19,7 +19,7 @@
> ;;; Copyright © 2017 Nils Gillmann <ng0@n0.is>
> ;;; Copyright © 2017 Ben Woodcroft <donttrustben@gmail.com>
> ;;; Copyright © 2017 Theodoros Foradis <theodoros@foradis.org>
> -;;; Copyright © 2017 Arun Isaac <arunisaac@systemreboot.net>
> +;;; Copyright © 2017, 2019 Arun Isaac <arunisaac@systemreboot.net>
> ;;; Copyright © 2017, 2018 Tobias Geerinckx-Rice <me@tobias.gr>
> ;;; Copyright © 2017 Dave Love <me@fx@gnu.org>
> ;;; Copyright © 2018 Jan Nieuwenhuizen <janneke@gnu.org>
> @@ -1484,11 +1484,10 @@ can solve two kinds of problems:
> (modify-phases %standard-phases
> (add-after 'configure 'configure-makeinfo
> (lambda* (#:key inputs #:allow-other-keys)
> - (substitute* "libinterp/corefcn/help.cc"
> - (("Vmakeinfo_program = \"makeinfo\"")
> - (string-append "Vmakeinfo_program = \""
> - (assoc-ref inputs "texinfo")
> - "/bin/makeinfo\"")))
> + (substitute* "libinterp/corefcn/help.h"
> + (("\"makeinfo\"")
> + (string-append
> + "\"" (assoc-ref inputs "texinfo") "/bin/makeinfo\"")))
> #t)))))
> (home-page "https://www.gnu.org/software/octave/")
> (synopsis "High-level language for numerical computation")
LGTM.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2019-01-05 3:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-03 16:50 [bug#33963] [PATCH] gnu: octave: Fix makeinfo path configuration Arun Isaac
2019-01-05 3:24 ` Kei Kebreau [this message]
2019-01-05 18:25 ` bug#33963: " Arun Isaac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736q7bxch.fsf@posteo.net \
--to=kkebreau@posteo.net \
--cc=33963@debbugs.gnu.org \
--cc=arunisaac@systemreboot.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).