From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:39193)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gmylN-0001DU-88
	for guix-patches@gnu.org; Fri, 25 Jan 2019 05:31:10 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gmylK-000064-Lh
	for guix-patches@gnu.org; Fri, 25 Jan 2019 05:31:03 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:45294)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gmylK-00005i-81
	for guix-patches@gnu.org; Fri, 25 Jan 2019 05:31:02 -0500
Subject: [bug#34165] [PATCH] gnu: bitcoin-core: Make bitcoin-qt deterministic.
Resent-Message-ID: <handler.34165.B34165.15484122196444@debbugs.gnu.org>
References: <qHq-f-ApWJCp4wLr7bTekukXH3hkLWqooUuEQeJIcXKG1vDbOCsBUYpeedzxf1qeM1CWiGKy6pfeME24YXbJDqD3RA6zUt3fv324jK-n09g=@carldong.me>
	<87munrivyd.fsf@gnu.org>
From: Ricardo Wurmus <rekado@elephly.net>
In-reply-to: <87munrivyd.fsf@gnu.org>
Date: Wed, 23 Jan 2019 15:41:43 +0100
Message-ID: <8736pj77x4.fsf@elephly.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: 34165@debbugs.gnu.org, Carl Dong <contact@carldong.me>


Ludovic Court=C3=A8s <ludo@gnu.org> writes:

> Hi!
>
> Carl Dong <contact@carldong.me> skribis:
>
>>>>From 2b3162dde22a5d44eb5910b0fcfa07318f935aaf Mon Sep 17 00:00:00 2001
>> From: Carl Dong <accounts@carldong.me>
>> Date: Mon, 21 Jan 2019 14:51:57 -0500
>> Subject: [PATCH] gnu: bitcoin-core: Make bitcoin-qt deterministic.
>
> [...]
>
>> +          (add-before 'configure 'qt-time
>> +           (lambda _
>> +            (setenv "QT_RCC_SOURCE_DATE_OVERRIDE" "1"))) ; Make QT dete=
rministic
>
> Looking at this and the upstream commit=C2=B9, I=E2=80=99m thinking maybe=
 we should
> do the same in other Qt applications.  Any idea how we can identify
> applications where it=E2=80=99s needed?
>
> =C2=B9
> https://github.com/qt/qtbase/commit/38271e9298dcf48652a6e2e08414a940a9786=
7fa

This is a bit unfortunate.  It seems to me that the original intent of
the patch was to support SOURCE_DATE_EPOCH as the commit message
mentions that variable=E2=80=99s specification.  Pity that it is now a cust=
om Qt
variable.

This probably should be used for all packages that generate resource
files, which I assume are most non-trivial applications.  I think it=E2=80=
=99s
fine to add it to all packages using qtbase.

--
Ricardo