From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:58987) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1grUoj-0003vy-VQ for guix-patches@gnu.org; Wed, 06 Feb 2019 16:33:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1grUof-0004qp-OC for guix-patches@gnu.org; Wed, 06 Feb 2019 16:33:12 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:36970) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1grUoX-0004o4-Ro for guix-patches@gnu.org; Wed, 06 Feb 2019 16:33:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1grUoX-0000Tp-Lk for guix-patches@gnu.org; Wed, 06 Feb 2019 16:33:01 -0500 Subject: [bug#34189] [PATCH] gnu: Add arcan. Resent-Message-ID: From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: Date: Wed, 06 Feb 2019 22:32:49 +0100 In-Reply-To: (L. p. R. n. d. n.'s message of "Thu, 24 Jan 2019 13:54:17 +0100") Message-ID: <8736p08uwu.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: L p R n d n Cc: 34189@debbugs.gnu.org Hello, Sorry for the delay! Here are some comments. L p R n d n skribis: >>>From f1d5416c9d7a8a5ba5ecb4d380d06ee066b62a29 Mon Sep 17 00:00:00 2001 > From: Lprndn > Date: Thu, 24 Jan 2019 13:29:21 +0100 > Subject: [PATCH] gnu: Add arcan. > > * gnu/packages/arcan.scm New module. > * gnu/packages/arcan.scm (arcan): New variable. Should be just: * gnu/packages/arcan.scm: New file. > +++ b/gnu/packages/arcan.scm > @@ -0,0 +1,130 @@ > +(define-module (gnu packages arcan) Please add the standard GPLv3+ header with a copyright line for yourself. > + (package > + (name "arcan") > + (version "0.5.5.2") ;A few commits ahead, really. To= fix some bugs. Please use the versioning scheme for Git snapshots explained here: https://www.gnu.org/software/guix/manual/en/html_node/Version-Numbers.html > + `("ARCAN_SCRIPTPATH" ":" suffix > + (,(string-append out "/share/arcan/scripts"))))) [...] > + (native-search-paths > + (list (search-path-specification > + (variable "ARCAN_APPLBASEPATH") > + (separator #f) > + (files '("share/arcan/appl"))))) Should ARCAN_SCRIPTPATH also be here? > + ("arcan-openal" ,(origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/letoram/openal.= git") > + (commit "1c7302c580964fee9ee9e1d89ff56d2= 4f934bdef"))) > + (sha256 > + (base32 > + "0dcxcnqjkyyqdr2yk84mprvkncy5g172kfs6vc4zrkk= lsbkr8yi2")))))) Did you try vanilla OpenAL instead? If you have a pointer to a page explaining why this variant is needed, that=E2=80=99d be great! Also pleas= e add a =E2=80=98file-name=E2=80=99 for this =E2=80=98origin=E2=80=99. > + (native-inputs > + `(("pkg-config" ,pkg-config) > + ("ruby" ,ruby))) ; For documentation and testing > + (home-page "https://arcan-fe.com") > + (synopsis "Combined display server, multimedia framework and game en= gine (egl-dri)") Maybe just =E2=80=9CMultimedia framework and game engine=E2=80=9D? > + (description "Arcan is a powerful development framework for creating= virtually > +anything from user interfaces for specialized embedded applications > +all the way to full-blown desktop environments") Missing period at the end, =E2=80=9Cpowerful=E2=80=9D is maybe not factual = enough, and it would be good if you could expound with just a sentence or two (see ). > + (license (list license:gpl2+ > + license:lgpl2.0 > + license:bsd-3)))) Could you add a comment above explaining the meaning of the list (whether it=E2=80=99s triple-licensed or what)? Apart from that this LGTM. It=E2=80=99s great that you managed to unbundle almost everything. Could you send an updated patch? Thanks! Ludo=E2=80=99.