From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:45082) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIcDk-000162-6I for guix-patches@gnu.org; Mon, 22 Apr 2019 12:55:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hIc9n-0004FZ-MP for guix-patches@gnu.org; Mon, 22 Apr 2019 12:51:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:37904) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hIc9n-0004FT-JT for guix-patches@gnu.org; Mon, 22 Apr 2019 12:51:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hIc9n-0006NC-Cy for guix-patches@gnu.org; Mon, 22 Apr 2019 12:51:03 -0400 Subject: [bug#35234] [PATCH] gnu: Add the-dark-mod. Resent-Message-ID: From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20190411181644.21661-1-mail@ambrevar.xyz> <87d0lsib4l.fsf@elephly.net> <878swflfze.fsf@ambrevar.xyz> <87o95b31ta.fsf@elephly.net> <87mukvjusd.fsf@ambrevar.xyz> <87ef5v78f8.fsf@elephly.net> <87pnpf72ns.fsf@gnu.org> <87k1fm9zw5.fsf@ambrevar.xyz> <878sw275ye.fsf@elephly.net> Date: Mon, 22 Apr 2019 18:50:37 +0200 In-Reply-To: <878sw275ye.fsf@elephly.net> (Ricardo Wurmus's message of "Mon, 22 Apr 2019 11:19:21 +0200") Message-ID: <8736mayof6.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ricardo Wurmus Cc: 35234@debbugs.gnu.org, Pierre Neidhardt Ricardo Wurmus skribis: > The package claims to provide a game, not a game engine. As a user I > would install this only to be told that I need to obtain proprietary > software (i.e. the game or the demo) to play this. This is steering > people to seek out and use proprietary software. > > We should change the package so that it conveys the right message, > either by making it clear that this is not a game but the game engine, > or by including the game data. Even if the data are non-functional they > must be redistributable. If they are not then we cannot include the > game data and it would be highly misleading to call the package after > the game. I agree. Pierre, can you look into implementing one of these two options? >> * gnu/packages/games.scm (the-dark-mod): New variable. > [=E2=80=A6] >> + (synopsis "Game based on the Thief series by Looking Glass Studio= s") >> + (description (format #f "The Dark Mod (TDM) is stealth/infiltrati= on game >> +based on the Thief series by Looking Glass Studios. Formerly a Doom II= I mod, >> +it is now released as a standalone. >> + >> +The game data must be fetched manually by running @command{tdm_update}. >> +The ~a environment variable specifies the location where the game data = is >> +saved (defaults to ~a)." >> + the-dark-mod-env-var-name the-dark-mod-env-v= ar-value)) (As a side note: do not use =E2=80=98format=E2=80=99 here, or wrap the form= at string in =E2=80=98G_=E2=80=99 to allow for i18n.) > Is this actually free software? Does it depend on the proprietary Thief > game data to be playable? What is the purpose of tdm_update? > > I don=E2=80=99t think it=E2=80=99s good to have people run the tdm_update= tool, because > this smells like the anti pattern seen for many games in other > distributions where you really only install a downloader, which then > fetches the (potentially non-free) game data. > > The game data are free in this case, but since this is provided by an > unversioned URL it might not be when a user runs the command. I prefer > to include a snapshot of the game data. +1. The download script looks like giving upstream blanket permission; even from a technical standpoint, it goes counter our reproducibility mantra. (We would disable phone-home mechanisms, and automatic download of game data goes even a step further.) Ludo=E2=80=99.