From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:50928) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hn32F-0006MH-LR for guix-patches@gnu.org; Mon, 15 Jul 2019 11:37:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hn32E-0001F5-L1 for guix-patches@gnu.org; Mon, 15 Jul 2019 11:37:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39981) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hn32E-0001Ew-IG for guix-patches@gnu.org; Mon, 15 Jul 2019 11:37:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hn32E-0006n3-D0 for guix-patches@gnu.org; Mon, 15 Jul 2019 11:37:02 -0400 Subject: [bug#36555] [PATCH 1/2] guix system: Add 'reconfigure' module. Resent-Message-ID: From: zerodaysfordays@sdf.lonestar.org (Jakob L. Kreuze) References: <87imsci9sj.fsf@sdf.lonestar.org> <87ef30i9fl.fsf@sdf.lonestar.org> <87y3129qsn.fsf@gnu.org> <87sgr9bziq.fsf@sdf.lonestar.org> <87pnmc7nt1.fsf@gnu.org> Date: Mon, 15 Jul 2019 11:36:36 -0400 In-Reply-To: <87pnmc7nt1.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Sun, 14 Jul 2019 15:23:06 +0200") Message-ID: <8736j7nwcb.fsf@sdf.lonestar.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 36555@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Oh, I see. So in a way the problem is that =E2=80=98remote-eval=E2=80=99 = doesn=E2=80=99t do > anything sensible with the output and error ports of that remote > evaluation. > > Ultimately we should probably fix (guix inferior) and (guix remote) so > that stdout and stderr are properly transmitted. Thinking about it now, that could make error reporting for 'guix deploy' less complicated. We'd be able to output the remote's stdout/stderr to the host's stdout/stderr and be done with it. > In the meantime, what about this patch? > > diff --git a/guix/remote.scm b/guix/remote.scm > index e503c76167..8ada5c0957 100644 > --- a/guix/remote.scm > +++ b/guix/remote.scm > @@ -76,8 +76,14 @@ result to the current output port using the (guix repl= ) protocol." > (with-imported-modules (source-module-closure '((guix repl))) > #~(begin > (use-modules (guix repl)) > - (send-repl-response '(primitive-load #$program) > + > + ;; We use CURRENT-OUTPUT-PORT for REPL messages, so redirect PRO= GRAM's > + ;; output to CURRENT-ERROR-PORT so that it does not interfere. > + (send-repl-response '(with-output-to-port (current-error-port) > + (lambda () > + (primitive-load #$program))) > (current-output-port)) > + > (force-output)))) >=20=20 > (define* (remote-eval exp session LGTM, thanks! > =E2=80=98live-service-requirement=E2=80=99 gives you the graph of the cur= rently loaded > services, but you also need the target service graph to determine what > to upgrade; that seems to be missing currently. Oh, good catch. Reusing 'shepherd-service-upgrade' is certainly the way to go, then. Regards, Jakob --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEa1VJLOiXAjQ2BGSm9Qb9Fp2P2VoFAl0snYQACgkQ9Qb9Fp2P 2Vp3GBAAo9/SqB5Gl4m+FBv8WISgUPioVXp3wWWmCjiZ/yF2BC7lMJrnTjP/bUta Mxt3xmqWVj8I3tK4SjSbrWq4LuGnYe09kyJpgIol+/HYMYVjaWz3xy1dbnLNvaRE XjPI19QiZapsxdP9yYPQp4Yse3bugLQ5tnp7J5FfEiiIb1Pu1+wtFoTDKShJYUFG WyeR4PS4H2jotc4phOqi9ntMCcYrDJKMDfjx3ugFLGNF7YircypSw/fesjrABbwI kZ8LS2s7UTutH5EZ0q3vlz2iK+s7Z7dkjJlj/ZE6iVLaxXT2UlzF3VYkyI8aen6P gWkew8bDLUSVkZjMk+NMitBceM3nvjU94qSJ0a7ML2LdqxgcXBAtrgzoOuAX9UpX eCFVyGjPvQrsafCHtEIY1ccZ+9/nZlNgtmx52Pkr0q4s2mH6caSfsYHV7+FVmTbp jeS0W2mvBokkOX3AlZOQDwKxR/JBRoZZ9uapcZ+jzNS+jlHgQLOMqA8THDK7+Hfj JrGCwVKqnzztx0l3pP5LVtfnVUAS4KVjjUKiDmbO6N3WRmwTdGvqnod3oqBvnfwk czIXt3d+nQonwv3VfomYvq8mB5VZa0nEye+Iy2qRQxfTrTfOGY4DO+jmVmXoFUVc bIf183IR//ntFbWwhc8QZpSz9T3yOAmEBU9OHbvpAJzNQ89a1C8= =rQ3H -----END PGP SIGNATURE----- --=-=-=--