unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Christopher Lemmer Webber <cwebber@dustycloud.org>
To: 36955@debbugs.gnu.org
Subject: [bug#36955] [PATCH] machine: Add 'build-locally?' field for managed hosts.
Date: Wed, 07 Aug 2019 15:20:59 -0400	[thread overview]
Message-ID: <8736icpysk.fsf@dustycloud.org> (raw)
In-Reply-To: <87imr9402l.fsf@sdf.lonestar.org>

Looks good, though I assume this is a dependency for another patch
that's coming?

Jakob L. Kreuze writes:

> * gnu/machine/ssh.scm (machine-ssh-configuration-build-locally?): New
> variable.
> (managed-host-remote-eval): Pass 'build-locally?' to 'remote-eval'.
> ---
>  gnu/machine/ssh.scm | 26 ++++++++++++++++----------
>  1 file changed, 16 insertions(+), 10 deletions(-)
>
> diff --git a/gnu/machine/ssh.scm b/gnu/machine/ssh.scm
> index ae312597dd..1f16d9a5ea 100644
> --- a/gnu/machine/ssh.scm
> +++ b/gnu/machine/ssh.scm
> @@ -47,6 +47,7 @@
>              machine-ssh-configuration
>  
>              machine-ssh-configuration-host-name
> +            machine-ssh-configuration-build-locally?
>              machine-ssh-configuration-port
>              machine-ssh-configuration-user
>              machine-ssh-configuration-session))
> @@ -69,15 +70,17 @@
>    make-machine-ssh-configuration
>    machine-ssh-configuration?
>    this-machine-ssh-configuration
> -  (host-name machine-ssh-configuration-host-name) ; string
> -  (port      machine-ssh-configuration-port       ; integer
> -             (default 22))
> -  (user      machine-ssh-configuration-user       ; string
> -             (default "root"))
> -  (identity  machine-ssh-configuration-identity   ; path to a private key
> -             (default #f))
> -  (session   machine-ssh-configuration-session    ; session
> -             (default #f)))
> +  (host-name      machine-ssh-configuration-host-name) ; string
> +  (build-locally? machine-ssh-configuration-build-locally?
> +                  (default #t))
> +  (port           machine-ssh-configuration-port       ; integer
> +                  (default 22))
> +  (user           machine-ssh-configuration-user       ; string
> +                  (default "root"))
> +  (identity       machine-ssh-configuration-identity   ; path to a private key
> +                  (default #f))
> +  (session        machine-ssh-configuration-session    ; session
> +                  (default #f)))
>  
>  (define (machine-ssh-session machine)
>    "Return the SSH session that was given in MACHINE's configuration, or create
> @@ -103,7 +106,10 @@ one from the configuration's parameters if one was not provided."
>    "Internal implementation of 'machine-remote-eval' for MACHINE instances with
>  an environment type of 'managed-host."
>    (maybe-raise-unsupported-configuration-error machine)
> -  (remote-eval exp (machine-ssh-session machine)))
> +  (remote-eval exp (machine-ssh-session machine)
> +               #:build-locally?
> +               (machine-ssh-configuration-build-locally?
> +                (machine-configuration machine))))
>  
>  \f
>  ;;;

  reply	other threads:[~2019-08-07 19:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-07 12:44 [bug#36955] [PATCH] machine: Add 'build-locally?' field for managed hosts Jakob L. Kreuze
2019-08-07 19:20 ` Christopher Lemmer Webber [this message]
2019-08-07 20:47   ` Jakob L. Kreuze
2019-08-07 22:29     ` bug#36955: " Christopher Lemmer Webber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8736icpysk.fsf@dustycloud.org \
    --to=cwebber@dustycloud.org \
    --cc=36955@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).